Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing multiple issues reported in #497 #524

Address Heemin's comments

7ea7d90
Select commit
Loading
Failed to load commit list.
Merged

Fixing multiple issues reported in #497 #524

Address Heemin's comments
7ea7d90
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 29, 2023 in 0s

84.33% (-0.22%) compared to 5daddfd

View this Pull Request on Codecov

84.33% (-0.22%) compared to 5daddfd

Details

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (5daddfd) 84.55% compared to head (7ea7d90) 84.33%.

Files Patch % Lines
...ensearch/neuralsearch/query/HybridQueryScorer.java 70.00% 4 Missing and 2 partials ⚠️
...arch/processor/NormalizationProcessorWorkflow.java 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #524      +/-   ##
============================================
- Coverage     84.55%   84.33%   -0.22%     
- Complexity      532      533       +1     
============================================
  Files            40       40              
  Lines          1547     1564      +17     
  Branches        244      244              
============================================
+ Hits           1308     1319      +11     
- Misses          128      133       +5     
- Partials        111      112       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.