-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing multiple issues reported in #497 #524
Fixing multiple issues reported in #497 #524
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
============================================
- Coverage 84.55% 84.33% -0.22%
- Complexity 532 533 +1
============================================
Files 40 40
Lines 1547 1564 +17
Branches 244 244
============================================
+ Hits 1308 1319 +11
- Misses 128 133 +5
- Partials 111 112 +1 ☔ View full report in Codecov by Sentry. |
…ion for total hits Signed-off-by: Martin Gaievski <[email protected]>
807ea6a
to
534b2eb
Compare
Signed-off-by: Martin Gaievski <[email protected]>
534b2eb
to
e404775
Compare
Update the PR description to: same for the change log. |
src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java
Outdated
Show resolved
Hide resolved
Please add an IT for case when there are same queries in hyrbid query clause. |
added IT as requested |
1ed9285
to
500b81c
Compare
500b81c
to
c462f4d
Compare
Signed-off-by: Martin Gaievski <[email protected]>
c462f4d
to
6801844
Compare
Signed-off-by: Martin Gaievski <[email protected]>
src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/search/HitsTresholdCheckerTests.java
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <[email protected]>
src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/neuralsearch/query/HybridQueryIT.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <[email protected]>
585fbbe
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-524-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 585fbbe0da23bdb827bf012a85d6b2dc9af78c11
# Push it to GitHub
git push --set-upstream origin backport/backport-524-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…-project#524) * Allow multiple identical sub-queries in hybrid query, removed validation for total hits Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 585fbbe)
…-project#524) * Allow multiple identical sub-queries in hybrid query, removed validation for total hits Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 585fbbe) Signed-off-by: Martin Gaievski <[email protected]>
* Allow multiple identical sub-queries in hybrid query, removed validation for total hits (cherry picked from commit 585fbbe) Signed-off-by: Martin Gaievski <[email protected]>
Description
Fixed multiple issue in scope of this PR:
Issues Resolved
#497
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.