Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing multiple issues reported in #497 #524

Merged
merged 6 commits into from
Dec 29, 2023

Address Heemin's comments

7ea7d90
Select commit
Loading
Failed to load commit list.
Merged

Fixing multiple issues reported in #497 #524

Address Heemin's comments
7ea7d90
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 29, 2023 in 1s

70.37% of diff hit (target 84.55%)

View this Pull Request on Codecov

70.37% of diff hit (target 84.55%)

Annotations

Check warning on line 177 in src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/processor/NormalizationProcessorWorkflow.java#L177 

Added line #L177 was not covered by tests

Check warning on line 129 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L128-L129 

Added lines #L128 - L129 were not covered by tests

Check warning on line 133 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L132-L133 

Added lines #L132 - L133 were not covered by tests
View more details on Codecov