exclude commons-io and reflections class from ml-commons client jar #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yaliang Wu <[email protected]>
Zhangxunmt
approved these changes
Mar 10, 2023
b4sjoo
approved these changes
Mar 10, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #796 +/- ##
============================================
- Coverage 85.18% 85.15% -0.04%
+ Complexity 1606 1604 -2
============================================
Files 135 135
Lines 5954 5954
Branches 562 562
============================================
- Hits 5072 5070 -2
- Misses 646 648 +2
Partials 236 236
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ylwu-amzn
added a commit
to ylwu-amzn/ml-commons
that referenced
this pull request
Mar 11, 2023
…pensearch-project#796) Signed-off-by: Yaliang Wu <[email protected]>
Merged
5 tasks
ylwu-amzn
added a commit
that referenced
this pull request
Mar 11, 2023
…796) (#798) Signed-off-by: Yaliang Wu <[email protected]>
heemin32
added a commit
to heemin32/ml-commons
that referenced
this pull request
Mar 14, 2023
After PR opensearch-project#796, neural search integration test failed because of lack of refections dependency. Adding back the dependency and also updated dependency version to match it with SQL plugin to avoid Jarhell. Signed-off-by: Heemin Kim <[email protected]>
5 tasks
6 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
exclude commons-io and reflections class from ml-commons client jar
Now we are using GHA to publish ml-commons jar.
But the jar built by running
./gradlew publishShadowPublicationToSnapshotsRepositorycontains other classes from commons-io and reflectionBefore this PR, we can see such classes in
client/build/libs/opensearch-ml-client-2.7.0.0-SNAPSHOT.jar, that will cause Jarhell issue for SQL plugin as it depends on both commons-utils and ml-commons client .After this PR, these classes will be removed from ml-commons client jar.
Issues Resolved
#778
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.