-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #764 to only use shadowjar publication #959
Merged
peterzhuamazon
merged 2 commits into
opensearch-project:2.x
from
peterzhuamazon:test-2.8-shadow
Jun 3, 2023
Merged
Revert #764 to only use shadowjar publication #959
peterzhuamazon
merged 2 commits into
opensearch-project:2.x
from
peterzhuamazon:test-2.8-shadow
Jun 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
changed the title
Test 2.8 shadow
Revert #764 to only use shadowjar publication
Jun 3, 2023
42 tasks
Codecov Report
@@ Coverage Diff @@
## 2.x #959 +/- ##
=========================================
Coverage 82.32% 82.32%
Complexity 1918 1918
=========================================
Files 149 149
Lines 7506 7506
Branches 750 750
=========================================
Hits 6179 6179
Misses 987 987
Partials 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. |
ylwu-amzn
approved these changes
Jun 3, 2023
bbarani
approved these changes
Jun 3, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 3, 2023
* Revert #764 to only use shadowjar publication Signed-off-by: Peter Zhu <[email protected]> * Restore changes Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit e6dabc0)
ylwu-amzn
pushed a commit
that referenced
this pull request
Jun 3, 2023
* Revert #764 to only use shadowjar publication Signed-off-by: Peter Zhu <[email protected]> * Restore changes Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> (cherry picked from commit e6dabc0) Co-authored-by: Peter Zhu <[email protected]>
5 tasks
zane-neo
pushed a commit
to zane-neo/ml-commons
that referenced
this pull request
Aug 28, 2023
…search-project#959) * Revert opensearch-project#764 to only use shadowjar publication Signed-off-by: Peter Zhu <[email protected]> * Restore changes Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]>
5 tasks
zane-neo
added a commit
that referenced
this pull request
Aug 28, 2023
* Revert #764 to only use shadowjar publication * Restore changes --------- Signed-off-by: Peter Zhu <[email protected]> Co-authored-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert #764 to only use shadowjar publication.
ml used to publish a lot of unrelated content in jar, therefore this PR is created to only publish related classes:
#764
However, the added
jars
publication alongsideshadow
caused some race conditions, so the github actions task was switched back to usingshadow
, without removingjars
publication in #764.#779
The above race condition in gradle 7 is not observed clearly when building non-snapshot artifacts with
scripts/build.sh
but showing clear race conditions in gradle 8 after this PR:#892
The initial fix to this issue in #957 is not correct as it switch from shadow to jars, the exact same error spawns the fix of github actions in #779, causing dependent plugin such as neural-search failed with this error:
Plus, the issue observed in #764 has since been resolved by #796.
Therefore, the final fix to this issue is to remove the
jars
publication all together.Issues Resolved
opensearch-project/opensearch-build#3434
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.