Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back reflections dependency in ml-common #803

Closed
wants to merge 1 commit into from

Conversation

heemin32
Copy link

Description

After PR #796, neural search integration test failed because of lack of refections dependency. Adding back the dependency and also updated dependency version to match it with SQL plugin to avoid Jarhell.

Issues Resolved

https://github.com/opensearch-project/neural-search/actions/runs/4409797848/jobs/7726530275

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

After PR opensearch-project#796, neural search integration test failed because of lack of refections dependency. Adding back the dependency and also updated dependency version to match it with SQL plugin to avoid Jarhell.

Signed-off-by: Heemin Kim <[email protected]>
@heemin32 heemin32 requested a review from a team March 14, 2023 20:16
@heemin32 heemin32 closed this Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant