Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stat for query with filter #586

Conversation

martin-gaievski
Copy link
Member

Signed-off-by: Martin Gaievski [email protected]

Description

Adding counter stat "knn_query_with_filter_requests" for queries with filter field. Example of response with new stat

    "nodes": {
        "gIsW_7cBQwqSeZ2sr5knEw": {
            "graph_memory_usage_percentage": 0.0,
            "graph_query_requests": 0,
            "graph_memory_usage": 0,
            "cache_capacity_reached": false,
            "load_success_count": 0,
            "training_memory_usage": 0,
            "indices_in_cache": {},
            "script_query_errors": 0,
            "hit_count": 0,
            "knn_query_requests": 2,
            "total_load_time": 0,
            "miss_count": 0,
            "knn_query_with_filter_requests": 1,
            "training_memory_usage_percentage": 0.0,
            "lucene_initialized": true,
            "graph_index_requests": 0,
            "faiss_initialized": false,
            "load_exception_count": 0,
            "training_errors": 0,
            "eviction_count": 0,
            "nmslib_initialized": false,
            "script_compilations": 0,
            "script_query_requests": 0,
            "graph_query_errors": 0,
            "indexing_from_model_degraded": false,
            "graph_index_errors": 0,
            "training_requests": 0,
            "script_compilation_errors": 0
        }
    }

Issues Resolved

#376

Check List

  • New functionality includes testing.
    • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Refactor codec related classes, create KNNCodecVersion abstraction

Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski martin-gaievski added Enhancements Increases software capabilities beyond original client specifications 2.4.0 feature branch labels Oct 20, 2022
@martin-gaievski martin-gaievski requested a review from a team October 20, 2022 00:03
* Add initial support for filtering 

Signed-off-by: Martin Gaievski <[email protected]>
…project#564)

* Adding serialization/deserialization for filter field in Lucene knn query

Signed-off-by: Martin Gaievski <[email protected]>
…ject#581)

* Simplify min cluster version lookup

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski martin-gaievski force-pushed the add-query-filtering-stats branch from f0c8f96 to 5346fd7 Compare October 20, 2022 00:08
@heemin32 heemin32 added v2.4.0 'Issues and PRs related to version v2.4.0' and removed 2.4.0 labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancements Increases software capabilities beyond original client specifications feature branch v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants