Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests and logs for Lucene k-NN filtering #538

Conversation

martin-gaievski
Copy link
Member

Signed-off-by: Martin Gaievski [email protected]

Description

Multiple changes:

  • adding tests
  • adding log info
  • minor code adjustments/reformatting

Issues Resolved

#376

Check List

  • All tests pass
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Martin Gaievski <[email protected]>
@martin-gaievski martin-gaievski added Enhancements Increases software capabilities beyond original client specifications 2.4.0 feature branch labels Sep 7, 2022
@martin-gaievski martin-gaievski marked this pull request as ready for review September 7, 2022 17:21
@martin-gaievski martin-gaievski requested a review from a team September 7, 2022 17:21
Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding debug logs. LGTM!

@martin-gaievski martin-gaievski merged commit 417947e into opensearch-project:feature/efficient-filtering Sep 7, 2022
martin-gaievski added a commit to martin-gaievski/k-NN that referenced this pull request Oct 14, 2022
martin-gaievski added a commit that referenced this pull request Oct 14, 2022
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski added a commit to martin-gaievski/k-NN that referenced this pull request Oct 20, 2022
@heemin32 heemin32 added v2.4.0 'Issues and PRs related to version v2.4.0' and removed 2.4.0 labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancements Increases software capabilities beyond original client specifications feature branch v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants