-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding efficient filtering #515
Merged
martin-gaievski
merged 6 commits into
opensearch-project:feature/efficient-filtering
from
martin-gaievski:poc/pre-filtering-for-lucene-engine
Aug 22, 2022
Merged
Adding efficient filtering #515
martin-gaievski
merged 6 commits into
opensearch-project:feature/efficient-filtering
from
martin-gaievski:poc/pre-filtering-for-lucene-engine
Aug 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
added
Enhancements
Increases software capabilities beyond original client specifications
backport 2.x
2.4.0
labels
Aug 18, 2022
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
poc/pre-filtering-for-lucene-engine
branch
from
August 18, 2022 21:21
f3ac136
to
5b0bb27
Compare
martin-gaievski
changed the base branch from
main
to
feature/efficient-filtering
August 18, 2022 21:24
jmazanec15
reviewed
Aug 18, 2022
src/main/java/org/opensearch/knn/index/query/KNNQueryFactory.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Martin Gaievski <[email protected]>
Codecov Report
@@ Coverage Diff @@
## feature/efficient-filtering #515 +/- ##
==============================================================
Coverage 84.04% 84.05%
- Complexity 1019 1022 +3
==============================================================
Files 146 146
Lines 4188 4240 +52
Branches 373 376 +3
==============================================================
+ Hits 3520 3564 +44
- Misses 492 500 +8
Partials 176 176
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jmazanec15
approved these changes
Aug 19, 2022
martin-gaievski
merged commit Aug 22, 2022
86cec30
into
opensearch-project:feature/efficient-filtering
martin-gaievski
added a commit
to martin-gaievski/k-NN
that referenced
this pull request
Oct 14, 2022
* Add initial support for filtering Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
added a commit
that referenced
this pull request
Oct 14, 2022
* Add initial support for filtering Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
added a commit
to martin-gaievski/k-NN
that referenced
this pull request
Oct 20, 2022
* Add initial support for filtering Signed-off-by: Martin Gaievski <[email protected]>
1 task
heemin32
added
v2.4.0
'Issues and PRs related to version v2.4.0'
and removed
2.4.0
labels
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancements
Increases software capabilities beyond original client specifications
v2.4.0
'Issues and PRs related to version v2.4.0'
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding code from POC branch to a feature branch in main repo.
This implementation is not production ready, code isn't polished and mainly most of tests are missing expect for the very basic unit test.
In this change we:
Issues Resolved
#376
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Dexveloper Certificate of Origin and signing off your commits, please check here.