Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 1.x] remove hardcoded URL #340

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b276aa3 from #338

Signed-off-by: Naveen Tatikonda <[email protected]>
(cherry picked from commit b276aa3)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team March 30, 2022 15:52
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #340 (b276aa3) into 1.x (a1a14ba) will increase coverage by 0.57%.
The diff coverage is 81.83%.

❗ Current head b276aa3 differs from pull request most recent head a843761. Consider uploading reports for the commit a843761 to get more accurate results

@@             Coverage Diff              @@
##                1.x     #340      +/-   ##
============================================
+ Coverage     83.41%   83.99%   +0.57%     
- Complexity      889      900      +11     
============================================
  Files           127      130       +3     
  Lines          3841     3854      +13     
  Branches        361      353       -8     
============================================
+ Hits           3204     3237      +33     
+ Misses          475      457      -18     
+ Partials        162      160       -2     
Impacted Files Coverage Δ
...n/java/org/opensearch/knn/common/KNNConstants.java 92.30% <ø> (ø)
.../main/java/org/opensearch/knn/index/KNNScorer.java 69.23% <0.00%> (+4.94%) ⬆️
.../opensearch/knn/index/KNNVectorIndexFieldData.java 100.00% <ø> (ø)
...opensearch/knn/index/KNNVectorScriptDocValues.java 90.47% <ø> (ø)
...n/index/codec/KNN80Codec/KNN80BinaryDocValues.java 100.00% <ø> (+28.57%) ⬆️
...nsearch/knn/index/codec/KNN80Codec/KNN80Codec.java 30.00% <0.00%> (ø)
...n/index/codec/KNN80Codec/KNN80DocValuesReader.java 75.00% <ø> (ø)
...earch/knn/index/codec/util/BinaryDocValuesSub.java 71.42% <ø> (ø)
...rch/knn/index/memory/NativeMemoryEntryContext.java 100.00% <ø> (ø)
...main/java/org/opensearch/knn/jni/FaissService.java 85.71% <ø> (ø)
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a14ba...a843761. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants