Skip to content

Commit

Permalink
remove hardcoded URL (#338)
Browse files Browse the repository at this point in the history
Signed-off-by: Naveen Tatikonda <[email protected]>
  • Loading branch information
naveentatikonda authored Mar 30, 2022
1 parent bebf9a6 commit b276aa3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions build-tools/knnplugin-coverage.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ task dummyIntegTest(type: Test) {

integTest {
systemProperty 'jacoco.dir', "${jacocoDir}"
systemProperty 'jmx.serviceUrl', "service:jmx:rmi:///jndi/rmi://127.0.0.1:7777/jmxrmi"
}

jacocoTestReport {
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/org/opensearch/knn/KNNRestTestCase.java
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public static void dumpCoverage() throws IOException, MalformedObjectNameExcepti
return;
}

String serverUrl = "service:jmx:rmi:///jndi/rmi://127.0.0.1:7777/jmxrmi";
String serverUrl = System.getProperty("jmx.serviceUrl");
try (JMXConnector connector = JMXConnectorFactory.connect(new JMXServiceURL(serverUrl))) {
IProxy proxy = MBeanServerInvocationHandler.newProxyInstance(
connector.getMBeanServerConnection(),
Expand Down

0 comments on commit b276aa3

Please sign in to comment.