remove hardcoded URL #338
Merged
remove hardcoded URL #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #338 +/- ##
=========================================
Coverage 83.99% 83.99%
Complexity 900 900
=========================================
Files 130 130
Lines 3854 3854
Branches 353 353
=========================================
Hits 3237 3237
Misses 457 457
Partials 160 160 Continue to review full report at Codecov.
|
Signed-off-by: Naveen Tatikonda <[email protected]>
naveentatikonda
force-pushed
the
fix_hardcoded_url
branch
from
a721fb4 to
b04372f
Compare
junqiu-lei
approved these changes
Mar 30, 2022
|
Btw, do you want to add a backport 1.x label? |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 30, 2022
Signed-off-by: Naveen Tatikonda <[email protected]> (cherry picked from commit b276aa3)
naveentatikonda
added
the
Refactoring
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 30, 2022
Signed-off-by: Naveen Tatikonda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naveen Tatikonda [email protected]
Description
According to security recommendation and as per the best coding practice, removing hardcoded URL in tests.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.