Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query string query to rollups #2405

Closed
wants to merge 14 commits into from
Closed

Conversation

Naarcha-AWS
Copy link
Collaborator

Signed-off-by: Naarcha-AWS [email protected]

Closes #2341

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Naarcha-AWS Naarcha-AWS added 3 - Tech review PR: Tech review in progress v2.5.0 'Issues and PRs related to version v2.5.0' labels Jan 13, 2023
@Naarcha-AWS Naarcha-AWS requested a review from a team as a code owner January 13, 2023 18:21
@hdhalter hdhalter added the release-notes PR: Include this PR in the automated release notes label Jan 13, 2023
carolxob and others added 2 commits January 13, 2023 13:52
* Adding Core API doc to doc website repo.

Signed-off-by: carolxob <[email protected]>

* Made edits based on doc review feedback.

Signed-off-by: carolxob <[email protected]>

* Update _data-prepper/core-apis.md

Co-authored-by: Alice Williams <[email protected]>

* Minor edits based on doc review feedback.

Signed-off-by: carolxob <[email protected]>

* Pushing first set of updates because last ones did not commit.

Signed-off-by: carolxob <[email protected]>

* Made more changes as part of editorial review.

Signed-off-by: carolxob <[email protected]>

* Added more editorial feedback edits.

Signed-off-by: carolxob <[email protected]>

* Pushing more editorial feedback changes.

Signed-off-by: carolxob <[email protected]>

* Added more editorial feedback changes.

Signed-off-by: carolxob <[email protected]>

* Added more editorial feedback.

Signed-off-by: carolxob <[email protected]>

* Made slight changes.

Signed-off-by: carolxob <[email protected]>

* Picked up a few more changes from editorial.

Signed-off-by: carolxob <[email protected]>

* Incorporated doc review feedback. Needs a couple of tech questions addressed.

Signed-off-by: carolxob <[email protected]>

* Minor changes.

Signed-off-by: carolxob <[email protected]>

* Minor edits.

Signed-off-by: carolxob <[email protected]>

* Minor edits made from editorial feedback.

Signed-off-by: carolxob <[email protected]>

* Minor capitalization update.

Signed-off-by: carolxob <[email protected]>

* Update _data-prepper/core-apis.md

* Update _data-prepper/core-apis.md

Co-authored-by: Nate Bower <[email protected]>

* Made changes based on editorial feedback.

Signed-off-by: carolxob <[email protected]>

Signed-off-by: carolxob <[email protected]>
Co-authored-by: Alice Williams <[email protected]>
Co-authored-by: Nate Bower <[email protected]>
* Add Logs to doc website repo.

Signed-off-by: carolxob <[email protected]>

* Minor copy edits, added one heading.

Signed-off-by: carolxob <[email protected]>

* Update _data-prepper/logs.md

Co-authored-by: Naarcha-AWS <[email protected]>

* Minor heading changes.

Signed-off-by: carolxob <[email protected]>

* Incorporated doc review edits.

Signed-off-by: carolxob <[email protected]>

* Incorporated technical feedback.

Signed-off-by: carolxob <[email protected]>

* Minor technical feedback incorporated.

Signed-off-by: carolxob <[email protected]>

* Minor phrasing change.

Signed-off-by: carolxob <[email protected]>

* Added comments for editorial.

Signed-off-by: carolxob <[email protected]>

* Incorporated editorial feedkback changes.

Signed-off-by: carolxob <[email protected]>

Signed-off-by: carolxob <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
cwillum and others added 3 commits January 13, 2023 17:24
* fix#2400-yaml-editor-rules

Signed-off-by: cwillum <[email protected]>

* fix#2400-yaml-editor-rules

Signed-off-by: cwillum <[email protected]>

* fix#2400-yaml-editor-rules

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
Updates the 2.4 release notes to remove content that was pulled and to remove the note.
* Adds documentation for Admin UI index operations

Signed-off-by: ariamarble <[email protected]>

* tech review and format changes

Signed-off-by: ariamarble <[email protected]>

* Update _dashboards/admin-ui-index/index-management.md

Co-authored-by: kolchfa-aws <[email protected]>

* Update _dashboards/admin-ui-index/index-management.md

Co-authored-by: kolchfa-aws <[email protected]>

* Update _dashboards/admin-ui-index/index-management.md

Co-authored-by: kolchfa-aws <[email protected]>

* Update _dashboards/admin-ui-index/index-management.md

Co-authored-by: kolchfa-aws <[email protected]>

* Update _dashboards/admin-ui-index/index-management.md

Co-authored-by: kolchfa-aws <[email protected]>

* Update _dashboards/admin-ui-index/index-management.md

Co-authored-by: kolchfa-aws <[email protected]>

* Update _dashboards/admin-ui-index/index-management.md

Co-authored-by: kolchfa-aws <[email protected]>

* Update _dashboards/admin-ui-index/index-management.md

Co-authored-by: kolchfa-aws <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>

* initial doc review changes

Signed-off-by: ariamarble <[email protected]>

* further doc review changes

Signed-off-by: ariamarble <[email protected]>

* consolidate snapshots

Signed-off-by: ariamarble <[email protected]>

* Doc Review 2 Electric Boogaloo

Signed-off-by: ariamarble <[email protected]>

Signed-off-by: ariamarble <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
@@ -9,7 +9,7 @@ has_toc: false

# Index rollups

Time series data increases storage costs, strains cluster health, and slows down aggregations over time. Index rollup lets you periodically reduce data granularity by rolling up old data into summarized indices.
Time series data increases storage costs, strains cluster health, and slows down aggregations over time. Index rollup lets you periodically reduce data granularity by rolling up old data into summarized indexes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to break out the indexes vs indices update in a different PR so we can backport it to earlier versions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I'll switch it back


When data is rolled up into multiple target indices, you can run one search across all of the rollup indices. To search multiple target indices that have the same rollup, specify the index names as a comma-separated list or a wildcard pattern. For example, with `target_index` as <span style="white-space: nowrap">`{% raw %}rollup_ndx-{{ctx.source_index}}{% endraw %}`</span> and source indices that start with `log`, specify the `rollup_ndx-log*` pattern. Or, to search for rolled up log-000001 and log-000002 indices, specify the `rollup_ndx-log-000001,rollup_ndx-log-000002` list.
To take advantage of shorter and easier to write strings in Query DSL, you can use [query strings]({{site.url}}{{site.baseurl}}/opensearch/query-dsl/full-text/#query-string) to simplify search queries in rollup indexes. To use query strings, add the following fields to your rollup search request.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we have a full example here with the HTTP method and concrete field names and field values?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding that now.

}
```

For more information on what fields are supported in query strings, see [Advanced filter options]({{site.url}}{{site.baseurl}}/opensearch/query-dsl/full-text/#advanced-filter-options/).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we don't yet have a doc page for query_string query. And the parameter list in Advanced filter options is not 1:1. For example, query_string query does not support low_freq_operator. I don't know what the best way of dealing with this is: probably prioritize query_string query documentation and then link it here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and add it since I have a couple more days. For now, we could add a warning.

kolchfa-aws and others added 8 commits January 17, 2023 12:08
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
* for new page how to analyze Jaeger trace data

Signed-off-by: alicejw <[email protected]>

* remove old image

Signed-off-by: alicejw <[email protected]>

* for new information and doc writer checklist

Signed-off-by: alicejw <[email protected]>

* for new information and doc writer checklist

Signed-off-by: alicejw <[email protected]>

* small rewrite

Signed-off-by: alicejw <[email protected]>

* new clean images from Dashboards URL directly

Signed-off-by: alicejw <[email protected]>

* for additional information

Signed-off-by: alicejw <[email protected]>

* remove blank lines

Signed-off-by: alicejw <[email protected]>

* for tech review feedback updates

Signed-off-by: alicejw <[email protected]>

* add requirements section

Signed-off-by: alicejw <[email protected]>

* for new procedure

Signed-off-by: alicejw <[email protected]>

* for tech review feedback updates

Signed-off-by: alicejw <[email protected]>

* continued updates

Signed-off-by: alicejw <[email protected]>

* for docker compose file instructions

Signed-off-by: alicejw <[email protected]>

* for docker usage instruction

Signed-off-by: alicejw <[email protected]>

* for step 2 view dashboards

Signed-off-by: alicejw <[email protected]>

* for additional link provided in tech review

Signed-off-by: alicejw <[email protected]>

* for link to index page to introduce the feature

Signed-off-by: alicejw <[email protected]>

* final checklist

Signed-off-by: alicejw <[email protected]>

* add warning not to use sample file in prod env

Signed-off-by: alicejw <[email protected]>

* updated docker file that is safe for prod env, remove warning note for previous file

Signed-off-by: alicejw <[email protected]>

* for small update to parent page

Signed-off-by: alicejw <[email protected]>

* for tech review

Signed-off-by: alicejw <[email protected]>

* typo fix for font

Signed-off-by: alicejw <[email protected]>

* for doc review #1 feedback updates

Signed-off-by: alicejw <[email protected]>

* for doc review feedback #2 updates

Signed-off-by: alicejw <[email protected]>

* for a couple minor changes

Signed-off-by: alicejw <[email protected]>

* spell out dashboard URI directly to trace analytics for accessibility. With URL obfuscated, this would not get spelled out in the vision-impaired app that scans through.it would simply read the title only

Signed-off-by: alicejw <[email protected]>

* need to add additional step from eng to generate sample data

Signed-off-by: alicejw <[email protected]>

* for additional step image of sample app

Signed-off-by: alicejw <[email protected]>

* rename step numbers

Signed-off-by: alicejw <[email protected]>

* minor fix heading levels

Signed-off-by: alicejw <[email protected]>

* updates recommended by the editorial reviewer

Signed-off-by: alicejw <[email protected]>

* clarify Spans window function

Signed-off-by: alicejw <[email protected]>

* clarified individual trace details section

Signed-off-by: alicejw <[email protected]>

Signed-off-by: alicejw <[email protected]>
* Adds maps documentation

Signed-off-by: Fanit Kolchina <[email protected]>

* Rewrites

Signed-off-by: Fanit Kolchina <[email protected]>

* Changed entry point for maps

Signed-off-by: Fanit Kolchina <[email protected]>

* Incorporated tech review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* More tech review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Adds steps to install sample data

Signed-off-by: Fanit Kolchina <[email protected]>

* Minor edit

Signed-off-by: Fanit Kolchina <[email protected]>

* Incorporated doc review comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Incorporated editorial comments

Signed-off-by: Fanit Kolchina <[email protected]>

* Updated the add layer dialog

Signed-off-by: Fanit Kolchina <[email protected]>

* Simplified adding sample dataset

Signed-off-by: Fanit Kolchina <[email protected]>

* Minor change

Signed-off-by: Fanit Kolchina <[email protected]>

* Added new images

Signed-off-by: Fanit Kolchina <[email protected]>

Signed-off-by: Fanit Kolchina <[email protected]>
* fix#2400-revisions-to-current

Signed-off-by: cwillum <[email protected]>

* fix#2400-SecAnalytics-updates

Signed-off-by: cwillum <[email protected]>

* fix#2400-SecAnalytics-updates

Signed-off-by: cwillum <[email protected]>

* fix#2400-SecAnalytics-updates

Signed-off-by: cwillum <[email protected]>

* fix#2400-SecAnalytics-updates

Signed-off-by: cwillum <[email protected]>

Signed-off-by: cwillum <[email protected]>
@kolchfa-aws kolchfa-aws deleted the query-string-query branch January 19, 2023 13:56
@kolchfa-aws kolchfa-aws restored the query-string-query branch January 19, 2023 15:58
@Naarcha-AWS Naarcha-AWS deleted the query-string-query branch March 28, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Tech review PR: Tech review in progress release-notes PR: Include this PR in the automated release notes v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Query String Query support in Rollups
7 participants