Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Jaeger trace data for analytics documentation #2374

Merged
merged 35 commits into from
Jan 17, 2023

Conversation

alicejw1
Copy link
Contributor

@alicejw1 alicejw1 commented Jan 11, 2023

Signed-off-by: alicejw [email protected]

Description

New doc for how to use Jaeger trace data for analytics.

Issues Resolved

#2313

PDF for reviewers

To see the document as it will be rendered on the site, take a look at this PDF.

Analyze Jaeger trace data - OpenSearch documentation.pdf

Checklist

  • [ x] By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@alicejw1 alicejw1 self-assigned this Jan 11, 2023
@alicejw1 alicejw1 linked an issue Jan 11, 2023 that may be closed by this pull request
4 tasks
@alicejw1 alicejw1 marked this pull request as ready for review January 11, 2023 18:53
@alicejw1 alicejw1 requested a review from a team as a code owner January 11, 2023 18:53
@alicejw1 alicejw1 added the 3 - Tech review PR: Tech review in progress label Jan 11, 2023
@alicejw1 alicejw1 added this to the v2.5.x milestone Jan 11, 2023
@alicejw1 alicejw1 requested review from derek-ho and anirudha January 11, 2023 20:24
@alicejw1
Copy link
Contributor Author

Hi @derek-ho thanks for your review! I've updated it. Could you verify and provide tech review approval?
@anirudha , could you also please take a look and provide feedback/approval today?
We'd like to get this into the 2.5 release if possible.

Signed-off-by: alicejw <[email protected]>
@nitincd
Copy link
Contributor

nitincd commented Jan 11, 2023

would suggest updating the first section to:

The Trace analytics functionality in OpenSearch Observability plugin now supports Jaeger trace data. Users that use OpenSearch as the backend for their Jaeger trace data can now benefit from the analysis capabilities built into OpenSearch Trace analytics. This adds to the existing support for OTEL formatted trace data.

When you use trace analytics, you can now select from two data sources:
Data Prepper – Data ingested into OpenSearch through Data Prepper. This data source corresponds to the trace data in OpenTelemetry (OTEL) format.
Jaeger – Trace data from Jaeger stored within OpenSearch. This data source corresponds to the Jaeger format.

If you currently store your Jaeger trace data in OpenSearch, you can now use the capabilities built into Trace analytics to analyze the error rates and latencies. You can also filter the traces and look into the span details of a trace to pinpoint any service issues.

@nitincd
Copy link
Contributor

nitincd commented Jan 11, 2023

would suggest updating the first section to:

The Trace analytics functionality in OpenSearch Observability plugin now supports Jaeger trace data. Users that use OpenSearch as the backend for their Jaeger trace data can now benefit from the analysis capabilities built into OpenSearch Trace analytics. This adds to the existing support for OTEL formatted trace data.

When you use trace analytics, you can now select from two data sources:
Data Prepper – Data ingested into OpenSearch through Data Prepper. This data source corresponds to the trace data in OpenTelemetry (OTEL) format.
Jaeger – Trace data from Jaeger stored within OpenSearch. This data source corresponds to the Jaeger format.

If you currently store your Jaeger trace data in OpenSearch, you can now use the capabilities built into Trace analytics to analyze the error rates and latencies. You can also filter the traces and look into the span details of a trace to pinpoint any service issues.

@alicejw1
Copy link
Contributor Author

alicejw1 commented Jan 11, 2023

Tech review comments are now incorporated. (except need one more command from @derek-ho )
Please also see updated PDF:
Analyze Jaeger trace data - OpenSearch documentation.pdf

Thanks

Signed-off-by: alicejw <[email protected]>
Signed-off-by: alicejw <[email protected]>
Signed-off-by: alicejw <[email protected]>
@alicejw1
Copy link
Contributor Author

Updated PDFs after final clarification meeting and small updates.
Analyze Jaeger trace data - OpenSearch documentation.pdf

Trace analytics-overview.pdf

Copy link
Contributor

@vagimeli vagimeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alicejw-aws Made some comments and suggestions. Good work!

_observability-plugin/trace/index.md Outdated Show resolved Hide resolved
_observability-plugin/trace/index.md Outdated Show resolved Hide resolved
_observability-plugin/trace/index.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alicejw-aws , can you please update the name of the PR to match our naming standards? This will appear in the release notes and should follow a similar convention. Thanks!

@alicejw1 alicejw1 changed the title Create new doc - How to use Jaeger trace data for analytics Adds Jaeger trace data for analytics documentation Jan 12, 2023
Copy link
Collaborator

@Naarcha-AWS Naarcha-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natebower can verify, but I believe that "Trace Analytics" should be lowercased in most instances.

Otherwise, looks good to me.

_observability-plugin/trace/index.md Outdated Show resolved Hide resolved
_observability-plugin/trace/index.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
…. With URL obfuscated, this would not get spelled out in the vision-impaired app that scans through.it would simply read the title only

Signed-off-by: alicejw <[email protected]>
@alicejw1
Copy link
Contributor Author

Doc review updates completed. Sending for editorial review.
Updated PDF:
Analyze Jaeger trace data - OpenSearch documentation.pdf

@alicejw1 alicejw1 added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Jan 12, 2023
@alicejw1
Copy link
Contributor Author

Updated PDF after adding additional step from eng.
Analyze Jaeger trace data - OpenSearch documentation.pdf

Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alicejw-aws Please see my comments and changes and let me know if you have any questions. Thanks!

_observability-plugin/trace/index.md Outdated Show resolved Hide resolved
_observability-plugin/trace/index.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
_observability-plugin/trace/trace-analytics-jaeger.md Outdated Show resolved Hide resolved
@hdhalter hdhalter added v2.5.0 'Issues and PRs related to version v2.5.0' release-notes PR: Include this PR in the automated release notes labels Jan 13, 2023
@alicejw1 alicejw1 merged commit 7ac74ec into opensearch-project:main Jan 17, 2023
@alicejw1 alicejw1 removed the 5 - Editorial review PR: Editorial review in progress label Jan 19, 2023
vagimeli pushed a commit that referenced this pull request Jan 25, 2023
* for new page how to analyze Jaeger trace data

Signed-off-by: alicejw <[email protected]>

* remove old image

Signed-off-by: alicejw <[email protected]>

* for new information and doc writer checklist

Signed-off-by: alicejw <[email protected]>

* for new information and doc writer checklist

Signed-off-by: alicejw <[email protected]>

* small rewrite

Signed-off-by: alicejw <[email protected]>

* new clean images from Dashboards URL directly

Signed-off-by: alicejw <[email protected]>

* for additional information

Signed-off-by: alicejw <[email protected]>

* remove blank lines

Signed-off-by: alicejw <[email protected]>

* for tech review feedback updates

Signed-off-by: alicejw <[email protected]>

* add requirements section

Signed-off-by: alicejw <[email protected]>

* for new procedure

Signed-off-by: alicejw <[email protected]>

* for tech review feedback updates

Signed-off-by: alicejw <[email protected]>

* continued updates

Signed-off-by: alicejw <[email protected]>

* for docker compose file instructions

Signed-off-by: alicejw <[email protected]>

* for docker usage instruction

Signed-off-by: alicejw <[email protected]>

* for step 2 view dashboards

Signed-off-by: alicejw <[email protected]>

* for additional link provided in tech review

Signed-off-by: alicejw <[email protected]>

* for link to index page to introduce the feature

Signed-off-by: alicejw <[email protected]>

* final checklist

Signed-off-by: alicejw <[email protected]>

* add warning not to use sample file in prod env

Signed-off-by: alicejw <[email protected]>

* updated docker file that is safe for prod env, remove warning note for previous file

Signed-off-by: alicejw <[email protected]>

* for small update to parent page

Signed-off-by: alicejw <[email protected]>

* for tech review

Signed-off-by: alicejw <[email protected]>

* typo fix for font

Signed-off-by: alicejw <[email protected]>

* for doc review #1 feedback updates

Signed-off-by: alicejw <[email protected]>

* for doc review feedback #2 updates

Signed-off-by: alicejw <[email protected]>

* for a couple minor changes

Signed-off-by: alicejw <[email protected]>

* spell out dashboard URI directly to trace analytics for accessibility. With URL obfuscated, this would not get spelled out in the vision-impaired app that scans through.it would simply read the title only

Signed-off-by: alicejw <[email protected]>

* need to add additional step from eng to generate sample data

Signed-off-by: alicejw <[email protected]>

* for additional step image of sample app

Signed-off-by: alicejw <[email protected]>

* rename step numbers

Signed-off-by: alicejw <[email protected]>

* minor fix heading levels

Signed-off-by: alicejw <[email protected]>

* updates recommended by the editorial reviewer

Signed-off-by: alicejw <[email protected]>

* clarify Spans window function

Signed-off-by: alicejw <[email protected]>

* clarified individual trace details section

Signed-off-by: alicejw <[email protected]>

Signed-off-by: alicejw <[email protected]>
vagimeli added a commit that referenced this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes PR: Include this PR in the automated release notes v2.5.0 'Issues and PRs related to version v2.5.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Add Jaeger Usage Docs
8 participants