-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Core APIs to doc website repo. #1932
Conversation
Signed-off-by: carolxob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
made a few minor format suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other that Alice's changes
Signed-off-by: carolxob <[email protected]>
Co-authored-by: Alice Williams <[email protected]>
Signed-off-by: carolxob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carolxob Please see my comments and changes and let me know if you have any questions. Thanks!
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Signed-off-by: carolxob <[email protected]>
Co-authored-by: Nate Bower <[email protected]>
Signed-off-by: carolxob <[email protected]>
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0)
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0)
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0)
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0)
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0)
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0)
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0) Co-authored-by: Caroline <[email protected]>
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0) Co-authored-by: Caroline <[email protected]>
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0) Co-authored-by: Caroline <[email protected]>
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0) Co-authored-by: Caroline <[email protected]>
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0) Co-authored-by: Caroline <[email protected]>
* Adding Core API doc to doc website repo. Signed-off-by: carolxob <[email protected]> * Made edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md Co-authored-by: Alice Williams <[email protected]> * Minor edits based on doc review feedback. Signed-off-by: carolxob <[email protected]> * Pushing first set of updates because last ones did not commit. Signed-off-by: carolxob <[email protected]> * Made more changes as part of editorial review. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback edits. Signed-off-by: carolxob <[email protected]> * Pushing more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback changes. Signed-off-by: carolxob <[email protected]> * Added more editorial feedback. Signed-off-by: carolxob <[email protected]> * Made slight changes. Signed-off-by: carolxob <[email protected]> * Picked up a few more changes from editorial. Signed-off-by: carolxob <[email protected]> * Incorporated doc review feedback. Needs a couple of tech questions addressed. Signed-off-by: carolxob <[email protected]> * Minor changes. Signed-off-by: carolxob <[email protected]> * Minor edits. Signed-off-by: carolxob <[email protected]> * Minor edits made from editorial feedback. Signed-off-by: carolxob <[email protected]> * Minor capitalization update. Signed-off-by: carolxob <[email protected]> * Update _data-prepper/core-apis.md * Update _data-prepper/core-apis.md Co-authored-by: Nate Bower <[email protected]> * Made changes based on editorial feedback. Signed-off-by: carolxob <[email protected]> Signed-off-by: carolxob <[email protected]> Co-authored-by: Alice Williams <[email protected]> Co-authored-by: Nate Bower <[email protected]> (cherry picked from commit 96cfdf0) Co-authored-by: Caroline <[email protected]>
Signed-off-by: carolxob [email protected]
Description
Add Core API doc to doc website repo.
Issues Addressed
Addresses #1267
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.