Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for aggregate view of saved objects by tenant in Dashboards #1786

Merged
merged 22 commits into from
Nov 10, 2022

Conversation

cwillum
Copy link
Contributor

@cwillum cwillum commented Nov 2, 2022

Signed-off-by: cwillum [email protected]

Description

Added to documentation for a new feature that provides an aggregate view of saved objects across tenants in Dashboards.

Issues Resolved

Broke out Multi-tenancy into its own subheading in the security plugin documentation and added content for the new experimental aggregate view of saved objects feature.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwillum cwillum added enhancement New feature or request 2 - In progress Issue/PR: The issue or PR is in progress. security v2.4.0 'Issues and PRs related to version v2.4.0' labels Nov 2, 2022
@cwillum cwillum requested a review from a team as a code owner November 2, 2022 03:00
@cwillum cwillum self-assigned this Nov 2, 2022
@cwillum cwillum marked this pull request as draft November 2, 2022 03:00
@cwillum
Copy link
Contributor Author

cwillum commented Nov 3, 2022

Some bugs were found in UI for this feature. Security is working on it. I've halted work on this documentation until those issues are resolved.

@cwillum cwillum removed the 2 - In progress Issue/PR: The issue or PR is in progress. label Nov 3, 2022
@cwillum cwillum added 2 - In progress Issue/PR: The issue or PR is in progress. 3 - Tech review PR: Tech review in progress labels Nov 8, 2022
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwillum Please see my comments and changes and let me know if you have any questions. Thanks!

_security-plugin/multi-tenancy/mt-agg-view.md Show resolved Hide resolved
nav_order: 60
---

# Dashboards multi-tenancy aggregate view for saved objects
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Dashboards multi-tenancy aggregate view for saved objects
# OpenSearch Dashboards multi-tenancy aggregate view for saved objects

_security-plugin/multi-tenancy/mt-agg-view.md Outdated Show resolved Hide resolved
_security-plugin/multi-tenancy/mt-agg-view.md Outdated Show resolved Hide resolved
_security-plugin/multi-tenancy/mt-agg-view.md Outdated Show resolved Hide resolved
_security-plugin/multi-tenancy/mt-agg-view.md Show resolved Hide resolved
_security-plugin/multi-tenancy/mt-agg-view.md Outdated Show resolved Hide resolved
_security-plugin/multi-tenancy/mt-agg-view.md Outdated Show resolved Hide resolved
_security-plugin/multi-tenancy/mt-agg-view.md Outdated Show resolved Hide resolved
_security-plugin/multi-tenancy/mt-agg-view.md Outdated Show resolved Hide resolved
@cwillum cwillum removed 2 - In progress Issue/PR: The issue or PR is in progress. 3 - Tech review PR: Tech review in progress labels Nov 9, 2022
@cwperks
Copy link
Member

cwperks commented Nov 9, 2022

@cwillum The numbers on Aggregate_view_saved_objects.png and Vis_tenant.png look off to me. Were these screenshots taken with the RC build for 2.4.0?

Copy link
Contributor

@alicejw1 alicejw1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

Copy link
Contributor

@ariamarble ariamarble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the changes suggested by others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security v2.4.0 'Issues and PRs related to version v2.4.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants