-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update URLs referencing old docs-beta site #1231
Update URLs referencing old docs-beta site #1231
Conversation
Signed-off-by: Craig Perkins <[email protected]>
If this change gets backported then URLs need to be updated to their version specific locations which may not be guaranteed to be accurate. Can this be backported while keeping |
Signed-off-by: Craig Perkins <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1231 +/- ##
=======================================
Coverage 71.78% 71.78%
=======================================
Files 88 88
Lines 2027 2027
Branches 269 274 +5
=======================================
Hits 1455 1455
Misses 509 509
Partials 63 63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@shanilpa Could you take a look at these changes to confirm they are pointed where you'd like to see? |
@cwperks Everything looks good, but there are a couple that are pointing to the wrong place. Here are some screenshots to help and links to where I think they should go. Happy to discuss further if needed. 01 and 02: Link to Attribute based security. I think it should link to the access control page so they can get clarity on the concept and see if they would like to leverage it. Ideally we should have a link on that page from each concept to the part of the docs site that enables them to achieve this concept. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cwperks It looks like we might have to add in a new constant for an external link too: https://opensearch.org/docs/latest/security-plugin/access-control/index/
There are a couple of learn more links that reference the wrong constant therefore linking to the wrong pages.
For more context you can refer to this comment in the PR or reach out and we can chat through it.
Signed-off-by: Craig Perkins <[email protected]>
@shanilpa The links have now been updated to point to https://opensearch.org/docs/latest/security-plugin/access-control/index/ for the Learn More links next to Backend Roles. |
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit e15b6fc)
Description
Replaced URLs starting with
https://docs-beta.opensearch.org/docs/security
to start withhttps://opensearch.org/docs/latest/security-plugin
and updates link to multi-tenancy documentation renamed in this PR: opensearch-project/documentation-website#1786Category
[Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation]
Bug fix
Issues Resolved
#1174
Testing
Updated snapshots with old URLs
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.