Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update multi-tenancy route to match name change #2064

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Nov 28, 2022

Signed-off-by: Craig Perkins [email protected]

Description

The route to multi-tenancy config was renamed in this PR #1786 and broke existing links elsewhere in the documentation. This PR updates the existing links to account for the name change.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@cwperks cwperks requested a review from a team as a code owner November 28, 2022 22:11
@cwperks
Copy link
Member Author

cwperks commented Nov 28, 2022

@cwillum This PR updates broken links to multi-tenancy documentation.

Signed-off-by: Craig Perkins <[email protected]>
@cwillum cwillum self-assigned this Nov 29, 2022
@cwillum cwillum added 4 - Doc review PR: Doc review in progress backport 2.4 PR: Backport label for 2.4 labels Nov 29, 2022
_security-plugin/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these links locally and they all check out. But we should probably be pointing users to the multi-tenancy index page.

@cwperks These are all appropriate edits. They slipped by me. Thanks. But see comments here.

Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Copy link
Member Author

cwperks commented Nov 29, 2022

@cwperks All links are updated to point to the multi-tenancy index now.

Copy link
Contributor

@cwillum cwillum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cwillum cwillum merged commit cb3153d into opensearch-project:main Nov 29, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 29, 2022
* Update multi-tenancy route to match name change

Signed-off-by: Craig Perkins <[email protected]>

* Add slash at end of route

Signed-off-by: Craig Perkins <[email protected]>

* Link to multi-tenancy index

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit cb3153d)
cwillum pushed a commit that referenced this pull request Nov 29, 2022
* Update multi-tenancy route to match name change

Signed-off-by: Craig Perkins <[email protected]>

* Add slash at end of route

Signed-off-by: Craig Perkins <[email protected]>

* Link to multi-tenancy index

Signed-off-by: Craig Perkins <[email protected]>

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit cb3153d)

Co-authored-by: Craig Perkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress backport 2.4 PR: Backport label for 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants