Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Refactor Cypress workflow #1299

Merged
merged 5 commits into from
Dec 15, 2023

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Dec 14, 2023

Description

  • Refactor Cypress workflow + an assertion fix for integrations.spec.js.
  • Enabled Cypress workflow <-- this will be forwardported into main

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ffb580) 56.42% compared to head (3d161c9) 56.42%.

Additional details and impacted files
@@           Coverage Diff            @@
##              2.x    #1299    +/-   ##
========================================
  Coverage   56.42%   56.42%            
========================================
  Files         327      327            
  Lines       11930    11930            
  Branches     2799     2740    -59     
========================================
  Hits         6732     6732            
- Misses       4895     5153   +258     
+ Partials      303       45   -258     
Flag Coverage Δ
dashboards-observability 56.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997
Copy link
Collaborator Author

RyanL1997 commented Dec 14, 2023

Hi team, I made some changes in this PR and I will forwardport it into main too:

  • Change the OSD checking step by using streaming instead of looping (Thanks to @joshuali925's comment)
  • Add dynamic naming for each parallel job.
  • Enabled this workflow on PR
  • Remove a duplicate group of notebooks_test

Btw one more thing I observed is that, the integrations.spec.js is failing on 2.x but not on the main.

cc: @ps48, @mengweieric, @Swiddis

@ps48 ps48 merged commit 11ecfa6 into opensearch-project:2.x Dec 15, 2023
8 of 16 checks passed
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…ect#1299)

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit bea778f73b76cb5bd4e17d25f994409590c4fac9)
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
* [CI/CD] Refactor Cypress workflow

Signed-off-by: Ryan Liang <[email protected]>

* Remove duplicate group

Signed-off-by: Ryan Liang <[email protected]>

* Enable cypress workflow

Signed-off-by: Ryan Liang <[email protected]>

* Rename the title of each job

Signed-off-by: Ryan Liang <[email protected]>

* Correct the path to event analytics test

Signed-off-by: Ryan Liang <[email protected]>

---------

Signed-off-by: Ryan Liang <[email protected]>
(cherry picked from commit 11ecfa6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants