-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/CD] Refactor Cypress Workflow #1290
[CI/CD] Refactor Cypress Workflow #1290
Conversation
…tion GH workflow Signed-off-by: Ryan Liang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
========================================
Coverage 56.32% 56.32%
========================================
Files 327 327
Lines 11944 11944
Branches 2741 2800 +59
========================================
Hits 6728 6728
+ Misses 5171 4913 -258
- Partials 45 303 +258
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Liang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Ryan Liang <[email protected]>
Transferring some of the conversation between me and @ps48 here: this PR will also refactor the current workflow structure and separate the test cases into parallel runs. |
Signed-off-by: Ryan Liang <[email protected]>
6bf5a45
to
da6c27d
Compare
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
The refactor has been done. The test cases have been separated into its own GH runner. We have also setup the directory for future splitting of the test classes. The sample run is here: https://github.com/RyanL1997/dashboards-observability/actions/runs/7145888298/job/19462486749 Could you plz review it again? If nothing surface up, lets merge this so that we can start fixing the failing test cases in the above log. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix.
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
…search-project#1291) Signed-off-by: Mohammad Qureshi <[email protected]> (cherry picked from commit 180f69458a9ebc9c1d3d8661b66326318f98b800)
Description
The current state is that the workflow of Dashboards observability plugin E2E test is able to be run and the the cypress framework can work properly (see log here: https://github.com/RyanL1997/dashboards-observability/actions/runs/7145888298/job/19462486749). However, the test cases is still failing, and it should be resolved in the follow up PR for #1040.
Issues Resolved
9_integrations
#1039Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.