Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Refactor Cypress Workflow #1290

Merged
merged 13 commits into from
Dec 11, 2023

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Dec 7, 2023

Description

  • Fix the integration test case in the Cypress integration suite
  • Add a dashboard status check in the integration CI workflow
  • Separate cypress test suites into its own GH runner
  • Setup cypress tests directories for different testing categories

The current state is that the workflow of Dashboards observability plugin E2E test is able to be run and the the cypress framework can work properly (see log here: https://github.com/RyanL1997/dashboards-observability/actions/runs/7145888298/job/19462486749). However, the test cases is still failing, and it should be resolved in the follow up PR for #1040.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f252fb1) 56.32% compared to head (e6af95b) 56.32%.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1290    +/-   ##
========================================
  Coverage   56.32%   56.32%            
========================================
  Files         327      327            
  Lines       11944    11944            
  Branches     2741     2800    +59     
========================================
  Hits         6728     6728            
+ Misses       5171     4913   -258     
- Partials       45      303   +258     
Flag Coverage Δ
dashboards-observability 56.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Swiddis Swiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RyanL1997 RyanL1997 marked this pull request as draft December 8, 2023 00:15
@RyanL1997
Copy link
Collaborator Author

RyanL1997 commented Dec 8, 2023

Transferring some of the conversation between me and @ps48 here: this PR will also refactor the current workflow structure and separate the test cases into parallel runs.

Signed-off-by: Ryan Liang <[email protected]>
@RyanL1997 RyanL1997 marked this pull request as ready for review December 8, 2023 20:30
@RyanL1997
Copy link
Collaborator Author

RyanL1997 commented Dec 8, 2023

The refactor has been done. The test cases have been separated into its own GH runner. We have also setup the directory for future splitting of the test classes. The sample run is here: https://github.com/RyanL1997/dashboards-observability/actions/runs/7145888298/job/19462486749

Could you plz review it again? If nothing surface up, lets merge this so that we can start fixing the failing test cases in the above log.
(cc: @ps48, @Swiddis , @mengweieric, @joshuali925 )

@RyanL1997 RyanL1997 changed the title [Bug Fix] Cypress CI Fix [CI/CD] Refactor Cypress Workflow Dec 8, 2023
@Swiddis

This comment was marked as outdated.

Copy link
Collaborator

@mengweieric mengweieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
@mengweieric mengweieric merged commit 8f091bd into opensearch-project:main Dec 11, 2023
RyanL1997 pushed a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
…search-project#1291)

Signed-off-by: Mohammad Qureshi <[email protected]>
(cherry picked from commit 180f69458a9ebc9c1d3d8661b66326318f98b800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Outdated Cypress tests in 9_integrations
6 participants