Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport main] Minor changes for cypress workflow #1302

Merged

Conversation

RyanL1997
Copy link
Collaborator

@RyanL1997 RyanL1997 commented Dec 15, 2023

Description

Reference to the comment on #1299, this PR includes following minor changes:

  • Change the OSD checking step by using streaming instead of looping
  • Add dynamic naming for each parallel job
  • Enabled this workflow on PR
  • Remove a duplicate group of notebooks_test

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c775d85) 56.32% compared to head (a277bc4) 56.32%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1302   +/-   ##
=======================================
  Coverage   56.32%   56.32%           
=======================================
  Files         327      327           
  Lines       11944    11944           
  Branches     2741     2741           
=======================================
  Hits         6728     6728           
  Misses       5171     5171           
  Partials       45       45           
Flag Coverage Δ
dashboards-observability 56.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mengweieric mengweieric merged commit 3c57327 into opensearch-project:main Dec 15, 2023
10 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants