-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid use of indicesService in Resume replicaiton flow #1030
Avoid use of indicesService in Resume replicaiton flow #1030
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1030 +/- ##
============================================
- Coverage 70.71% 70.51% -0.21%
+ Complexity 1001 997 -4
============================================
Files 141 141
Lines 4770 4768 -2
Branches 540 540
============================================
- Hits 3373 3362 -11
- Misses 1052 1062 +10
+ Partials 345 344 -1
|
Can you add some description regarding why this change is being done ? |
val indexShard = followerIndexService.getShard(followerShardId.id) | ||
|
||
if (!retentionLeaseHelper.verifyRetentionLeaseExist(ShardId(params.leaderIndex, followerShardId.id), followerShardId, indexShard.lastSyncedGlobalCheckpoint+1)) { | ||
if (!retentionLeaseHelper.verifyRetentionLeaseExist(ShardId(params.leaderIndex, followerShardId.id), followerShardId, RetentionLeaseActions.RETAIN_ALL)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you instead remove the last argument here? and simply use RETAIN_ALL
in verifyRetentionLeaseExist
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed ✅
Signed-off-by: monusingh-1 <[email protected]>
2ada1c0
to
1cdb22c
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1 1.1
# Navigate to the new working tree
cd .worktrees/backport-1.1
# Create a new branch
git switch --create backport/backport-1030-to-1.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 66d126e626b5ddbe84d1139655478e14fb9de0be
# Push it to GitHub
git push --set-upstream origin backport/backport-1030-to-1.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1 Then, create a pull request where the |
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]> (cherry picked from commit 66d126e)
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]> (cherry picked from commit 66d126e) Co-authored-by: Monu Singh <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]> (cherry picked from commit 66d126e) Co-authored-by: Monu Singh <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Avoid use of indicesService in Resume replicaiton flow. Signed-off-by: monusingh-1 <[email protected]>
Description
Calling indicesService's indexServiceSafe in the resume flow breaks in dedicated master node configuration with following error:
This change avoids using indicesService and instead passes RetentionLeaseActions.RETAIN_ALL as new retention lease is only taken when the new lease id does not exists but old lease id exists.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.