Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Avoid use of indicesService in Resume replicaiton flow (#1030) #1049

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

monusingh-1
Copy link
Collaborator

Avoid use of indicesService in Resume replicaiton flow.
Signed-off-by: monusingh-1 [email protected]

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Avoid use of indicesService in Resume replicaiton flow.
Signed-off-by: monusingh-1 <[email protected]>
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #1049 (726f517) into 2.4 (864cdf5) will decrease coverage by 0.51%.
The diff coverage is 53.42%.

❗ Current head 726f517 differs from pull request most recent head 122b972. Consider uploading reports for the commit 122b972 to get more accurate results

@@             Coverage Diff              @@
##                2.4    #1049      +/-   ##
============================================
- Coverage     73.27%   72.76%   -0.51%     
- Complexity      998     1007       +9     
============================================
  Files           141      141              
  Lines          4628     4686      +58     
  Branches        514      521       +7     
============================================
+ Hits           3391     3410      +19     
- Misses          918      953      +35     
- Partials        319      323       +4     
Impacted Files Coverage Δ
...action/stop/TransportStopIndexReplicationAction.kt 56.12% <40.00%> (-4.64%) ⬇️
...ication/seqno/RemoteClusterRetentionLeaseHelper.kt 65.30% <54.16%> (-14.70%) ⬇️
...on/resume/TransportResumeIndexReplicationAction.kt 86.95% <100.00%> (ø)
.../replication/repository/RemoteClusterRepository.kt 72.99% <100.00%> (+0.19%) ⬆️
...rch/replication/task/index/IndexReplicationTask.kt 68.49% <100.00%> (-0.66%) ⬇️
...rch/replication/task/shard/ShardReplicationTask.kt 75.18% <100.00%> (ø)

... and 2 files with indirect coverage changes

@monusingh-1 monusingh-1 marked this pull request as ready for review July 6, 2023 04:31
@monusingh-1 monusingh-1 enabled auto-merge (squash) July 6, 2023 04:31
@monusingh-1 monusingh-1 changed the title Avoid use of indicesService in Resume replicaiton flow (#1030) [Backport 2.4] Avoid use of indicesService in Resume replicaiton flow (#1030) Jul 6, 2023
@monusingh-1 monusingh-1 merged commit ee64212 into 2.4 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants