Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Adds Chained alerts triggers for workflows #457

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 5ef9b55 from #456

* adds models for chained alert trigger and chained alerts (#426)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix execution id field in alerts (#429)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* accept workflow argument in chained alert constructor (#435)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests for chained alert

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 5ef9b55)
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #457 (78774d2) into 2.x (53e10be) will increase coverage by 0.15%.
The diff coverage is 76.64%.

@@             Coverage Diff              @@
##                2.x     #457      +/-   ##
============================================
+ Coverage     71.14%   71.29%   +0.15%     
- Complexity      771      786      +15     
============================================
  Files           125      126       +1     
  Lines          5208     5330     +122     
  Branches        661      674      +13     
============================================
+ Hits           3705     3800      +95     
- Misses         1224     1240      +16     
- Partials        279      290      +11     
Impacted Files Coverage Δ
...lin/org/opensearch/commons/alerting/model/Alert.kt 75.36% <71.05%> (+0.26%) ⬆️
...arch/commons/alerting/model/ChainedAlertTrigger.kt 75.34% <75.34%> (ø)
.../org/opensearch/commons/alerting/model/Workflow.kt 81.29% <86.95%> (+0.54%) ⬆️
...n/org/opensearch/commons/alerting/model/Trigger.kt 86.95% <100.00%> (+1.24%) ⬆️

@eirsep eirsep merged commit 03505f0 into 2.x Jun 20, 2023
@github-actions github-actions bot deleted the backport/backport-456-to-2.x branch June 20, 2023 15:52
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…pensearch-project#457)

* adds models for chained alert trigger and chained alerts (opensearch-project#426)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix execution id field in alerts (opensearch-project#429)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* accept workflow argument in chained alert constructor (opensearch-project#435)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests for chained alert

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 5ef9b55)

Co-authored-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants