accept workflow argument in chained alert constructor #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surya Sashank Nistala <[email protected]>
lezzago
approved these changes
May 22, 2023
eirsep
added a commit
to eirsep/common-utils
that referenced
this pull request
Jun 19, 2023
…ject#435) Signed-off-by: Surya Sashank Nistala <[email protected]>
eirsep
added a commit
that referenced
this pull request
Jun 20, 2023
* adds models for chained alert trigger and chained alerts (#426) Signed-off-by: Surya Sashank Nistala <[email protected]> * fix execution id field in alerts (#429) Signed-off-by: Surya Sashank Nistala <[email protected]> * accept workflow argument in chained alert constructor (#435) Signed-off-by: Surya Sashank Nistala <[email protected]> * add tests for chained alert Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 20, 2023
* adds models for chained alert trigger and chained alerts (#426) Signed-off-by: Surya Sashank Nistala <[email protected]> * fix execution id field in alerts (#429) Signed-off-by: Surya Sashank Nistala <[email protected]> * accept workflow argument in chained alert constructor (#435) Signed-off-by: Surya Sashank Nistala <[email protected]> * add tests for chained alert Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 5ef9b55)
eirsep
added a commit
that referenced
this pull request
Jun 20, 2023
* adds models for chained alert trigger and chained alerts (#426) Signed-off-by: Surya Sashank Nistala <[email protected]> * fix execution id field in alerts (#429) Signed-off-by: Surya Sashank Nistala <[email protected]> * accept workflow argument in chained alert constructor (#435) Signed-off-by: Surya Sashank Nistala <[email protected]> * add tests for chained alert Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 5ef9b55) Co-authored-by: Surya Sashank Nistala <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/common-utils
that referenced
this pull request
Apr 12, 2024
…pensearch-project#457) * adds models for chained alert trigger and chained alerts (opensearch-project#426) Signed-off-by: Surya Sashank Nistala <[email protected]> * fix execution id field in alerts (opensearch-project#429) Signed-off-by: Surya Sashank Nistala <[email protected]> * accept workflow argument in chained alert constructor (opensearch-project#435) Signed-off-by: Surya Sashank Nistala <[email protected]> * add tests for chained alert Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 5ef9b55) Co-authored-by: Surya Sashank Nistala <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accept workflow argument in chained alert constructor. Workflow would contain id, name and user fields which make it a good dto to pass along similar to how other types of alerts accept monitor object in constructor