Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Chained alerts triggers for workflows #456

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jun 19, 2023

Description

Merging into main the following feature branch commits/merged PRs:
accept workflow argument in chained alert constructor #435
Adds workflows model and workflow actions for Alerting Plugin #436
adds models for chained alert trigger and chained alerts #426

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #456 (f3be2fc) into main (1484bff) will increase coverage by 0.09%.
The diff coverage is 76.64%.

@@             Coverage Diff              @@
##               main     #456      +/-   ##
============================================
+ Coverage     73.69%   73.78%   +0.09%     
- Complexity      804      819      +15     
============================================
  Files           125      126       +1     
  Lines          5219     5341     +122     
  Branches        662      675      +13     
============================================
+ Hits           3846     3941      +95     
- Misses         1087     1103      +16     
- Partials        286      297      +11     
Impacted Files Coverage Δ
...lin/org/opensearch/commons/alerting/model/Alert.kt 75.36% <71.05%> (+0.26%) ⬆️
...arch/commons/alerting/model/ChainedAlertTrigger.kt 75.34% <75.34%> (ø)
.../org/opensearch/commons/alerting/model/Workflow.kt 81.93% <86.95%> (+0.45%) ⬆️
...n/org/opensearch/commons/alerting/model/Trigger.kt 86.95% <100.00%> (+1.24%) ⬆️

@eirsep eirsep force-pushed the chain branch 3 times, most recently from 8bfd4f1 to e0dd805 Compare June 19, 2023 23:59
Signed-off-by: Surya Sashank Nistala <[email protected]>
@eirsep eirsep merged commit 5ef9b55 into opensearch-project:main Jun 20, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 20, 2023
* adds models for chained alert trigger and chained alerts (#426)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix execution id field in alerts (#429)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* accept workflow argument in chained alert constructor (#435)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests for chained alert

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 5ef9b55)
eirsep added a commit that referenced this pull request Jun 20, 2023
* adds models for chained alert trigger and chained alerts (#426)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix execution id field in alerts (#429)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* accept workflow argument in chained alert constructor (#435)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests for chained alert

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 5ef9b55)

Co-authored-by: Surya Sashank Nistala <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Apr 12, 2024
…pensearch-project#457)

* adds models for chained alert trigger and chained alerts (opensearch-project#426)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix execution id field in alerts (opensearch-project#429)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* accept workflow argument in chained alert constructor (opensearch-project#435)

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add tests for chained alert

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 5ef9b55)

Co-authored-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants