[Backport 2.x] Fix display of detector names #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
When starting or stopping detectors, the pop-up window shows the detector names as `DETECTOR_NAME />` where "DETECTOR_NAME" is the name of the detector. The markup seems to have residual `/>` that are rendered to the user. Remove them to ensure they do not appear between the opening and the closing EuiLink tags. Signed-off-by: Romain Tartière <[email protected]> (cherry picked from commit 3bdcb64)
opensearch-trigger-bot
bot
requested review from
ohltyler,
kaituo,
jackiehanyang,
amitgalitz and
sean-zheng-amazon
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #586 +/- ##
=======================================
Coverage 50.28% 50.28%
=======================================
Files 166 166
Lines 5590 5590
Branches 1055 1055
=======================================
Hits 2811 2811
Misses 2508 2508
Partials 271 271 |
kaituo
approved these changes
Aug 11, 2023
jackiehanyang
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3bdcb64 from #585