Fix display of detector names #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting or stopping detectors, the pop-up window shows the detector names as `DETECTOR_NAME />` where "DETECTOR_NAME" is the name of the detector. The markup seems to have residual `/>` that are rendered to the user. Remove them to ensure they do not appear between the opening and the closing EuiLink tags. Signed-off-by: Romain Tartière <[email protected]>
smortex
requested review from
ohltyler,
kaituo,
jackiehanyang,
amitgalitz and
sean-zheng-amazon
as code owners
kaituo
approved these changes
Aug 7, 2023
|
CI failures seems unrelated 🙄 :
|
jackiehanyang
approved these changes
Aug 9, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 9, 2023
When starting or stopping detectors, the pop-up window shows the detector names as `DETECTOR_NAME />` where "DETECTOR_NAME" is the name of the detector. The markup seems to have residual `/>` that are rendered to the user. Remove them to ensure they do not appear between the opening and the closing EuiLink tags. Signed-off-by: Romain Tartière <[email protected]> (cherry picked from commit 3bdcb64)
jackiehanyang
pushed a commit
that referenced
this pull request
Aug 14, 2023
When starting or stopping detectors, the pop-up window shows the detector names as `DETECTOR_NAME />` where "DETECTOR_NAME" is the name of the detector. The markup seems to have residual `/>` that are rendered to the user. Remove them to ensure they do not appear between the opening and the closing EuiLink tags. Signed-off-by: Romain Tartière <[email protected]> (cherry picked from commit 3bdcb64) Co-authored-by: Romain Tartière <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting or stopping detectors, the pop-up window shows the detector names as
DETECTOR_NAME />where "DETECTOR_NAME" is the name of the detector.The markup seems to have residual
/>that are rendered to the user. Remove them to ensure they do not appear between the opening and the closing EuiLink tags.To reproduce: