Skip to content

Commit

Permalink
Fix display of detector names (#585)
Browse files Browse the repository at this point in the history
When starting or stopping detectors, the pop-up window shows the
detector names as `DETECTOR_NAME />` where "DETECTOR_NAME" is the name
of the detector.

The markup seems to have residual `/>` that are rendered to the user.
Remove them to ensure they do not appear between the opening and the
closing EuiLink tags.

Signed-off-by: Romain Tartière <[email protected]>
  • Loading branch information
smortex authored Aug 9, 2023
1 parent 53677c5 commit 3bdcb64
Showing 1 changed file with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const getNames = (detectors: DetectorListItem[]) => {
href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`}
target="_blank"
>
{detectors[i].name} />
{detectors[i].name}
</EuiLink>
),
});
Expand All @@ -49,15 +49,15 @@ const getNamesAndMonitors = (
href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`}
target="_blank"
>
{detectors[i].name} />
{detectors[i].name}
</EuiLink>
),
Monitor: (
<EuiLink
href={`${getAlertingMonitorListLink()}/${relatedMonitor.id}`}
target="_blank"
>
{relatedMonitor.name} />
{relatedMonitor.name}
</EuiLink>
),
});
Expand All @@ -68,7 +68,7 @@ const getNamesAndMonitors = (
href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`}
target="_blank"
>
{detectors[i].name} />
{detectors[i].name}
</EuiLink>
),
Monitor: '-',
Expand All @@ -95,15 +95,15 @@ const getNamesAndMonitorsAndStates = (
href={`${PLUGIN_NAME}#/detectors/${detectors[i].id}`}
target="_blank"
>
{detectors[i].name} />
{detectors[i].name}
</EuiLink>
),
Monitor: (
<EuiLink
href={`${getAlertingMonitorListLink()}/${relatedMonitor.id}`}
target="_blank"
>
{relatedMonitor.name} />
{relatedMonitor.name}
</EuiLink>
),
Running: <EuiText>{isRunning ? 'Yes' : 'No'}</EuiText>,
Expand Down

0 comments on commit 3bdcb64

Please sign in to comment.