do not create Message component on every text change #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
lezzago
approved these changes
Dec 15, 2023
AWSHurneyt
approved these changes
Dec 15, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 7cef11c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit 7cef11c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Dec 15, 2023
(cherry picked from commit 7cef11c) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Dec 15, 2023
(cherry picked from commit 7cef11c) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Feb 5, 2024
…ect#854) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
pushed a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Feb 5, 2024
…ect#854) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]>
amsiglan
added a commit
that referenced
this pull request
Feb 6, 2024
* Support any channel types from Notification (#743) * Support any channel types from Notification Signed-off-by: Ashish Agrawal <[email protected]> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <[email protected]> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. Signed-off-by: AWSHurneyt <[email protected]> * Updated cypress workflow. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions Signed-off-by: Peter Zhu <[email protected]> * Small typos Signed-off-by: Peter Zhu <[email protected]> * Add back workflows Signed-off-by: Peter Zhu <[email protected]> * Restore macos/windows Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. Signed-off-by: AWSHurneyt <[email protected]> * Updated yarn file. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved dependency conflict Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated babel config Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. Signed-off-by: AWSHurneyt <[email protected]> * Fixed trigger context object bug in issue 791. Signed-off-by: AWSHurneyt <[email protected]> * Capitalized bucket column titles, and moved bucket columns to the end of the column array. Signed-off-by: AWSHurneyt <[email protected]> * Added wait steps to reduce test flakiness. Signed-off-by: AWSHurneyt <[email protected]> * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. Signed-off-by: AWSHurneyt <[email protected]> * Removed unused imports. Signed-off-by: AWSHurneyt <[email protected]> * fixed bucket level monitor flaky cypress test Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Issue #671 fix trigger name validation (#794) Signed-off-by: Chenxi Wang <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Remove integtest.sh since it is not being used (#849) Signed-off-by: Derek Ho <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * do not create Message component on every text change (#854) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Implemented server API call to feature backend API. Signed-off-by: AWSHurneyt <[email protected]> * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. Signed-off-by: AWSHurneyt <[email protected]> * Implemented warning model when monitor execution time exceeds a certain value. Signed-off-by: AWSHurneyt <[email protected]> * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. Signed-off-by: AWSHurneyt <[email protected]> * Updated unit tests. Signed-off-by: AWSHurneyt <[email protected]> * Added experimental banner. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> * Edited text on the experimental banner. Signed-off-by: AWSHurneyt <[email protected]> * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> * Increased cypress test timeout. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Chenxi Wang <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Ashish Agrawal <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Chenxi Wang <[email protected]> Co-authored-by: Derek Ho <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Support any channel types from Notification (#743) * Support any channel types from Notification Signed-off-by: Ashish Agrawal <[email protected]> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <[email protected]> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Drafted 2.11 release notes. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. Signed-off-by: AWSHurneyt <[email protected]> * Updated cypress workflow. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions Signed-off-by: Peter Zhu <[email protected]> * Small typos Signed-off-by: Peter Zhu <[email protected]> * Add back workflows Signed-off-by: Peter Zhu <[email protected]> * Restore macos/windows Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. Signed-off-by: AWSHurneyt <[email protected]> * Updated yarn file. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props Signed-off-by: Amardeepsingh Siglani <[email protected]> * resolved dependency conflict Signed-off-by: Amardeepsingh Siglani <[email protected]> * updated babel config Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> * Added 2.11.1 release notes. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. Signed-off-by: AWSHurneyt <[email protected]> * Fixed trigger context object bug in issue 791. Signed-off-by: AWSHurneyt <[email protected]> * Capitalized bucket column titles, and moved bucket columns to the end of the column array. Signed-off-by: AWSHurneyt <[email protected]> * Added wait steps to reduce test flakiness. Signed-off-by: AWSHurneyt <[email protected]> * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. Signed-off-by: AWSHurneyt <[email protected]> * Removed unused imports. Signed-off-by: AWSHurneyt <[email protected]> * fixed bucket level monitor flaky cypress test Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Issue #671 fix trigger name validation (#794) Signed-off-by: Chenxi Wang <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Remove integtest.sh since it is not being used (#849) Signed-off-by: Derek Ho <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * do not create Message component on every text change (#854) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> * Implemented server API call to feature backend API. Signed-off-by: AWSHurneyt <[email protected]> * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. Signed-off-by: AWSHurneyt <[email protected]> * Implemented warning model when monitor execution time exceeds a certain value. Signed-off-by: AWSHurneyt <[email protected]> * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. Signed-off-by: AWSHurneyt <[email protected]> * Updated unit tests. Signed-off-by: AWSHurneyt <[email protected]> * Added experimental banner. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> * Edited text on the experimental banner. Signed-off-by: AWSHurneyt <[email protected]> * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. Signed-off-by: AWSHurneyt <[email protected]> * Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> * Increased cypress test timeout. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Chenxi Wang <[email protected]> Signed-off-by: Derek Ho <[email protected]> Co-authored-by: Ashish Agrawal <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Chenxi Wang <[email protected]> Co-authored-by: Derek Ho <[email protected]> (cherry picked from commit fb82368) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Feb 6, 2024
* Support any channel types from Notification (#743) * Support any channel types from Notification * Remove unused CHANNEL_TYPES constant * Return empty array if failed to get features --------- * Drafted 2.11 release notes. (#764) * Drafted 2.11 release notes. * Drafted 2.11 release notes. --------- * Removed "last updated by" sections from the UI. (#767) * Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info. * Updated cypress workflow. --------- * Onboard Jenkins prod docker image to github actions (#789) * Onboard Jenkins prod docker image to github actions * Small typos * Add back workflows * Restore macos/windows --------- * Bumped babel version. (#821) * Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump. * Updated yarn file. --------- * Fix fetching of channels for composite monitors (#820) * fixed incorrect use of this.props * resolved dependency conflict * updated babel config --------- * Added 2.11.1 release notes. (#828) * Amended 2.11.0 release notes. * Added 2.11.1 release notes. * Added 2.11.1 release notes. * Added 2.11.1 release notes. * Added 2.11.1 release notes. --------- * Fixed bucket monitor groupBy/aggregation display bug. (#827) * Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818. * Fixed trigger context object bug in issue 791. * Capitalized bucket column titles, and moved bucket columns to the end of the column array. * Added wait steps to reduce test flakiness. * Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters. * Removed unused imports. * fixed bucket level monitor flaky cypress test --------- * Issue #671 fix trigger name validation (#794) * Remove integtest.sh since it is not being used (#849) * do not create Message component on every text change (#854) * Implemented server API call to feature backend API. * Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors. * Implemented warning model when monitor execution time exceeds a certain value. * Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources. * Updated unit tests. * Added experimental banner. * Updated snapshots. * Edited text on the experimental banner. * Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled. * Updated snapshots. * Increased cypress test timeout. --------- (cherry picked from commit fb82368) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: Chenxi Wang <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ashish Agrawal <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: Chenxi Wang <[email protected]> Co-authored-by: Derek Ho <[email protected]>
smuthukaruppannp
pushed a commit
to smuthukaruppannp/alerting-dashboards-plugin
that referenced
this pull request
Feb 7, 2024
…ect#854) Signed-off-by: Amardeepsingh Siglani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we ensure that the Message component does not get re-created every time there is a change made to the message template.
Issues Resolved
#853
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.