Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped babel version. #821

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

AWSHurneyt
Copy link
Collaborator

Description

  1. Bumped babel version.
  2. Adjusted babel config.
  3. Refactored unit test that started failing after bump.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…t started failing after bump.

Signed-off-by: AWSHurneyt <[email protected]>
@@ -75,7 +75,7 @@ export const getDigitId = (length = 6) =>

// Assumes that values is an array of objects with "name" inside
export const getUniqueName = (values, prefix) => {
const lastValue = values.at(-1);
const lastValue = _.last(values);
Copy link
Collaborator Author

@AWSHurneyt AWSHurneyt Nov 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For context, the following test started failing when executing yarn run test:jest. Refactored the .at() call to _.last().

 FAIL  public/components/FeatureAnywhereContextMenu/AddAlertingMonitor/CreateNew/CreateNew.test.js (24.469 s)
  ● CreateNew › renders

    TypeError: values.at is not a function

      78 |   const lastValue = values.at(-1);
         |                            ^
      81 |   const lastName = lastValue ? lastValue.name : '';
      82 |   const lastDigit = Number.parseInt(lastName.match(/\d+$/)?.[0] || 0, 10);
      83 |

      at getUniqueName (public/utils/helpers.js:80:12)
      at getInitialTriggerValues (public/pages/CreateTrigger/components/AddTriggerButton/utils.js:30:39)
      at getInitialValues (public/pages/CreateMonitor/containers/CreateMonitor/utils/helpers.js:49:51)
      at Object.<anonymous> (public/components/FeatureAnywhereContextMenu/AddAlertingMonitor/CreateNew/CreateNew.test.js:32:42)

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffe8539) 49.84% compared to head (ba9296b) 49.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #821   +/-   ##
=======================================
  Coverage   49.84%   49.84%           
=======================================
  Files         232      232           
  Lines        6556     6556           
  Branches      938      938           
=======================================
  Hits         3268     3268           
  Misses       3285     3285           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AWSHurneyt
Copy link
Collaborator Author

Re-triggered the cypress workflow as the failing bucket monitor test (link) seems to be flaky. The tests pass locally.
Screenshot 2023-11-20 at 9 50 05 AM

package.json Show resolved Hide resolved
Signed-off-by: AWSHurneyt <[email protected]>
@AWSHurneyt AWSHurneyt merged commit 598b086 into opensearch-project:main Nov 20, 2023
11 of 14 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 20, 2023
* Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated yarn file.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 598b086)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 20, 2023
* Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated yarn file.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 598b086)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 20, 2023
* Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated yarn file.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 598b086)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Nov 21, 2023
* Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump.



* Updated yarn file.



---------


(cherry picked from commit 598b086)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt added a commit to AWSHurneyt/alerting-dashboards-plugin that referenced this pull request Feb 5, 2024
* Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated yarn file.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
amsiglan added a commit that referenced this pull request Feb 6, 2024
* Support any channel types from Notification (#743)

* Support any channel types from Notification

Signed-off-by: Ashish Agrawal <[email protected]>

* Remove unused CHANNEL_TYPES constant

Signed-off-by: Ashish Agrawal <[email protected]>

* Return empty array if failed to get features

Signed-off-by: Ashish Agrawal <[email protected]>

---------

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Drafted 2.11 release notes. (#764)

* Drafted 2.11 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Drafted 2.11 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Removed "last updated by" sections from the UI. (#767)

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Onboard Jenkins prod docker image to github actions (#789)

* Onboard Jenkins prod docker image to github actions

Signed-off-by: Peter Zhu <[email protected]>

* Small typos

Signed-off-by: Peter Zhu <[email protected]>

* Add back workflows

Signed-off-by: Peter Zhu <[email protected]>

* Restore macos/windows

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Bumped babel version. (#821)

* Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated yarn file.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Fix fetching of channels for composite monitors (#820)

* fixed incorrect use of this.props

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved dependency conflict

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated babel config

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes. (#828)

* Amended 2.11.0 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed bucket monitor groupBy/aggregation display bug. (#827)

* Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed trigger context object bug in issue 791.

Signed-off-by: AWSHurneyt <[email protected]>

* Capitalized bucket column titles, and moved bucket columns to the end of the column array.

Signed-off-by: AWSHurneyt <[email protected]>

* Added wait steps to reduce test flakiness.

Signed-off-by: AWSHurneyt <[email protected]>

* Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters.

Signed-off-by: AWSHurneyt <[email protected]>

* Removed unused imports.

Signed-off-by: AWSHurneyt <[email protected]>

* fixed bucket level monitor flaky cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Issue #671 fix trigger name validation (#794)


Signed-off-by: Chenxi Wang <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Remove integtest.sh since it is not being used (#849)

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* do not create Message component on every text change (#854)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Implemented server API call to feature backend API.

Signed-off-by: AWSHurneyt <[email protected]>

* Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors.

Signed-off-by: AWSHurneyt <[email protected]>

* Implemented warning model when monitor execution time exceeds a certain value.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated unit tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Added experimental banner.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated snapshots.

Signed-off-by: AWSHurneyt <[email protected]>

* Edited text on the experimental banner.

Signed-off-by: AWSHurneyt <[email protected]>

* Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated snapshots.

Signed-off-by: AWSHurneyt <[email protected]>

* Increased cypress test timeout.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Chenxi Wang <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Ashish Agrawal <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Chenxi Wang <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 6, 2024
* Support any channel types from Notification (#743)

* Support any channel types from Notification

Signed-off-by: Ashish Agrawal <[email protected]>

* Remove unused CHANNEL_TYPES constant

Signed-off-by: Ashish Agrawal <[email protected]>

* Return empty array if failed to get features

Signed-off-by: Ashish Agrawal <[email protected]>

---------

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Drafted 2.11 release notes. (#764)

* Drafted 2.11 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Drafted 2.11 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Removed "last updated by" sections from the UI. (#767)

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Onboard Jenkins prod docker image to github actions (#789)

* Onboard Jenkins prod docker image to github actions

Signed-off-by: Peter Zhu <[email protected]>

* Small typos

Signed-off-by: Peter Zhu <[email protected]>

* Add back workflows

Signed-off-by: Peter Zhu <[email protected]>

* Restore macos/windows

Signed-off-by: Peter Zhu <[email protected]>

---------

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Bumped babel version. (#821)

* Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated yarn file.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Fix fetching of channels for composite monitors (#820)

* fixed incorrect use of this.props

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* resolved dependency conflict

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated babel config

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes. (#828)

* Amended 2.11.0 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.11.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed bucket monitor groupBy/aggregation display bug. (#827)

* Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed trigger context object bug in issue 791.

Signed-off-by: AWSHurneyt <[email protected]>

* Capitalized bucket column titles, and moved bucket columns to the end of the column array.

Signed-off-by: AWSHurneyt <[email protected]>

* Added wait steps to reduce test flakiness.

Signed-off-by: AWSHurneyt <[email protected]>

* Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters.

Signed-off-by: AWSHurneyt <[email protected]>

* Removed unused imports.

Signed-off-by: AWSHurneyt <[email protected]>

* fixed bucket level monitor flaky cypress test

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Issue #671 fix trigger name validation (#794)

Signed-off-by: Chenxi Wang <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Remove integtest.sh since it is not being used (#849)

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* do not create Message component on every text change (#854)

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>

* Implemented server API call to feature backend API.

Signed-off-by: AWSHurneyt <[email protected]>

* Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors.

Signed-off-by: AWSHurneyt <[email protected]>

* Implemented warning model when monitor execution time exceeds a certain value.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated unit tests.

Signed-off-by: AWSHurneyt <[email protected]>

* Added experimental banner.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated snapshots.

Signed-off-by: AWSHurneyt <[email protected]>

* Edited text on the experimental banner.

Signed-off-by: AWSHurneyt <[email protected]>

* Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated snapshots.

Signed-off-by: AWSHurneyt <[email protected]>

* Increased cypress test timeout.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Chenxi Wang <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Ashish Agrawal <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Chenxi Wang <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
(cherry picked from commit fb82368)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Feb 6, 2024
* Support any channel types from Notification (#743)

* Support any channel types from Notification



* Remove unused CHANNEL_TYPES constant



* Return empty array if failed to get features



---------




* Drafted 2.11 release notes. (#764)

* Drafted 2.11 release notes.



* Drafted 2.11 release notes.



---------



* Removed "last updated by" sections from the UI. (#767)

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.



* Updated cypress workflow.



---------



* Onboard Jenkins prod docker image to github actions (#789)

* Onboard Jenkins prod docker image to github actions



* Small typos



* Add back workflows



* Restore macos/windows



---------




* Bumped babel version. (#821)

* Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump.



* Updated yarn file.



---------



* Fix fetching of channels for composite monitors (#820)

* fixed incorrect use of this.props



* resolved dependency conflict



* updated babel config



---------




* Added 2.11.1 release notes. (#828)

* Amended 2.11.0 release notes.



* Added 2.11.1 release notes.



* Added 2.11.1 release notes.



* Added 2.11.1 release notes.



* Added 2.11.1 release notes.



---------



* Fixed bucket monitor groupBy/aggregation display bug. (#827)

* Fixed a bug that was causing groupBy/aggregation fields from displaying in various areas of the UI. Related issues: 816, 817, 818.



* Fixed trigger context object bug in issue 791.



* Capitalized bucket column titles, and moved bucket columns to the end of the column array.



* Added wait steps to reduce test flakiness.



* Added wait step to reduce test flakiness. Adjusted test monitor trigger condition to always triggers on a healthy clusters.



* Removed unused imports.



* fixed bucket level monitor flaky cypress test



---------






* Issue #671 fix trigger name validation (#794)




* Remove integtest.sh since it is not being used (#849)




* do not create Message component on every text change (#854)




* Implemented server API call to feature backend API.



* Implemented remote cluster support for creating/editing query, bucket, and cluster metrics monitors.



* Implemented warning model when monitor execution time exceeds a certain value.



* Updated alert details flyout to show remote cluster info. Updated monitor details page to show data sources.



* Updated unit tests.



* Added experimental banner.



* Updated snapshots.



* Edited text on the experimental banner.



* Moved getSettings call to hide Data source panel for cluster metrics monitors when remote monitoring is disabled.



* Updated snapshots.



* Increased cypress test timeout.



---------












(cherry picked from commit fb82368)

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Chenxi Wang <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ashish Agrawal <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Chenxi Wang <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
smuthukaruppannp pushed a commit to smuthukaruppannp/alerting-dashboards-plugin that referenced this pull request Feb 7, 2024
* Bumped babel version. Adjusted babel config. Refactored unit test that started failing after bump.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated yarn file.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants