Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Remote Store] Fix stats api bugs (#7739) & (#7774) #7838

Merged
merged 2 commits into from
May 31, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented May 31, 2023

Description

This backports #7739 & #7775

Related Issues

Resolves #7738 & #7774

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94 ashking94 changed the title [Remote Store] Fix shards condition in stats api (#7739) [Backport 2.x] [Remote Store] Fix shards condition in stats api (#7739) May 31, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94 ashking94 changed the title [Backport 2.x] [Remote Store] Fix shards condition in stats api (#7739) [Backport 2.x] [Remote Store] Fix stats api bugs (#7739) & (#7774) May 31, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #7838 (104d9a0) into 2.x (050d418) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                2.x    #7838      +/-   ##
============================================
- Coverage     70.66%   70.57%   -0.10%     
+ Complexity    56437    56426      -11     
============================================
  Files          4665     4665              
  Lines        267672   267674       +2     
  Branches      39634    39634              
============================================
- Hits         189154   188901     -253     
- Misses        62216    62502     +286     
+ Partials      16302    16271      -31     
Impacted Files Coverage Δ
...testore/stats/TransportRemoteStoreStatsAction.java 45.94% <100.00%> (+4.27%) ⬆️
...arch/index/remote/RemoteRefreshSegmentTracker.java 88.54% <100.00%> (+0.05%) ⬆️

... and 457 files with indirect coverage changes

@andrross andrross merged commit 9d88cc7 into opensearch-project:2.x May 31, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…7739) & (opensearch-project#7774) (opensearch-project#7838)

* [Remote Store] Fix shards condition in stats api (opensearch-project#7739)

Signed-off-by: Ashish Singh <[email protected]>

* Fix remote store stats api rejection count response (opensearch-project#7775)

Signed-off-by: Ashish Singh <[email protected]>

---------

Signed-off-by: Ashish Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants