-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Remote Store] Fix stats api bugs (#7739) & (#7774) #7838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…7739) Signed-off-by: Ashish Singh <[email protected]>
ashking94
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
May 31, 2023 13:41
ashking94
changed the title
[Remote Store] Fix shards condition in stats api (#7739)
[Backport 2.x] [Remote Store] Fix shards condition in stats api (#7739)
May 31, 2023
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
…ct#7775) Signed-off-by: Ashish Singh <[email protected]>
ashking94
changed the title
[Backport 2.x] [Remote Store] Fix shards condition in stats api (#7739)
[Backport 2.x] [Remote Store] Fix stats api bugs (#7739) & (#7774)
May 31, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7838 +/- ##
============================================
- Coverage 70.66% 70.57% -0.10%
+ Complexity 56437 56426 -11
============================================
Files 4665 4665
Lines 267672 267674 +2
Branches 39634 39634
============================================
- Hits 189154 188901 -253
- Misses 62216 62502 +286
+ Partials 16302 16271 -31
|
andrross
approved these changes
May 31, 2023
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…7739) & (opensearch-project#7774) (opensearch-project#7838) * [Remote Store] Fix shards condition in stats api (opensearch-project#7739) Signed-off-by: Ashish Singh <[email protected]> * Fix remote store stats api rejection count response (opensearch-project#7775) Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backports #7739 & #7775
Related Issues
Resolves #7738 & #7774
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.