Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Fix stats api rejection count response #7775

Merged
merged 1 commit into from
May 29, 2023

Conversation

ashking94
Copy link
Member

Description

The backpressure_rejection_count field in the _remotestore/stats/{index} api response was coming to be zero always. The issue is narrowed to the missing code of incrementing the global rejection counter when the remote segment backpressure framework rejects a write request. In the PR, we have fixed the issue.

Related Issues

Resolves #7774

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94 ashking94 changed the title Fix remote store stats api rejection count response [Remote Store] Fix stats api rejection count response May 26, 2023
@ashking94 ashking94 self-assigned this May 26, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@linuxpi
Copy link
Collaborator

linuxpi commented May 26, 2023

Changes LGTM. Please take a look at the build failure

@ashking94 ashking94 added Storage:Durability Issues and PRs related to the durability framework v2.8.0 'Issues and PRs related to version v2.8.0' labels May 26, 2023
@ashking94 ashking94 marked this pull request as ready for review May 26, 2023 10:17
@ashking94 ashking94 requested a review from dbwiddis as a code owner May 26, 2023 10:18
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94
Copy link
Member Author

Build failures would stop after #7739 is merged and this PR rebased with updated main.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.remotestore.RemoteStoreBackpressureIT.testWritesRejected

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #7775 (29bbd40) into main (adf7e2c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #7775      +/-   ##
============================================
+ Coverage     70.72%   70.78%   +0.05%     
- Complexity    56146    56169      +23     
============================================
  Files          4682     4682              
  Lines        266102   266103       +1     
  Branches      39070    39070              
============================================
+ Hits         188193   188353     +160     
+ Misses        61935    61807     -128     
+ Partials      15974    15943      -31     
Impacted Files Coverage Δ
...arch/index/remote/RemoteRefreshSegmentTracker.java 88.54% <100.00%> (+0.05%) ⬆️

... and 434 files with indirect coverage changes

@gbbafna gbbafna merged commit be540c4 into opensearch-project:main May 29, 2023
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label May 29, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 29, 2023
Signed-off-by: Ashish Singh <[email protected]>
(cherry picked from commit be540c4)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request May 31, 2023
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request May 31, 2023
stephen-crawford pushed a commit to stephen-crawford/OpenSearch that referenced this pull request May 31, 2023
andrross pushed a commit that referenced this pull request May 31, 2023
…7838)

* [Remote Store] Fix shards condition in stats api (#7739)

Signed-off-by: Ashish Singh <[email protected]>

* Fix remote store stats api rejection count response (#7775)

Signed-off-by: Ashish Singh <[email protected]>

---------

Signed-off-by: Ashish Singh <[email protected]>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Jun 2, 2023
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
…7739) & (opensearch-project#7774) (opensearch-project#7838)

* [Remote Store] Fix shards condition in stats api (opensearch-project#7739)

Signed-off-by: Ashish Singh <[email protected]>

* Fix remote store stats api rejection count response (opensearch-project#7775)

Signed-off-by: Ashish Singh <[email protected]>

---------

Signed-off-by: Ashish Singh <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog Storage:Durability Issues and PRs related to the durability framework v2.8.0 'Issues and PRs related to version v2.8.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remote store] Stats api bug - rejection count shown as zero
4 participants