-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Fix stats api rejection count response #7775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashking94
changed the title
Fix remote store stats api rejection count response
[Remote Store] Fix stats api rejection count response
May 26, 2023
Gradle Check (Jenkins) Run Completed with:
|
linuxpi
approved these changes
May 26, 2023
Changes LGTM. Please take a look at the build failure |
ashking94
added
Storage:Durability
Issues and PRs related to the durability framework
v2.8.0
'Issues and PRs related to version v2.8.0'
labels
May 26, 2023
ashking94
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng and
VachaShah
as code owners
May 26, 2023 10:18
sachinpkale
approved these changes
May 26, 2023
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ashish Singh <[email protected]>
Build failures would stop after #7739 is merged and this PR rebased with updated main. |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7775 +/- ##
============================================
+ Coverage 70.72% 70.78% +0.05%
- Complexity 56146 56169 +23
============================================
Files 4682 4682
Lines 266102 266103 +1
Branches 39070 39070
============================================
+ Hits 188193 188353 +160
+ Misses 61935 61807 -128
+ Partials 15974 15943 -31
|
gbbafna
approved these changes
May 29, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 29, 2023
Signed-off-by: Ashish Singh <[email protected]> (cherry picked from commit be540c4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
May 31, 2023
…ct#7775) Signed-off-by: Ashish Singh <[email protected]>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
May 31, 2023
…ct#7775) Signed-off-by: Ashish Singh <[email protected]>
6 tasks
stephen-crawford
pushed a commit
to stephen-crawford/OpenSearch
that referenced
this pull request
May 31, 2023
…ct#7775) Signed-off-by: Ashish Singh <[email protected]>
andrross
pushed a commit
that referenced
this pull request
May 31, 2023
…7838) * [Remote Store] Fix shards condition in stats api (#7739) Signed-off-by: Ashish Singh <[email protected]> * Fix remote store stats api rejection count response (#7775) Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Jun 2, 2023
…ct#7775) Signed-off-by: Ashish Singh <[email protected]>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…7739) & (opensearch-project#7774) (opensearch-project#7838) * [Remote Store] Fix shards condition in stats api (opensearch-project#7739) Signed-off-by: Ashish Singh <[email protected]> * Fix remote store stats api rejection count response (opensearch-project#7775) Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…ct#7775) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Backport to 2.x branch
skip-changelog
Storage:Durability
Issues and PRs related to the durability framework
v2.8.0
'Issues and PRs related to version v2.8.0'
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
backpressure_rejection_count
field in the_remotestore/stats/{index}
api response was coming to be zero always. The issue is narrowed to the missing code of incrementing the global rejection counter when the remote segment backpressure framework rejects a write request. In the PR, we have fixed the issue.Related Issues
Resolves #7774
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.