-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remote Store] Fix shards condition in stats api #7739
Merged
gbbafna
merged 2 commits into
opensearch-project:main
from
ashking94:fix-remotestore-stats-api
May 29, 2023
Merged
[Remote Store] Fix shards condition in stats api #7739
gbbafna
merged 2 commits into
opensearch-project:main
from
ashking94:fix-remotestore-stats-api
May 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashking94
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
May 24, 2023 19:07
linuxpi
approved these changes
May 24, 2023
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7739 +/- ##
============================================
+ Coverage 70.67% 70.81% +0.13%
- Complexity 56095 56195 +100
============================================
Files 4680 4680
Lines 266079 266080 +1
Branches 39074 39074
============================================
+ Hits 188062 188435 +373
+ Misses 62029 61644 -385
- Partials 15988 16001 +13
|
Signed-off-by: Ashish Singh <[email protected]>
ashking94
force-pushed
the
fix-remotestore-stats-api
branch
from
May 24, 2023 19:51
01b1996
to
02079a8
Compare
Gradle Check (Jenkins) Run Completed with:
|
PR description does not provide details on what we are changing. Please add 1-2 lines for the same. |
sachinpkale
approved these changes
May 25, 2023
Signed-off-by: Ashish Singh <[email protected]>
6 tasks
Gradle Check (Jenkins) Run Completed with:
|
ashking94
changed the title
Fix shards condition in TransportRemoteStoreStatsAction
[Remote Store] Fix shards condition in stats api
May 27, 2023
gbbafna
approved these changes
May 29, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 29, 2023
Signed-off-by: Ashish Singh <[email protected]> (cherry picked from commit 7f5a378) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashking94
added a commit
to ashking94/OpenSearch
that referenced
this pull request
May 31, 2023
…7739) Signed-off-by: Ashish Singh <[email protected]>
6 tasks
stephen-crawford
pushed a commit
to stephen-crawford/OpenSearch
that referenced
this pull request
May 31, 2023
…7739) Signed-off-by: Ashish Singh <[email protected]>
andrross
pushed a commit
that referenced
this pull request
May 31, 2023
…7838) * [Remote Store] Fix shards condition in stats api (#7739) Signed-off-by: Ashish Singh <[email protected]> * Fix remote store stats api rejection count response (#7775) Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
austintlee
pushed a commit
to austintlee/OpenSearch
that referenced
this pull request
Jun 2, 2023
…7739) Signed-off-by: Ashish Singh <[email protected]>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…7739) & (opensearch-project#7774) (opensearch-project#7838) * [Remote Store] Fix shards condition in stats api (opensearch-project#7739) Signed-off-by: Ashish Singh <[email protected]> * Fix remote store stats api rejection count response (opensearch-project#7775) Signed-off-by: Ashish Singh <[email protected]> --------- Signed-off-by: Ashish Singh <[email protected]>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…7739) Signed-off-by: Ashish Singh <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remote store stats api returns no response if coordinator node does not contain remote enabled shard
If lets say we have 3 nodes - N1, N2 and N3 and there is remote store enabled index index1 with 1 shard (on N1) and 0 replica, then if we call remotestore stats api on N1, it returns the stats. If we call the api on N2 or N3, it returns empty result.
In this PR, we check the index setting by reading the cluster state since the indicesService does not hold the shards that don't reside on underlying coordinator node.
Related Issues
Resolves #7738
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.