-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Remove] Remaining Flavor Serialization #1751
Merged
nknize
merged 3 commits into
opensearch-project:main
from
nknize:remove/remainingFlavor
Dec 16, 2021
Merged
[Remove] Remaining Flavor Serialization #1751
nknize
merged 3 commits into
opensearch-project:main
from
nknize:remove/remainingFlavor
Dec 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes unnecessary serialization of unused flavor variable in build metadata from V_1_3_0+ Signed-off-by: Nicholas Walter Knize <[email protected]>
nknize
added
v2.0.0
Version 2.0.0
non-issue
bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues
backwards-compatibility
labels
Dec 16, 2021
Signed-off-by: Nicholas Walter Knize <[email protected]>
Can one of the admins verify this patch? |
Signed-off-by: Nicholas Walter Knize <[email protected]>
dblock
approved these changes
Dec 16, 2021
reta
approved these changes
Dec 16, 2021
nknize
added
the
pending backport
Identifies an issue or PR that still needs to be backported
label
Dec 16, 2021
nknize
added a commit
to nknize/OpenSearch
that referenced
this pull request
Dec 16, 2021
This commit removes unnecessary serialization of unused flavor variable in build metadata from V_1_3_0+ Signed-off-by: Nicholas Walter Knize <[email protected]>
saratvemulapalli
pushed a commit
that referenced
this pull request
Jan 6, 2022
* [Remove] Remaining Flavor Serialization (#1751) This commit removes unnecessary serialization of unused flavor variable in build metadata from V_1_3_0+ Signed-off-by: Nicholas Walter Knize <[email protected]> * change flavor version check to V_1_3_0 This commit changes the flavor serialization check in Build from V_2_0_0 to V_1_3_0. Signed-off-by: Nicholas Walter Knize <[email protected]>
This was referenced Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backwards-compatibility
non-issue
bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues
pending backport
Identifies an issue or PR that still needs to be backported
v2.0.0
Version 2.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary serialization of unused flavor variable in build
metadata from V_1_3_0+. This will need to be backported to ensure bwc tests do not fail.