Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] Remaining Flavor Serialization #1751

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Dec 16, 2021

This PR removes unnecessary serialization of unused flavor variable in build
metadata from V_1_3_0+. This will need to be backported to ensure bwc tests do not fail.

This commit removes unnecessary serialization of unused flavor variable in build
metadata from V_1_3_0+

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize nknize added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues backwards-compatibility labels Dec 16, 2021
@nknize nknize requested a review from a team as a code owner December 16, 2021 21:06
Signed-off-by: Nicholas Walter Knize <[email protected]>
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 120fe80
Log 1547

Reports 1547

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success d3ad148
Log 1548

Reports 1548

@nknize nknize merged commit 8c2d8f5 into opensearch-project:main Dec 16, 2021
@nknize nknize added the pending backport Identifies an issue or PR that still needs to be backported label Dec 16, 2021
nknize added a commit to nknize/OpenSearch that referenced this pull request Dec 16, 2021
This commit removes unnecessary serialization of unused flavor variable in build
metadata from V_1_3_0+

Signed-off-by: Nicholas Walter Knize <[email protected]>
saratvemulapalli pushed a commit that referenced this pull request Jan 6, 2022
* [Remove] Remaining Flavor Serialization (#1751)

This commit removes unnecessary serialization of unused flavor variable in build
metadata from V_1_3_0+

Signed-off-by: Nicholas Walter Knize <[email protected]>

* change flavor version check to V_1_3_0

This commit changes the flavor serialization check in Build from V_2_0_0 to
V_1_3_0.

Signed-off-by: Nicholas Walter Knize <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-compatibility non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues pending backport Identifies an issue or PR that still needs to be backported v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants