-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Remove remaining Flavor Serialization (#1751) #1757
[1.x] Remove remaining Flavor Serialization (#1751) #1757
Conversation
This commit removes unnecessary serialization of unused flavor variable in build metadata from V_1_3_0+ Signed-off-by: Nicholas Walter Knize <[email protected]>
This commit changes the flavor serialization check in Build from V_2_0_0 to V_1_3_0. Signed-off-by: Nicholas Walter Knize <[email protected]>
Can one of the admins verify this patch? |
@@ -215,8 +214,8 @@ public static Build readBuild(StreamInput in) throws IOException { | |||
// TODO - clean this up when OSS flavor is removed in all of the code base | |||
// (Integ test zip still write OSS as distribution) | |||
// See issue: https://github.com/opendistro-for-elasticsearch/search/issues/159 | |||
if (in.getVersion().onOrAfter(LegacyESVersion.V_6_3_0)) { | |||
flavor = in.readString(); | |||
if (in.getVersion().onOrAfter(LegacyESVersion.V_6_3_0) && in.getVersion().before(Version.V_1_3_0)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to understand, can we just simply use Version.CURRENT
?
It helps us avoid code changes after each bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BWC testing would fail... This is for reading off the wire from remote nodes between 6.3.0 and 1.3.0 excluded. (that covers all 1.2.x versions but 1.3.0 does not send flavor).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THat makes sense. Thank you!
This PR removes unnecessary serialization of unused flavor variable in build metadata from V_1_3_0+