Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove oss flavor #239

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky [email protected]

Description

Removes unnecessary -oss flavor from build.gradle. OpenSearch exported oss flavor flag until now (all versions up to 1.3.0) and will remove it after. opensearch-project/OpenSearch#1751

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz amitgalitz requested a review from a team March 22, 2022 22:01
@amitgalitz
Copy link
Member Author

Flaky test on first workflow run, documented here: #241. Passes after re-running

Copy link
Collaborator

@ylwu-amzn ylwu-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the change

@ylwu-amzn ylwu-amzn merged commit 81633de into opensearch-project:main Mar 22, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 22, 2022
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 81633de)
amitgalitz added a commit that referenced this pull request Mar 22, 2022
Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 81633de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants