Java high-level REST client bulk() is not respecting the bulkRequest.requireAlias(true) method call #14136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng requireAlias flag Signed-off-by: Parv Kapadia <[email protected]>
parv0201
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
Signed-off-by: Parv Kapadia <[email protected]>
|
Thank you @parv0201 ! |
|
❌ Gradle check result for 4afcc30: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for ae3537e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@parv0201 could you please rebase against latest |
…ng fetch… (opensearch-project#12503)" (opensearch-project#13486) This reverts commit da5b205. Signed-off-by: Andriy Redko <[email protected]>
…on (opensearch-project#13322) Signed-off-by: Lakshya Taragi <[email protected]>
* Query-level resource usages tracking Signed-off-by: Chenyang Ji <[email protected]> * Moving TaskResourceTrackingService to clusterService Signed-off-by: Chenyang Ji <[email protected]> * use shard response header to piggyback task resource usages Signed-off-by: Chenyang Ji <[email protected]> * split changes for query insights plugin Signed-off-by: Chenyang Ji <[email protected]> * improve the supplier logic and other misc items Signed-off-by: Chenyang Ji <[email protected]> * track resource usage for failed requests Signed-off-by: Chenyang Ji <[email protected]> * move resource usages interactions into TaskResourceTrackingService Signed-off-by: Chenyang Ji <[email protected]> --------- Signed-off-by: Chenyang Ji <[email protected]>
These are very frequent offenders and are causing a lot of pain in CI. Related issues: - opensearch-project#11374 - opensearch-project#12308 - opensearch-project#13540 - opensearch-project#13503 - opensearch-project#13711 - opensearch-project#13949 - opensearch-project#13437 - opensearch-project#13600 Signed-off-by: Andrew Ross <[email protected]>
…ote store (opensearch-project#13834) * Implementation of RemoteWritableEntity for objects to uploaded to remote store Signed-off-by: Sooraj Sinha <[email protected]>
* Blobstore transfer of cluster metadata from the underlying input stream Signed-off-by: Sooraj Sinha <[email protected]>
…art of opensearch-project#12333 (opensearch-project#13926) * Retaining the old constructors for classes marked as API changed as part of opensearch-project#12333 --------- Signed-off-by: Harsh Garg <[email protected]> Co-authored-by: Harsh Garg <[email protected]>
Signed-off-by: Gaurav Bafna <[email protected]>
…tainer (opensearch-project#14030) Signed-off-by: Sandeep Kumawat <[email protected]>
…roject#13994) * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds support to provide tags with value in Gauge metric Signed-off-by: Gagan Juneja <[email protected]> * Adds build issue Signed-off-by: Gagan Juneja <[email protected]> * Fix compilation issue Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> * Empty-Commit Signed-off-by: Gagan Juneja <[email protected]> --------- Signed-off-by: Gagan Juneja <[email protected]> Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]>
* Move Remote Store Migration from DocRep to GA. Modify remote store migration setting name. Signed-off-by: Gaurav Bafna <[email protected]> * Modify changelog Signed-off-by: Gaurav Bafna <[email protected]> * fixing a test Signed-off-by: Gaurav Bafna <[email protected]> --------- Signed-off-by: Gaurav Bafna <[email protected]>
…dOnSameNode (opensearch-project#14090) Signed-off-by: kkewwei [email protected] Signed-off-by: kkewwei [email protected] Signed-off-by: kkewwei <[email protected]>
…ility (opensearch-project#14123) Signed-off-by: Harsh Garg <[email protected]> Co-authored-by: Harsh Garg <[email protected]>
…ct#14084) Signed-off-by: Chenyang Ji <[email protected]>
Signed-off-by: Shubh Sahu <[email protected]>
* Create serde utility for Writable classes Signed-off-by: Sooraj Sinha <[email protected]>
* Add remote state publication transport call Signed-off-by: Sooraj Sinha <[email protected]> * Add publication flag and remote routing table check Signed-off-by: Himshikha Gupta <[email protected]>
…s/repository-azure (opensearch-project#14128) * Bump com.azure:azure-core-http-netty in /plugins/repository-azure Bumps [com.azure:azure-core-http-netty](https://github.com/Azure/azure-sdk-for-java) from 1.12.8 to 1.15.1. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-core-http-netty_1.12.8...azure-core-http-netty_1.15.1) --- updated-dependencies: - dependency-name: com.azure:azure-core-http-netty dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Updating SHAs Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Andriy Redko <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Removing second use of the `frequentyl()` function. This function is alraedy used in the beginning of the testing block immediately after the declaration of `jvmStats` variable. The second use of the `frequently()` could cause all the other variables that were carefully prepared for the constructor to not be used at all. Signed-off-by: Lukáš Vlček <[email protected]>
…ct#14126) * Bump tim-actions/get-pr-commits from 1.1.0 to 1.3.1 Bumps [tim-actions/get-pr-commits](https://github.com/tim-actions/get-pr-commits) from 1.1.0 to 1.3.1. - [Release notes](https://github.com/tim-actions/get-pr-commits/releases) - [Commits](tim-actions/get-pr-commits@v1.1.0...v1.3.1) --- updated-dependencies: - dependency-name: tim-actions/get-pr-commits dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update changelog Signed-off-by: dependabot[bot] <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
|
@parv0201 uh, something went really not well ... |
github-actions
bot
added
bug
|
I have opened new Pull Request for this change - #14146 |
|
❌ Gradle check result for 589e751: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Java high-level REST client bulk() is not respecting the bulkRequest.requireAlias(true) method call
Related Issues
Resolves #12958
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.