Java high-level REST client bulk() is not respecting the bulkRequest.requireAlias(true) method call #14146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng requireAlias flag Signed-off-by: Parv Kapadia <[email protected]>
Signed-off-by: Parv Kapadia <[email protected]>
parv0201
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
github-actions
bot
added
bug
Signed-off-by: Parv Kapadia <[email protected]>
3 tasks
dblock
reviewed
Jun 10, 2024
There was a problem hiding this comment.
Thanks. Since we're deprecating this stuff in favor of opensearch-java, and if you have time, check that requireAlias is properly implemented in https://github.com/opensearch-project/opensearch-api-specification and https://github.com/opensearch-project/opensearch-java pls.
client/rest-high-level/src/main/java/org/opensearch/client/RequestConverters.java
Show resolved
Hide resolved
|
❌ Gradle check result for 4828958: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
dblock
reviewed
Jun 10, 2024
client/rest-high-level/src/main/java/org/opensearch/client/RequestConverters.java
Show resolved
Hide resolved
dblock
approved these changes
Jun 11, 2024
org.opensearch.action.admin.indices.create.RemoteSplitIndexIT.classMethod |
reta
added
v3.0.0
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-14146-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 40f11b3291f9f6ccf6ecfceb61ac1f5694f5867a
# Push it to GitHub
git push --set-upstream origin backport/backport-14146-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
|
@parv0201 could you please send manual backport pull request towards |
reta
pushed a commit
to reta/OpenSearch
that referenced
this pull request
Jun 11, 2024
…requireAlias(true) method call (opensearch-project#14146) * Issue 12958 | Updated bulk api for Rest HighLevel Client for respecting requireAlias flag Signed-off-by: Parv Kapadia <[email protected]> * Issue 12958 | Updated changelog Signed-off-by: Parv Kapadia <[email protected]> * Updated changelog with correct PR number Signed-off-by: Parv Kapadia <[email protected]> --------- Signed-off-by: Parv Kapadia <[email protected]> (cherry picked from commit 40f11b3)
reta
pushed a commit
to reta/OpenSearch
that referenced
this pull request
Jun 11, 2024
…requireAlias(true) method call (opensearch-project#14146) * Issue 12958 | Updated bulk api for Rest HighLevel Client for respecting requireAlias flag Signed-off-by: Parv Kapadia <[email protected]> * Issue 12958 | Updated changelog Signed-off-by: Parv Kapadia <[email protected]> * Updated changelog with correct PR number Signed-off-by: Parv Kapadia <[email protected]> --------- Signed-off-by: Parv Kapadia <[email protected]> (cherry picked from commit 40f11b3) Signed-off-by: Andriy Redko <[email protected]>
reta
pushed a commit
to reta/OpenSearch
that referenced
this pull request
Jun 11, 2024
…requireAlias(true) method call (opensearch-project#14146) * Issue 12958 | Updated bulk api for Rest HighLevel Client for respecting requireAlias flag Signed-off-by: Parv Kapadia <[email protected]> * Issue 12958 | Updated changelog Signed-off-by: Parv Kapadia <[email protected]> * Updated changelog with correct PR number Signed-off-by: Parv Kapadia <[email protected]> --------- Signed-off-by: Parv Kapadia <[email protected]> (cherry picked from commit 40f11b3) Signed-off-by: Andriy Redko <[email protected]>
reta
added a commit
that referenced
this pull request
Jun 11, 2024
…requireAlias(true) method call (#14146) (#14184) * Issue 12958 | Updated bulk api for Rest HighLevel Client for respecting requireAlias flag * Issue 12958 | Updated changelog * Updated changelog with correct PR number --------- (cherry picked from commit 40f11b3) Signed-off-by: Parv Kapadia <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: parv0201 <[email protected]>
This was referenced Jun 13, 2024
3 tasks
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…requireAlias(true) method call (opensearch-project#14146) (opensearch-project#14184) * Issue 12958 | Updated bulk api for Rest HighLevel Client for respecting requireAlias flag * Issue 12958 | Updated changelog * Updated changelog with correct PR number --------- (cherry picked from commit 40f11b3) Signed-off-by: Parv Kapadia <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: parv0201 <[email protected]> Signed-off-by: kkewwei <[email protected]>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…requireAlias(true) method call (opensearch-project#14146) * Issue 12958 | Updated bulk api for Rest HighLevel Client for respecting requireAlias flag Signed-off-by: Parv Kapadia <[email protected]> * Issue 12958 | Updated changelog Signed-off-by: Parv Kapadia <[email protected]> * Updated changelog with correct PR number Signed-off-by: Parv Kapadia <[email protected]> --------- Signed-off-by: Parv Kapadia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Java high-level REST client bulk() is not respecting the bulkRequest.requireAlias(true) method call
Related Issues
Resolves #12958
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.