Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused fetch sub phase processor initialization during fetch… #12503

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

jainankitk
Copy link
Collaborator

@jainankitk jainankitk commented Mar 1, 2024

… phase execution

Description

Prevent initialization of unused fetch sub phase processor initialization during fetch phase execution

Related Issues

Resolves #12502

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Compatibility status:

Checks if related components are compatible with change 2bd910e

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Mar 1, 2024

❌ Gradle check result for a742967: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 2bd910e: SUCCESS

@reta reta self-requested a review March 13, 2024 23:12
@reta reta merged commit da5b205 into opensearch-project:main Mar 13, 2024
32 of 33 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Mar 13, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12503-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da5b2053864f24dcb3b8c555a9fd19e0d91a14e6
# Push it to GitHub
git push --set-upstream origin backport/backport-12503-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12503-to-2.x.

@reta
Copy link
Collaborator

reta commented Mar 13, 2024

@jainankitk could you please backport manually to 2.x? thank you

jainankitk added a commit to jainankitk/OpenSearch that referenced this pull request Mar 14, 2024
opensearch-project#12503)

* Removing unused fetch sub phase processor initialization during fetch phase execution

Signed-off-by: Ankit Jain <[email protected]>

* Updating CHANGELOG.md with the bug fix

Signed-off-by: Ankit Jain <[email protected]>

* Fixing smoke test failures

Signed-off-by: Ankit Jain <[email protected]>

* Addressing review comments

Signed-off-by: Ankit Jain <[email protected]>

* Addressing review comments around boolean check convention

Signed-off-by: Ankit Jain <[email protected]>

---------

Signed-off-by: Ankit Jain <[email protected]>
(cherry picked from commit da5b205)
@jainankitk jainankitk deleted the os-12502 branch March 14, 2024 06:08
andrross pushed a commit that referenced this pull request Mar 14, 2024
…on during fetch… (#12654)

* Removing unused fetch sub phase processor initialization during fetch… (#12503)

* Removing unused fetch sub phase processor initialization during fetch phase execution

Signed-off-by: Ankit Jain <[email protected]>

* Updating CHANGELOG.md with the bug fix

Signed-off-by: Ankit Jain <[email protected]>

* Fixing smoke test failures

Signed-off-by: Ankit Jain <[email protected]>

* Addressing review comments

Signed-off-by: Ankit Jain <[email protected]>

* Addressing review comments around boolean check convention

Signed-off-by: Ankit Jain <[email protected]>

---------

Signed-off-by: Ankit Jain <[email protected]>
(cherry picked from commit da5b205)

* Removing unintended CHANGELOG issue

Signed-off-by: Ankit Jain <[email protected]>

---------

Signed-off-by: Ankit Jain <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
opensearch-project#12503)

* Removing unused fetch sub phase processor initialization during fetch phase execution

Signed-off-by: Ankit Jain <[email protected]>

* Updating CHANGELOG.md with the bug fix

Signed-off-by: Ankit Jain <[email protected]>

* Fixing smoke test failures

Signed-off-by: Ankit Jain <[email protected]>

* Addressing review comments

Signed-off-by: Ankit Jain <[email protected]>

* Addressing review comments around boolean check convention

Signed-off-by: Ankit Jain <[email protected]>

---------

Signed-off-by: Ankit Jain <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
opensearch-project#12503)

* Removing unused fetch sub phase processor initialization during fetch phase execution

Signed-off-by: Ankit Jain <[email protected]>

* Updating CHANGELOG.md with the bug fix

Signed-off-by: Ankit Jain <[email protected]>

* Fixing smoke test failures

Signed-off-by: Ankit Jain <[email protected]>

* Addressing review comments

Signed-off-by: Ankit Jain <[email protected]>

* Addressing review comments around boolean check convention

Signed-off-by: Ankit Jain <[email protected]>

---------

Signed-off-by: Ankit Jain <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
reta added a commit to reta/OpenSearch that referenced this pull request May 1, 2024
reta added a commit to reta/OpenSearch that referenced this pull request May 1, 2024
reta added a commit that referenced this pull request May 1, 2024
…ng fetch… (#12503)" (#13486)

This reverts commit da5b205.

Signed-off-by: Andriy Redko <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2024
…ng fetch… (#12503)" (#13486)

This reverts commit da5b205.

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 5133e5f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 1, 2024
…ng fetch… (#12503)" (#13486)

This reverts commit da5b205.

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 5133e5f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request May 1, 2024
…ng fetch… (#12503)" (#13486)

This reverts commit da5b205.

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 5133e5f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <[email protected]>
reta pushed a commit that referenced this pull request May 1, 2024
…ng fetch… (#12503)" (#13486)

This reverts commit da5b205.

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 5133e5f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <[email protected]>
reta added a commit that referenced this pull request May 2, 2024
…tialization during fetch… (#12503)" (#13492)

* Revert "Removing unused fetch sub phase processor initialization during fetch… (#12503)" (#13486)

This reverts commit da5b205.

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 5133e5f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <[email protected]>

* Update 400_inner_hits.yml

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <[email protected]>
reta added a commit that referenced this pull request May 2, 2024
…ialization during fetch… (#12503)" (#13491)

* Revert "Removing unused fetch sub phase processor initialization during fetch… (#12503)" (#13486)

This reverts commit da5b205.

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 5133e5f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <[email protected]>

* Update 400_inner_hits.yml

Signed-off-by: Andriy Redko <[email protected]>

---------

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <[email protected]>
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed bug Something isn't working Search:Performance v2.13.0 Issues and PRs related to version 2.13.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BUG] Unused fetch sub phase processors initialized during fetch phase
3 participants