feat: add config for topRightNavigation #6712

raintygao · 2024-05-03T16:00:56Z

Description

Add opensearchDashboards.futureNavigation config and control dev tool top right nav button.
Mark rightNavigationButton component as experimental.

Screenshot

futureNavigation disabled by default

futureNavigation enabled

Testing the changes

By default or add opensearchDashboards.futureNavigation: false in yml file, top right navigation will not display.
add opensearchDashboards.futureNavigation: true in yml file, top right navigation will display.

Changelog

feat: Add opensearchDashboards.futureNavigation config to control dev tool top right nav button.

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

github-actions · 2024-05-03T16:01:30Z

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

codecov · 2024-05-03T16:17:46Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.64%. Comparing base (b830fe1) to head (a7d2107).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6712      +/-   ##
==========================================
- Coverage   67.66%   67.64%   -0.03%     
==========================================
  Files        3417     3417              
  Lines       66941    66941              
  Branches    10892    10892              
==========================================
- Hits        45297    45283      -14     
- Misses      18991    19004      +13     
- Partials     2653     2654       +1

Flag	Coverage Δ
Linux_1	`33.16% <ø> (ø)`
Linux_2	`55.59% <ø> (ø)`
Linux_3	`45.22% <ø> (+<0.01%)`	⬆️
Linux_4	`34.82% <ø> (ø)`
Windows_2	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ananzh · 2024-05-03T16:21:50Z

src/plugins/console/server/plugin.ts

@@ -66,10 +71,6 @@ export class ConsoleServerPlugin implements Plugin<ConsoleSetup, ConsoleStart> {
      });
    });

-    const config = await this.ctx.config.create().pipe(first()).toPromise();


Why we del this part?

Have been moved to top.

Oh I see. Thanks.

kavilla

have we looked into ui settings? might be a little easier.

kavilla · 2024-05-04T11:02:11Z

changelogs/fragments/6712.yml

@@ -0,0 +1,2 @@
+feat:
+- Add config for topRightNavigation ([#6712](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6712))


nit i would update the pr changelog to include the actual configuration and specify the dev tool top right nav button

Thank you, updated.

kavilla · 2024-05-04T11:06:19Z

src/core/server/opensearch_dashboards_config.ts

@@ -91,6 +91,7 @@ export const config = {
        defaultValue: 'https://survey.opensearch.org',
      }),
    }),
+    topRightNavigation: schema.boolean({ defaultValue: false }),


nit: topRightNav* matches other references

Should I update the name of configuration? Do you have any recommendations for that?

raintygao · 2024-05-04T11:14:01Z

have we looked into ui settings? might be a little easier.

Thanks. That looks easier. But here feel like that we more need some configuration to be a role of feature flag. Like workspace feature flag.

Signed-off-by: tygao <[email protected]>

raintygao · 2024-05-06T02:08:47Z

Seems failing test is the same as main after merging it. https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/8954435518/job/24594081770

ashwin-pc

A few questions:

Why was this API introduced?
Cant the same feature flag that introduced this feature be used to turn this off?
Can we mark this API as experimental. The very existence of this PR suggests that its not clear if we even want to go with this approach.

ashwin-pc · 2024-05-06T06:46:19Z

Spoke to @raintygao offline:

There wasnt a new API introduced, but rather a component RightNavigationButton (PR). This I think should be marked as experimental since I can see this being more general with simpler props and needs a bit of discussion
The topRightNavigation feature is being introduced as a part of a bigger change to improve the navigation. This however currently isnt something everyone aligns on. Since only the dev tools icon uses this, we can use the workspaces feature flag to gate this for 2.14 since its a release blocker and reconsider what the correct config flag needs to be long term for 2.15.

These two changes should unblock this PR.

Signed-off-by: tygao <[email protected]>

opensearch-trigger-bot · 2024-05-07T02:34:37Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6712-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c09285c24703f9015d811f76bcd026061b705398
# Push it to GitHub
git push --set-upstream origin backport/backport-6712-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6712-to-2.x.

opensearch-trigger-bot · 2024-05-07T02:34:39Z

The backport to 2.14 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.14 2.14
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.14
# Create a new branch
git switch --create backport/backport-6712-to-2.14
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c09285c24703f9015d811f76bcd026061b705398
# Push it to GitHub
git push --set-upstream origin backport/backport-6712-to-2.14
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.14

Then, create a pull request where the base branch is 2.14 and the compare/head branch is backport/backport-6712-to-2.14.

kavilla · 2024-05-07T23:35:49Z

manual backport made here: #6727
#6728

* feat: add config for topRightNavigation Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * Changeset file for PR opensearch-project#6712 created/updated * test: update context test Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * update changeset Signed-off-by: tygao <[email protected]> * update joi default value Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: yujin-emma <[email protected]>

@zhyuanqi

) * adjust the aggregated view padding Signed-off-by: yujin-emma <[email protected]> * WIP Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx Co-authored-by: Xinrui Bai-amazon <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6715 created/updated Signed-off-by: yujin-emma <[email protected]> * Update CHANGELOG.md Signed-off-by: yujin-emma <[email protected]> * [saved objects] enable deletion of saved objects by type if configured (#6443) * [saved objects] enable deletion of saved objects by type if configured Adds the following settings: ``` migrations.delete.enabled migrations.delete.types ``` `unknown` types already exist but the purpose of this type is for plugins that are disabled. OpenSearch Dashboards gets confused when a plugin is not defining a saved object type but the saved object exists. This can occur when migrating from a non-OSD version and there exists non-compatiable saved objects. If OSD is failing to migrate an index because of a document, I can now configure OSD to delete types of saved objects that I specified because I know that these types should not be carried over. resolves: #1040 Signed-off-by: Kawika Avilla <[email protected]> * address comments Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #6443 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [tests] fix tests related to #6443 (#6722) * [tests] fix tests related to #6443 PR: 6443 merged in previous PR that had an immediate follow up PR to that PR. But the followup pr was not merged into 6443. The snapshots got updated to ensure the CI passed for 6443. But once merged into main, failures were observed. Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #6722 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * feat: add config for topRightNavigation (#6712) * feat: add config for topRightNavigation Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * Changeset file for PR #6712 created/updated * test: update context test Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * update changeset Signed-off-by: tygao <[email protected]> * update joi default value Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: yujin-emma <[email protected]> * move the css to the data source aggregated view Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]add more test for icon and aggregated view (#6729) * add more test for icon and aggregated view Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6729 created/updated * Update CHANGELOG.md --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * update css file space and use the oui color guideline number to replace the color name in css file Signed-off-by: yujin-emma <[email protected]> * [OSD Availability] Prevent OSD process crashes when disk is full (#6733) * prevent crash when disk full Signed-off-by: Flyingliuhub <[email protected]> * change verbose to false Signed-off-by: Flyingliuhub <[email protected]> * add changeset file Signed-off-by: Flyingliuhub <[email protected]> * update changeset contexts Signed-off-by: Flyingliuhub <[email protected]> * change feature flag name Signed-off-by: Flyingliuhub <[email protected]> --------- Signed-off-by: Flyingliuhub <[email protected]> Co-authored-by: ZilongX <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [MDS] Modify toast + popover warning to include incompatible datasources (#6678) * Fix merge conflict Signed-off-by: Huy Nguyen <[email protected]> * Refactor to incompatibleDataSourcesExist Signed-off-by: Huy Nguyen <[email protected]> * Changeset file for PR #6678 created/updated * Move required args to the top Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752) * add test for data_source_error_menu, data_source_item, data_source_multi_selectable Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6752 created/updated * add content verify in test Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [2.14][chore] update release notes (#6705) Updates releases notes. Partially populated with: yarn release_note:generate And gathered the rest. Cleaned up changelog. related to: #6254 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add http://www.site.com to lycheeignore (#6771) * add http://www.site.com to lycheeignore Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6771 created/updated * Update .lycheeignore Co-authored-by: Miki <[email protected]> Signed-off-by: Yu Jin <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756) * fix: show a error toast when workspace read only user delete saved objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #6756 created/updated * Changeset file for PR #6756 created/updated * optimize the code Signed-off-by: yubonluo <[email protected]> * Display the delete modal after failing to delete. Signed-off-by: yubonluo <[email protected]> * Add some unit tests Signed-off-by: yubonluo <[email protected]> * Add some state assertions Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Updating security reachout email (#6778) Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add @zhyuanqi as a maintainer (#6788) * add @zhyuanqi as a maintainer --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [OE] Adds dev doc script to precommit hook (#6585) * Adds doc generation to pre commit hook Signed-off-by: Ashwin P Chandran <[email protected]> * Add check hook to pre commit Signed-off-by: Ashwin P Chandran <[email protected]> * Changeset file for PR #6585 created/updated * Update error message Signed-off-by: Ashwin P Chandran <[email protected]> * Improve error message Co-authored-by: Miki <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> * fixes lint issue Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Move @BSFishy to emeritus maintainer (#6790) * Move @BSFishy to emeritus maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6790 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * add @mengweieric as maintainer (#6798) * add @mengweieric as maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6798 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Add OpenAPI specification for get and create saved object APIs (#6799) * add openapi doc Signed-off-by: Lu Yu <[email protected]> * add readme Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6799 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]Add test for toast button and validation form (#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Flyingliuhub <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: yubonluo <[email protected]> Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Xinrui Bai-amazon <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: tygao <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Tao Liu <[email protected]> Co-authored-by: ZilongX <[email protected]> Co-authored-by: Huy Nguyen <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Varun Lodaya <[email protected]> Co-authored-by: Lu Yu <[email protected]>

@zhyuanqi

) * adjust the aggregated view padding Signed-off-by: yujin-emma <[email protected]> * WIP Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx Co-authored-by: Xinrui Bai-amazon <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6715 created/updated Signed-off-by: yujin-emma <[email protected]> * Update CHANGELOG.md Signed-off-by: yujin-emma <[email protected]> * [saved objects] enable deletion of saved objects by type if configured (#6443) * [saved objects] enable deletion of saved objects by type if configured Adds the following settings: ``` migrations.delete.enabled migrations.delete.types ``` `unknown` types already exist but the purpose of this type is for plugins that are disabled. OpenSearch Dashboards gets confused when a plugin is not defining a saved object type but the saved object exists. This can occur when migrating from a non-OSD version and there exists non-compatiable saved objects. If OSD is failing to migrate an index because of a document, I can now configure OSD to delete types of saved objects that I specified because I know that these types should not be carried over. resolves: #1040 Signed-off-by: Kawika Avilla <[email protected]> * address comments Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #6443 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [tests] fix tests related to #6443 (#6722) * [tests] fix tests related to #6443 PR: 6443 merged in previous PR that had an immediate follow up PR to that PR. But the followup pr was not merged into 6443. The snapshots got updated to ensure the CI passed for 6443. But once merged into main, failures were observed. Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #6722 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * feat: add config for topRightNavigation (#6712) * feat: add config for topRightNavigation Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * Changeset file for PR #6712 created/updated * test: update context test Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * update changeset Signed-off-by: tygao <[email protected]> * update joi default value Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: yujin-emma <[email protected]> * move the css to the data source aggregated view Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]add more test for icon and aggregated view (#6729) * add more test for icon and aggregated view Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6729 created/updated * Update CHANGELOG.md --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * update css file space and use the oui color guideline number to replace the color name in css file Signed-off-by: yujin-emma <[email protected]> * [OSD Availability] Prevent OSD process crashes when disk is full (#6733) * prevent crash when disk full Signed-off-by: Flyingliuhub <[email protected]> * change verbose to false Signed-off-by: Flyingliuhub <[email protected]> * add changeset file Signed-off-by: Flyingliuhub <[email protected]> * update changeset contexts Signed-off-by: Flyingliuhub <[email protected]> * change feature flag name Signed-off-by: Flyingliuhub <[email protected]> --------- Signed-off-by: Flyingliuhub <[email protected]> Co-authored-by: ZilongX <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [MDS] Modify toast + popover warning to include incompatible datasources (#6678) * Fix merge conflict Signed-off-by: Huy Nguyen <[email protected]> * Refactor to incompatibleDataSourcesExist Signed-off-by: Huy Nguyen <[email protected]> * Changeset file for PR #6678 created/updated * Move required args to the top Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752) * add test for data_source_error_menu, data_source_item, data_source_multi_selectable Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6752 created/updated * add content verify in test Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [2.14][chore] update release notes (#6705) Updates releases notes. Partially populated with: yarn release_note:generate And gathered the rest. Cleaned up changelog. related to: #6254 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add http://www.site.com to lycheeignore (#6771) * add http://www.site.com to lycheeignore Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6771 created/updated * Update .lycheeignore Co-authored-by: Miki <[email protected]> Signed-off-by: Yu Jin <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756) * fix: show a error toast when workspace read only user delete saved objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #6756 created/updated * Changeset file for PR #6756 created/updated * optimize the code Signed-off-by: yubonluo <[email protected]> * Display the delete modal after failing to delete. Signed-off-by: yubonluo <[email protected]> * Add some unit tests Signed-off-by: yubonluo <[email protected]> * Add some state assertions Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Updating security reachout email (#6778) Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add @zhyuanqi as a maintainer (#6788) * add @zhyuanqi as a maintainer --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [OE] Adds dev doc script to precommit hook (#6585) * Adds doc generation to pre commit hook Signed-off-by: Ashwin P Chandran <[email protected]> * Add check hook to pre commit Signed-off-by: Ashwin P Chandran <[email protected]> * Changeset file for PR #6585 created/updated * Update error message Signed-off-by: Ashwin P Chandran <[email protected]> * Improve error message Co-authored-by: Miki <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> * fixes lint issue Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Move @BSFishy to emeritus maintainer (#6790) * Move @BSFishy to emeritus maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6790 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * add @mengweieric as maintainer (#6798) * add @mengweieric as maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6798 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Add OpenAPI specification for get and create saved object APIs (#6799) * add openapi doc Signed-off-by: Lu Yu <[email protected]> * add readme Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6799 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]Add test for toast button and validation form (#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Flyingliuhub <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: yubonluo <[email protected]> Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Xinrui Bai-amazon <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: tygao <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Tao Liu <[email protected]> Co-authored-by: ZilongX <[email protected]> Co-authored-by: Huy Nguyen <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Varun Lodaya <[email protected]> Co-authored-by: Lu Yu <[email protected]> (cherry picked from commit 9ef7404) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

@zhyuanqi

) (#6896) * adjust the aggregated view padding * WIP * Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx * Changeset file for PR #6715 created/updated * Update CHANGELOG.md * [saved objects] enable deletion of saved objects by type if configured (#6443) * [saved objects] enable deletion of saved objects by type if configured Adds the following settings: ``` migrations.delete.enabled migrations.delete.types ``` `unknown` types already exist but the purpose of this type is for plugins that are disabled. OpenSearch Dashboards gets confused when a plugin is not defining a saved object type but the saved object exists. This can occur when migrating from a non-OSD version and there exists non-compatiable saved objects. If OSD is failing to migrate an index because of a document, I can now configure OSD to delete types of saved objects that I specified because I know that these types should not be carried over. resolves: #1040 * address comments * Changeset file for PR #6443 created/updated --------- * [tests] fix tests related to #6443 (#6722) * [tests] fix tests related to #6443 PR: 6443 merged in previous PR that had an immediate follow up PR to that PR. But the followup pr was not merged into 6443. The snapshots got updated to ensure the CI passed for 6443. But once merged into main, failures were observed. * Changeset file for PR #6722 created/updated --------- * feat: add config for topRightNavigation (#6712) * feat: add config for topRightNavigation * doc: update changelog * Changeset file for PR #6712 created/updated * test: update context test * doc: update changelog * update changeset * update joi default value * add experimental annotation and add futureNavigation configuration * add experimental annotation and add futureNavigation configuration --------- * move the css to the data source aggregated view * [Multiple Datasource Test]add more test for icon and aggregated view (#6729) * add more test for icon and aggregated view * Changeset file for PR #6729 created/updated * Update CHANGELOG.md --------- * update css file space and use the oui color guideline number to replace the color name in css file * [OSD Availability] Prevent OSD process crashes when disk is full (#6733) * prevent crash when disk full * change verbose to false * add changeset file * update changeset contexts * change feature flag name --------- * [MDS] Modify toast + popover warning to include incompatible datasources (#6678) * Fix merge conflict * Refactor to incompatibleDataSourcesExist * Changeset file for PR #6678 created/updated * Move required args to the top --------- * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form * Changeset file for PR #6742 created/updated --------- * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame move language to left, some styling and disable per app name --------- * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive * Changeset file for PR #6759 created/updated --------- * [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752) * add test for data_source_error_menu, data_source_item, data_source_multi_selectable * Changeset file for PR #6752 created/updated * add content verify in test --------- * [2.14][chore] update release notes (#6705) Updates releases notes. Partially populated with: yarn release_note:generate And gathered the rest. Cleaned up changelog. related to: #6254 * add http://www.site.com to lycheeignore (#6771) * add http://www.site.com to lycheeignore * Changeset file for PR #6771 created/updated * Update .lycheeignore --------- * [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756) * fix: show a error toast when workspace read only user delete saved objects * Changeset file for PR #6756 created/updated * Changeset file for PR #6756 created/updated * optimize the code * Display the delete modal after failing to delete. * Add some unit tests * Add some state assertions --------- * Updating security reachout email (#6778) * add @zhyuanqi as a maintainer (#6788) * add @zhyuanqi as a maintainer --------- * [OE] Adds dev doc script to precommit hook (#6585) * Adds doc generation to pre commit hook * Add check hook to pre commit * Changeset file for PR #6585 created/updated * Update error message * Improve error message * fixes lint issue --------- * Move @BSFishy to emeritus maintainer (#6790) * Move @BSFishy to emeritus maintainer * Changeset file for PR #6790 created/updated --------- * add @mengweieric as maintainer (#6798) * add @mengweieric as maintainer * Changeset file for PR #6798 created/updated --------- * Add OpenAPI specification for get and create saved object APIs (#6799) * add openapi doc * add readme * Changeset file for PR #6799 created/updated --------- * [Multiple Datasource Test]Add test for toast button and validation form (#6755) * add test for toast button and validation form * Changeset file for PR #6755 created/updated * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx * Update manage_data_source_button.test.tsx * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form * Changeset file for PR #6742 created/updated --------- * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame move language to left, some styling and disable per app name --------- * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive * Changeset file for PR #6759 created/updated --------- * address naming for manage data source button test id --------- --------- (cherry picked from commit 9ef7404) Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Flyingliuhub <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: yubonluo <[email protected]> Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Xinrui Bai-amazon <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: tygao <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Tao Liu <[email protected]> Co-authored-by: ZilongX <[email protected]> Co-authored-by: Huy Nguyen <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Varun Lodaya <[email protected]> Co-authored-by: Lu Yu <[email protected]>

* feat: add config for topRightNavigation Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * Changeset file for PR opensearch-project#6712 created/updated * test: update context test Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * update changeset Signed-off-by: tygao <[email protected]> * update joi default value Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]>

@zhyuanqi

…ensearch-project#6715) * adjust the aggregated view padding Signed-off-by: yujin-emma <[email protected]> * WIP Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx Co-authored-by: Xinrui Bai-amazon <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6715 created/updated Signed-off-by: yujin-emma <[email protected]> * Update CHANGELOG.md Signed-off-by: yujin-emma <[email protected]> * [saved objects] enable deletion of saved objects by type if configured (opensearch-project#6443) * [saved objects] enable deletion of saved objects by type if configured Adds the following settings: ``` migrations.delete.enabled migrations.delete.types ``` `unknown` types already exist but the purpose of this type is for plugins that are disabled. OpenSearch Dashboards gets confused when a plugin is not defining a saved object type but the saved object exists. This can occur when migrating from a non-OSD version and there exists non-compatiable saved objects. If OSD is failing to migrate an index because of a document, I can now configure OSD to delete types of saved objects that I specified because I know that these types should not be carried over. resolves: opensearch-project#1040 Signed-off-by: Kawika Avilla <[email protected]> * address comments Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR opensearch-project#6443 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [tests] fix tests related to opensearch-project#6443 (opensearch-project#6722) * [tests] fix tests related to opensearch-project#6443 PR: 6443 merged in previous PR that had an immediate follow up PR to that PR. But the followup pr was not merged into 6443. The snapshots got updated to ensure the CI passed for 6443. But once merged into main, failures were observed. Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR opensearch-project#6722 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * feat: add config for topRightNavigation (opensearch-project#6712) * feat: add config for topRightNavigation Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * Changeset file for PR opensearch-project#6712 created/updated * test: update context test Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * update changeset Signed-off-by: tygao <[email protected]> * update joi default value Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: yujin-emma <[email protected]> * move the css to the data source aggregated view Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]add more test for icon and aggregated view (opensearch-project#6729) * add more test for icon and aggregated view Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6729 created/updated * Update CHANGELOG.md --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * update css file space and use the oui color guideline number to replace the color name in css file Signed-off-by: yujin-emma <[email protected]> * [OSD Availability] Prevent OSD process crashes when disk is full (opensearch-project#6733) * prevent crash when disk full Signed-off-by: Flyingliuhub <[email protected]> * change verbose to false Signed-off-by: Flyingliuhub <[email protected]> * add changeset file Signed-off-by: Flyingliuhub <[email protected]> * update changeset contexts Signed-off-by: Flyingliuhub <[email protected]> * change feature flag name Signed-off-by: Flyingliuhub <[email protected]> --------- Signed-off-by: Flyingliuhub <[email protected]> Co-authored-by: ZilongX <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [MDS] Modify toast + popover warning to include incompatible datasources (opensearch-project#6678) * Fix merge conflict Signed-off-by: Huy Nguyen <[email protected]> * Refactor to incompatibleDataSourcesExist Signed-off-by: Huy Nguyen <[email protected]> * Changeset file for PR opensearch-project#6678 created/updated * Move required args to the top Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (opensearch-project#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (opensearch-project#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (opensearch-project#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR opensearch-project#6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (opensearch-project#6752) * add test for data_source_error_menu, data_source_item, data_source_multi_selectable Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6752 created/updated * add content verify in test Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [2.14][chore] update release notes (opensearch-project#6705) Updates releases notes. Partially populated with: yarn release_note:generate And gathered the rest. Cleaned up changelog. related to: opensearch-project#6254 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add http://www.site.com to lycheeignore (opensearch-project#6771) * add http://www.site.com to lycheeignore Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6771 created/updated * Update .lycheeignore Co-authored-by: Miki <[email protected]> Signed-off-by: Yu Jin <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (opensearch-project#6756) * fix: show a error toast when workspace read only user delete saved objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#6756 created/updated * Changeset file for PR opensearch-project#6756 created/updated * optimize the code Signed-off-by: yubonluo <[email protected]> * Display the delete modal after failing to delete. Signed-off-by: yubonluo <[email protected]> * Add some unit tests Signed-off-by: yubonluo <[email protected]> * Add some state assertions Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Updating security reachout email (opensearch-project#6778) Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add @zhyuanqi as a maintainer (opensearch-project#6788) * add @zhyuanqi as a maintainer --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [OE] Adds dev doc script to precommit hook (opensearch-project#6585) * Adds doc generation to pre commit hook Signed-off-by: Ashwin P Chandran <[email protected]> * Add check hook to pre commit Signed-off-by: Ashwin P Chandran <[email protected]> * Changeset file for PR opensearch-project#6585 created/updated * Update error message Signed-off-by: Ashwin P Chandran <[email protected]> * Improve error message Co-authored-by: Miki <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> * fixes lint issue Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Move @BSFishy to emeritus maintainer (opensearch-project#6790) * Move @BSFishy to emeritus maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR opensearch-project#6790 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * add @mengweieric as maintainer (opensearch-project#6798) * add @mengweieric as maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR opensearch-project#6798 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Add OpenAPI specification for get and create saved object APIs (opensearch-project#6799) * add openapi doc Signed-off-by: Lu Yu <[email protected]> * add readme Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR opensearch-project#6799 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]Add test for toast button and validation form (opensearch-project#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (opensearch-project#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (opensearch-project#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (opensearch-project#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR opensearch-project#6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Flyingliuhub <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: yubonluo <[email protected]> Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Xinrui Bai-amazon <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: tygao <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Tao Liu <[email protected]> Co-authored-by: ZilongX <[email protected]> Co-authored-by: Huy Nguyen <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Varun Lodaya <[email protected]> Co-authored-by: Lu Yu <[email protected]>

raintygao requested review from ananzh, kavilla, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT and xinruiba as code owners May 3, 2024 16:00

github-actions bot added the valued-contributor label May 3, 2024

github-actions bot added the failed changeset label May 3, 2024

opensearch-changeset-bot bot added a commit to raintygao/OpenSearch-Dashboards that referenced this pull request May 3, 2024

Changeset file for PR opensearch-project#6712 created/updated

cc6e93d

github-actions bot removed the failed changeset label May 3, 2024

ananzh reviewed May 3, 2024

View reviewed changes

kavilla approved these changes May 4, 2024

View reviewed changes

kavilla reviewed May 4, 2024

View reviewed changes

kavilla previously approved these changes May 4, 2024

View reviewed changes

raintygao dismissed kavilla’s stale review via a1890ce May 4, 2024 11:17

update joi default value

ab8e6c0

Signed-off-by: tygao <[email protected]>

raintygao dismissed SuZhou-Joe’s stale review via ab8e6c0 May 6, 2024 01:26

raintygao requested review from SuZhou-Joe, kavilla and ananzh May 6, 2024 01:26

ashwin-pc requested changes May 6, 2024

View reviewed changes

raintygao added 2 commits May 6, 2024 15:39

add experimental annotation and add futureNavigation configuration

30459d1

Signed-off-by: tygao <[email protected]>

add experimental annotation and add futureNavigation configuration

1459663

Signed-off-by: tygao <[email protected]>

SuZhou-Joe approved these changes May 6, 2024

View reviewed changes

SuZhou-Joe added backport 2.x v2.14.0 backport 2.14 labels May 6, 2024

ashwin-pc approved these changes May 6, 2024

View reviewed changes

Merge branch 'main' into devtool

a7d2107

ashwin-pc merged commit c09285c into opensearch-project:main May 7, 2024
67 checks passed

opensearch-trigger-bot bot added the failed backport label May 7, 2024

This was referenced May 7, 2024

[Manual Backport 2.x] feat: add config for topRightNavigation #6726

Closed

[Manual Backport 2.x] feat: add config for topRightNavigation #6727

Merged

kavilla removed the failed backport label May 7, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add config for topRightNavigation #6712

feat: add config for topRightNavigation #6712

raintygao commented May 3, 2024 •

edited

Loading

github-actions bot commented May 3, 2024

codecov bot commented May 3, 2024 •

edited

Loading

ananzh May 3, 2024

raintygao May 3, 2024

ananzh May 3, 2024

kavilla left a comment

kavilla May 4, 2024

raintygao May 4, 2024

kavilla May 4, 2024

raintygao May 4, 2024

raintygao commented May 4, 2024

raintygao commented May 6, 2024 •

edited

Loading

ashwin-pc left a comment

ashwin-pc commented May 6, 2024

opensearch-trigger-bot bot commented May 7, 2024

opensearch-trigger-bot bot commented May 7, 2024

kavilla commented May 7, 2024 •

edited

Loading

		@@ -0,0 +1,2 @@
		feat:
		- Add config for topRightNavigation ([#6712](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6712))

feat: add config for topRightNavigation #6712

feat: add config for topRightNavigation #6712

Conversation

raintygao commented May 3, 2024 • edited Loading

Description

Screenshot

Testing the changes

Changelog

Check List

github-actions bot commented May 3, 2024

❌ Empty Changelog Section

codecov bot commented May 3, 2024 • edited Loading

Codecov Report

ananzh May 3, 2024

Choose a reason for hiding this comment

raintygao May 3, 2024

Choose a reason for hiding this comment

ananzh May 3, 2024

Choose a reason for hiding this comment

kavilla left a comment

Choose a reason for hiding this comment

kavilla May 4, 2024

Choose a reason for hiding this comment

raintygao May 4, 2024

Choose a reason for hiding this comment

kavilla May 4, 2024

Choose a reason for hiding this comment

raintygao May 4, 2024

Choose a reason for hiding this comment

raintygao commented May 4, 2024

raintygao commented May 6, 2024 • edited Loading

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc commented May 6, 2024

opensearch-trigger-bot bot commented May 7, 2024

opensearch-trigger-bot bot commented May 7, 2024

kavilla commented May 7, 2024 • edited Loading

raintygao commented May 3, 2024 •

edited

Loading

codecov bot commented May 3, 2024 •

edited

Loading

raintygao commented May 6, 2024 •

edited

Loading

kavilla commented May 7, 2024 •

edited

Loading