-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Multiple Query Languages Support #6639
Labels
Comments
7 tasks
7 tasks
kavilla
added a commit
that referenced
this issue
May 9, 2024
Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this issue
May 9, 2024
Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
that referenced
this issue
May 10, 2024
Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. closes #6639 closes #6311 partially resolves: #5504 * add error data frame move language to left, some styling and disable per app name --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
abbyhu2000
added a commit
to abbyhu2000/OpenSearch-Dashboards
that referenced
this issue
May 10, 2024
…pensearch-project#6760) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame move language to left, some styling and disable per app name --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
yujin-emma
pushed a commit
to yujin-emma/OpenSearch-Dashboards
that referenced
this issue
May 10, 2024
Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]>
zhyuanqi
pushed a commit
that referenced
this issue
May 16, 2024
…rm (#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
May 16, 2024
…rm (#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> (cherry picked from commit f728b5a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yujin-emma
pushed a commit
to yujin-emma/OpenSearch-Dashboards
that referenced
this issue
May 16, 2024
Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]>
yujin-emma
added a commit
to yujin-emma/OpenSearch-Dashboards
that referenced
this issue
May 16, 2024
…rm (opensearch-project#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (opensearch-project#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (opensearch-project#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (opensearch-project#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR opensearch-project#6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Signed-off-by: yujin-emma <[email protected]>
BionIT
added a commit
that referenced
this issue
May 17, 2024
) * adjust the aggregated view padding Signed-off-by: yujin-emma <[email protected]> * WIP Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx Co-authored-by: Xinrui Bai-amazon <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6715 created/updated Signed-off-by: yujin-emma <[email protected]> * Update CHANGELOG.md Signed-off-by: yujin-emma <[email protected]> * [saved objects] enable deletion of saved objects by type if configured (#6443) * [saved objects] enable deletion of saved objects by type if configured Adds the following settings: ``` migrations.delete.enabled migrations.delete.types ``` `unknown` types already exist but the purpose of this type is for plugins that are disabled. OpenSearch Dashboards gets confused when a plugin is not defining a saved object type but the saved object exists. This can occur when migrating from a non-OSD version and there exists non-compatiable saved objects. If OSD is failing to migrate an index because of a document, I can now configure OSD to delete types of saved objects that I specified because I know that these types should not be carried over. resolves: #1040 Signed-off-by: Kawika Avilla <[email protected]> * address comments Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #6443 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [tests] fix tests related to #6443 (#6722) * [tests] fix tests related to #6443 PR: 6443 merged in previous PR that had an immediate follow up PR to that PR. But the followup pr was not merged into 6443. The snapshots got updated to ensure the CI passed for 6443. But once merged into main, failures were observed. Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #6722 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * feat: add config for topRightNavigation (#6712) * feat: add config for topRightNavigation Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * Changeset file for PR #6712 created/updated * test: update context test Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * update changeset Signed-off-by: tygao <[email protected]> * update joi default value Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: yujin-emma <[email protected]> * move the css to the data source aggregated view Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]add more test for icon and aggregated view (#6729) * add more test for icon and aggregated view Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6729 created/updated * Update CHANGELOG.md --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * update css file space and use the oui color guideline number to replace the color name in css file Signed-off-by: yujin-emma <[email protected]> * [OSD Availability] Prevent OSD process crashes when disk is full (#6733) * prevent crash when disk full Signed-off-by: Flyingliuhub <[email protected]> * change verbose to false Signed-off-by: Flyingliuhub <[email protected]> * add changeset file Signed-off-by: Flyingliuhub <[email protected]> * update changeset contexts Signed-off-by: Flyingliuhub <[email protected]> * change feature flag name Signed-off-by: Flyingliuhub <[email protected]> --------- Signed-off-by: Flyingliuhub <[email protected]> Co-authored-by: ZilongX <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [MDS] Modify toast + popover warning to include incompatible datasources (#6678) * Fix merge conflict Signed-off-by: Huy Nguyen <[email protected]> * Refactor to incompatibleDataSourcesExist Signed-off-by: Huy Nguyen <[email protected]> * Changeset file for PR #6678 created/updated * Move required args to the top Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752) * add test for data_source_error_menu, data_source_item, data_source_multi_selectable Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6752 created/updated * add content verify in test Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [2.14][chore] update release notes (#6705) Updates releases notes. Partially populated with: yarn release_note:generate And gathered the rest. Cleaned up changelog. related to: #6254 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add http://www.site.com to lycheeignore (#6771) * add http://www.site.com to lycheeignore Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6771 created/updated * Update .lycheeignore Co-authored-by: Miki <[email protected]> Signed-off-by: Yu Jin <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756) * fix: show a error toast when workspace read only user delete saved objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #6756 created/updated * Changeset file for PR #6756 created/updated * optimize the code Signed-off-by: yubonluo <[email protected]> * Display the delete modal after failing to delete. Signed-off-by: yubonluo <[email protected]> * Add some unit tests Signed-off-by: yubonluo <[email protected]> * Add some state assertions Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Updating security reachout email (#6778) Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add @zhyuanqi as a maintainer (#6788) * add @zhyuanqi as a maintainer --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [OE] Adds dev doc script to precommit hook (#6585) * Adds doc generation to pre commit hook Signed-off-by: Ashwin P Chandran <[email protected]> * Add check hook to pre commit Signed-off-by: Ashwin P Chandran <[email protected]> * Changeset file for PR #6585 created/updated * Update error message Signed-off-by: Ashwin P Chandran <[email protected]> * Improve error message Co-authored-by: Miki <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> * fixes lint issue Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Move @BSFishy to emeritus maintainer (#6790) * Move @BSFishy to emeritus maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6790 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * add @mengweieric as maintainer (#6798) * add @mengweieric as maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6798 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Add OpenAPI specification for get and create saved object APIs (#6799) * add openapi doc Signed-off-by: Lu Yu <[email protected]> * add readme Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6799 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]Add test for toast button and validation form (#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Flyingliuhub <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: yubonluo <[email protected]> Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Xinrui Bai-amazon <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: tygao <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Tao Liu <[email protected]> Co-authored-by: ZilongX <[email protected]> Co-authored-by: Huy Nguyen <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Varun Lodaya <[email protected]> Co-authored-by: Lu Yu <[email protected]>
Flyingliuhub
pushed a commit
that referenced
this issue
May 17, 2024
…rm (#6755) (#6804) * add test for toast button and validation form * Changeset file for PR #6755 created/updated * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx * Update manage_data_source_button.test.tsx * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form * Changeset file for PR #6742 created/updated --------- * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame move language to left, some styling and disable per app name --------- * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive * Changeset file for PR #6759 created/updated --------- * address naming for manage data source button test id --------- (cherry picked from commit f728b5a) Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this issue
Jun 3, 2024
) * adjust the aggregated view padding Signed-off-by: yujin-emma <[email protected]> * WIP Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx Co-authored-by: Xinrui Bai-amazon <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6715 created/updated Signed-off-by: yujin-emma <[email protected]> * Update CHANGELOG.md Signed-off-by: yujin-emma <[email protected]> * [saved objects] enable deletion of saved objects by type if configured (#6443) * [saved objects] enable deletion of saved objects by type if configured Adds the following settings: ``` migrations.delete.enabled migrations.delete.types ``` `unknown` types already exist but the purpose of this type is for plugins that are disabled. OpenSearch Dashboards gets confused when a plugin is not defining a saved object type but the saved object exists. This can occur when migrating from a non-OSD version and there exists non-compatiable saved objects. If OSD is failing to migrate an index because of a document, I can now configure OSD to delete types of saved objects that I specified because I know that these types should not be carried over. resolves: #1040 Signed-off-by: Kawika Avilla <[email protected]> * address comments Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #6443 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [tests] fix tests related to #6443 (#6722) * [tests] fix tests related to #6443 PR: 6443 merged in previous PR that had an immediate follow up PR to that PR. But the followup pr was not merged into 6443. The snapshots got updated to ensure the CI passed for 6443. But once merged into main, failures were observed. Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #6722 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * feat: add config for topRightNavigation (#6712) * feat: add config for topRightNavigation Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * Changeset file for PR #6712 created/updated * test: update context test Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * update changeset Signed-off-by: tygao <[email protected]> * update joi default value Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: yujin-emma <[email protected]> * move the css to the data source aggregated view Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]add more test for icon and aggregated view (#6729) * add more test for icon and aggregated view Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6729 created/updated * Update CHANGELOG.md --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * update css file space and use the oui color guideline number to replace the color name in css file Signed-off-by: yujin-emma <[email protected]> * [OSD Availability] Prevent OSD process crashes when disk is full (#6733) * prevent crash when disk full Signed-off-by: Flyingliuhub <[email protected]> * change verbose to false Signed-off-by: Flyingliuhub <[email protected]> * add changeset file Signed-off-by: Flyingliuhub <[email protected]> * update changeset contexts Signed-off-by: Flyingliuhub <[email protected]> * change feature flag name Signed-off-by: Flyingliuhub <[email protected]> --------- Signed-off-by: Flyingliuhub <[email protected]> Co-authored-by: ZilongX <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [MDS] Modify toast + popover warning to include incompatible datasources (#6678) * Fix merge conflict Signed-off-by: Huy Nguyen <[email protected]> * Refactor to incompatibleDataSourcesExist Signed-off-by: Huy Nguyen <[email protected]> * Changeset file for PR #6678 created/updated * Move required args to the top Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752) * add test for data_source_error_menu, data_source_item, data_source_multi_selectable Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6752 created/updated * add content verify in test Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [2.14][chore] update release notes (#6705) Updates releases notes. Partially populated with: yarn release_note:generate And gathered the rest. Cleaned up changelog. related to: #6254 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add http://www.site.com to lycheeignore (#6771) * add http://www.site.com to lycheeignore Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6771 created/updated * Update .lycheeignore Co-authored-by: Miki <[email protected]> Signed-off-by: Yu Jin <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756) * fix: show a error toast when workspace read only user delete saved objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #6756 created/updated * Changeset file for PR #6756 created/updated * optimize the code Signed-off-by: yubonluo <[email protected]> * Display the delete modal after failing to delete. Signed-off-by: yubonluo <[email protected]> * Add some unit tests Signed-off-by: yubonluo <[email protected]> * Add some state assertions Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Updating security reachout email (#6778) Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add @zhyuanqi as a maintainer (#6788) * add @zhyuanqi as a maintainer --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [OE] Adds dev doc script to precommit hook (#6585) * Adds doc generation to pre commit hook Signed-off-by: Ashwin P Chandran <[email protected]> * Add check hook to pre commit Signed-off-by: Ashwin P Chandran <[email protected]> * Changeset file for PR #6585 created/updated * Update error message Signed-off-by: Ashwin P Chandran <[email protected]> * Improve error message Co-authored-by: Miki <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> * fixes lint issue Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Move @BSFishy to emeritus maintainer (#6790) * Move @BSFishy to emeritus maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6790 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * add @mengweieric as maintainer (#6798) * add @mengweieric as maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6798 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Add OpenAPI specification for get and create saved object APIs (#6799) * add openapi doc Signed-off-by: Lu Yu <[email protected]> * add readme Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR #6799 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]Add test for toast button and validation form (#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR #6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR #6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Flyingliuhub <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: yubonluo <[email protected]> Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Xinrui Bai-amazon <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: tygao <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Tao Liu <[email protected]> Co-authored-by: ZilongX <[email protected]> Co-authored-by: Huy Nguyen <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Varun Lodaya <[email protected]> Co-authored-by: Lu Yu <[email protected]> (cherry picked from commit 9ef7404) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhyuanqi
pushed a commit
that referenced
this issue
Jun 3, 2024
) (#6896) * adjust the aggregated view padding * WIP * Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx * Changeset file for PR #6715 created/updated * Update CHANGELOG.md * [saved objects] enable deletion of saved objects by type if configured (#6443) * [saved objects] enable deletion of saved objects by type if configured Adds the following settings: ``` migrations.delete.enabled migrations.delete.types ``` `unknown` types already exist but the purpose of this type is for plugins that are disabled. OpenSearch Dashboards gets confused when a plugin is not defining a saved object type but the saved object exists. This can occur when migrating from a non-OSD version and there exists non-compatiable saved objects. If OSD is failing to migrate an index because of a document, I can now configure OSD to delete types of saved objects that I specified because I know that these types should not be carried over. resolves: #1040 * address comments * Changeset file for PR #6443 created/updated --------- * [tests] fix tests related to #6443 (#6722) * [tests] fix tests related to #6443 PR: 6443 merged in previous PR that had an immediate follow up PR to that PR. But the followup pr was not merged into 6443. The snapshots got updated to ensure the CI passed for 6443. But once merged into main, failures were observed. * Changeset file for PR #6722 created/updated --------- * feat: add config for topRightNavigation (#6712) * feat: add config for topRightNavigation * doc: update changelog * Changeset file for PR #6712 created/updated * test: update context test * doc: update changelog * update changeset * update joi default value * add experimental annotation and add futureNavigation configuration * add experimental annotation and add futureNavigation configuration --------- * move the css to the data source aggregated view * [Multiple Datasource Test]add more test for icon and aggregated view (#6729) * add more test for icon and aggregated view * Changeset file for PR #6729 created/updated * Update CHANGELOG.md --------- * update css file space and use the oui color guideline number to replace the color name in css file * [OSD Availability] Prevent OSD process crashes when disk is full (#6733) * prevent crash when disk full * change verbose to false * add changeset file * update changeset contexts * change feature flag name --------- * [MDS] Modify toast + popover warning to include incompatible datasources (#6678) * Fix merge conflict * Refactor to incompatibleDataSourcesExist * Changeset file for PR #6678 created/updated * Move required args to the top --------- * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form * Changeset file for PR #6742 created/updated --------- * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame move language to left, some styling and disable per app name --------- * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive * Changeset file for PR #6759 created/updated --------- * [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752) * add test for data_source_error_menu, data_source_item, data_source_multi_selectable * Changeset file for PR #6752 created/updated * add content verify in test --------- * [2.14][chore] update release notes (#6705) Updates releases notes. Partially populated with: yarn release_note:generate And gathered the rest. Cleaned up changelog. related to: #6254 * add http://www.site.com to lycheeignore (#6771) * add http://www.site.com to lycheeignore * Changeset file for PR #6771 created/updated * Update .lycheeignore --------- * [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756) * fix: show a error toast when workspace read only user delete saved objects * Changeset file for PR #6756 created/updated * Changeset file for PR #6756 created/updated * optimize the code * Display the delete modal after failing to delete. * Add some unit tests * Add some state assertions --------- * Updating security reachout email (#6778) * add @zhyuanqi as a maintainer (#6788) * add @zhyuanqi as a maintainer --------- * [OE] Adds dev doc script to precommit hook (#6585) * Adds doc generation to pre commit hook * Add check hook to pre commit * Changeset file for PR #6585 created/updated * Update error message * Improve error message * fixes lint issue --------- * Move @BSFishy to emeritus maintainer (#6790) * Move @BSFishy to emeritus maintainer * Changeset file for PR #6790 created/updated --------- * add @mengweieric as maintainer (#6798) * add @mengweieric as maintainer * Changeset file for PR #6798 created/updated --------- * Add OpenAPI specification for get and create saved object APIs (#6799) * add openapi doc * add readme * Changeset file for PR #6799 created/updated --------- * [Multiple Datasource Test]Add test for toast button and validation form (#6755) * add test for toast button and validation form * Changeset file for PR #6755 created/updated * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx * Update manage_data_source_button.test.tsx * [Multiple Datasource Test] Add test for edit data source form (#6742) * add test for edit data source form * Changeset file for PR #6742 created/updated --------- * [MQL] support enhancing language selector (#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes #6639 closes #6311 partially resolves: #5504 * add error data frame move language to left, some styling and disable per app name --------- * Make Field Name Search Filter Case Insensitive (#6759) * Make Field Name Filter Case Insensitive * Changeset file for PR #6759 created/updated --------- * address naming for manage data source button test id --------- --------- (cherry picked from commit 9ef7404) Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Flyingliuhub <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: yubonluo <[email protected]> Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Xinrui Bai-amazon <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: tygao <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Tao Liu <[email protected]> Co-authored-by: ZilongX <[email protected]> Co-authored-by: Huy Nguyen <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Varun Lodaya <[email protected]> Co-authored-by: Lu Yu <[email protected]>
LDrago27
pushed a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this issue
Jun 3, 2024
Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
LDrago27
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this issue
Jun 3, 2024
…rm (opensearch-project#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (opensearch-project#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (opensearch-project#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (opensearch-project#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR opensearch-project#6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]>
LDrago27
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this issue
Jun 3, 2024
…ensearch-project#6715) * adjust the aggregated view padding Signed-off-by: yujin-emma <[email protected]> * WIP Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx Co-authored-by: Xinrui Bai-amazon <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6715 created/updated Signed-off-by: yujin-emma <[email protected]> * Update CHANGELOG.md Signed-off-by: yujin-emma <[email protected]> * [saved objects] enable deletion of saved objects by type if configured (opensearch-project#6443) * [saved objects] enable deletion of saved objects by type if configured Adds the following settings: ``` migrations.delete.enabled migrations.delete.types ``` `unknown` types already exist but the purpose of this type is for plugins that are disabled. OpenSearch Dashboards gets confused when a plugin is not defining a saved object type but the saved object exists. This can occur when migrating from a non-OSD version and there exists non-compatiable saved objects. If OSD is failing to migrate an index because of a document, I can now configure OSD to delete types of saved objects that I specified because I know that these types should not be carried over. resolves: opensearch-project#1040 Signed-off-by: Kawika Avilla <[email protected]> * address comments Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR opensearch-project#6443 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [tests] fix tests related to opensearch-project#6443 (opensearch-project#6722) * [tests] fix tests related to opensearch-project#6443 PR: 6443 merged in previous PR that had an immediate follow up PR to that PR. But the followup pr was not merged into 6443. The snapshots got updated to ensure the CI passed for 6443. But once merged into main, failures were observed. Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR opensearch-project#6722 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * feat: add config for topRightNavigation (opensearch-project#6712) * feat: add config for topRightNavigation Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * Changeset file for PR opensearch-project#6712 created/updated * test: update context test Signed-off-by: tygao <[email protected]> * doc: update changelog Signed-off-by: tygao <[email protected]> * update changeset Signed-off-by: tygao <[email protected]> * update joi default value Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> * add experimental annotation and add futureNavigation configuration Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <[email protected]> Signed-off-by: yujin-emma <[email protected]> * move the css to the data source aggregated view Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]add more test for icon and aggregated view (opensearch-project#6729) * add more test for icon and aggregated view Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6729 created/updated * Update CHANGELOG.md --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * update css file space and use the oui color guideline number to replace the color name in css file Signed-off-by: yujin-emma <[email protected]> * [OSD Availability] Prevent OSD process crashes when disk is full (opensearch-project#6733) * prevent crash when disk full Signed-off-by: Flyingliuhub <[email protected]> * change verbose to false Signed-off-by: Flyingliuhub <[email protected]> * add changeset file Signed-off-by: Flyingliuhub <[email protected]> * update changeset contexts Signed-off-by: Flyingliuhub <[email protected]> * change feature flag name Signed-off-by: Flyingliuhub <[email protected]> --------- Signed-off-by: Flyingliuhub <[email protected]> Co-authored-by: ZilongX <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [MDS] Modify toast + popover warning to include incompatible datasources (opensearch-project#6678) * Fix merge conflict Signed-off-by: Huy Nguyen <[email protected]> * Refactor to incompatibleDataSourcesExist Signed-off-by: Huy Nguyen <[email protected]> * Changeset file for PR opensearch-project#6678 created/updated * Move required args to the top Signed-off-by: Huy Nguyen <[email protected]> --------- Signed-off-by: Huy Nguyen <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (opensearch-project#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (opensearch-project#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (opensearch-project#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR opensearch-project#6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (opensearch-project#6752) * add test for data_source_error_menu, data_source_item, data_source_multi_selectable Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6752 created/updated * add content verify in test Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [2.14][chore] update release notes (opensearch-project#6705) Updates releases notes. Partially populated with: yarn release_note:generate And gathered the rest. Cleaned up changelog. related to: opensearch-project#6254 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add http://www.site.com to lycheeignore (opensearch-project#6771) * add http://www.site.com to lycheeignore Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6771 created/updated * Update .lycheeignore Co-authored-by: Miki <[email protected]> Signed-off-by: Yu Jin <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (opensearch-project#6756) * fix: show a error toast when workspace read only user delete saved objects Signed-off-by: yubonluo <[email protected]> * Changeset file for PR opensearch-project#6756 created/updated * Changeset file for PR opensearch-project#6756 created/updated * optimize the code Signed-off-by: yubonluo <[email protected]> * Display the delete modal after failing to delete. Signed-off-by: yubonluo <[email protected]> * Add some unit tests Signed-off-by: yubonluo <[email protected]> * Add some state assertions Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Updating security reachout email (opensearch-project#6778) Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: yujin-emma <[email protected]> * add @zhyuanqi as a maintainer (opensearch-project#6788) * add @zhyuanqi as a maintainer --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [OE] Adds dev doc script to precommit hook (opensearch-project#6585) * Adds doc generation to pre commit hook Signed-off-by: Ashwin P Chandran <[email protected]> * Add check hook to pre commit Signed-off-by: Ashwin P Chandran <[email protected]> * Changeset file for PR opensearch-project#6585 created/updated * Update error message Signed-off-by: Ashwin P Chandran <[email protected]> * Improve error message Co-authored-by: Miki <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> * fixes lint issue Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Miki <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Move @BSFishy to emeritus maintainer (opensearch-project#6790) * Move @BSFishy to emeritus maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR opensearch-project#6790 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * add @mengweieric as maintainer (opensearch-project#6798) * add @mengweieric as maintainer Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR opensearch-project#6798 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Add OpenAPI specification for get and create saved object APIs (opensearch-project#6799) * add openapi doc Signed-off-by: Lu Yu <[email protected]> * add readme Signed-off-by: Lu Yu <[email protected]> * Changeset file for PR opensearch-project#6799 created/updated --------- Signed-off-by: Lu Yu <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test]Add test for toast button and validation form (opensearch-project#6755) * add test for toast button and validation form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6755 created/updated Signed-off-by: yujin-emma <[email protected]> * Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx Co-authored-by: Lu Yu <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: yujin-emma <[email protected]> * Update manage_data_source_button.test.tsx Signed-off-by: yujin-emma <[email protected]> * [Multiple Datasource Test] Add test for edit data source form (opensearch-project#6742) * add test for edit data source form Signed-off-by: yujin-emma <[email protected]> * Changeset file for PR opensearch-project#6742 created/updated --------- Signed-off-by: yujin-emma <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * [MQL] support enhancing language selector (opensearch-project#6613) Enable with `data.enhancements.enabled: true` Allows for enhancing the data plugin UI service and search service. #### Remaining work * Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range. * Add tests * Disable for plugins that do not support the functionality * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices). * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id. * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory. ### Issues Resolved closes opensearch-project#6639 closes opensearch-project#6311 partially resolves: opensearch-project#5504 * add error data frame Signed-off-by: Paul Sebastian <[email protected]> move language to left, some styling and disable per app name Signed-off-by: Kawika Avilla <[email protected]> --------- Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * Make Field Name Search Filter Case Insensitive (opensearch-project#6759) * Make Field Name Filter Case Insensitive Signed-off-by: Suchit Sahoo <[email protected]> * Changeset file for PR opensearch-project#6759 created/updated --------- Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Signed-off-by: yujin-emma <[email protected]> * address naming for manage data source button test id Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Lu Yu <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Signed-off-by: yujin-emma <[email protected]> --------- Signed-off-by: yujin-emma <[email protected]> Signed-off-by: Yu Jin <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: tygao <[email protected]> Signed-off-by: Flyingliuhub <[email protected]> Signed-off-by: Huy Nguyen <[email protected]> Signed-off-by: Paul Sebastian <[email protected]> Signed-off-by: Suchit Sahoo <[email protected]> Signed-off-by: yubonluo <[email protected]> Signed-off-by: varun-lodaya <[email protected]> Signed-off-by: Lu Yu <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: Ashwin P Chandran <[email protected]> Co-authored-by: Xinrui Bai-amazon <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: tygao <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Tao Liu <[email protected]> Co-authored-by: ZilongX <[email protected]> Co-authored-by: Huy Nguyen <[email protected]> Co-authored-by: Paul Sebastian <[email protected]> Co-authored-by: Suchit Sahoo <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: yuboluo <[email protected]> Co-authored-by: Varun Lodaya <[email protected]> Co-authored-by: Lu Yu <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Opening this proposal for extending features within the data plugin.
PR: [LINK]
Current feature branch for OSD: [LINK]
PoC Plugin: [LINK]
Glossary
Background
OpenSearch Dashboards and plugins lack a unified query experience. Here is a high-level overview of what exists today:
In the original architecture, as depicted in the diagram, a plugin was required to implement its own unique search strategies. For instance, if we wanted to support new query languages, they would need to be added to both the Data plugin and the Discover plugin. Furthermore, the system would execute these queries using either
_search
or_msearch
for OpenSearch, thereby eliminating the flexibility to query different types of data sources.To be more generic, to add a new query language, you have to add a search strategy and register it. But other plugins cannot not use it until the work is done to hook into it. Even with that, search strategies are built to handle DSL queries. To add a new a new language, you would also need to build the query into a DSL and expects documents for it to integrate into the system.
Problem
While our primary focus will be on designing around the requirements of the current state of the Discover plugin, the design will also lay the groundwork for broader applications. This includes extending its use to visualizations and implementing various search strategies for different data connections and sources.
The problem we're trying to solve is the inconsistency in capabilities across different query languages within OpenSearch Dashboards. This inconsistency, resulting from various code paths performing similar tasks like data table display or visualization interaction, leads to a potentially frustrating user experience. There is also an inconsistencies in the data connections, the data connection might not support specific query languages, or different ways handling requests. We are addressing this issue now because it's crucial to provide a unified and predictable user experience, regardless of the chosen query language or data connection::data source.
Furthermore, we aim to foster a more inclusive and extensible development environment. Currently, plugins can not augment the search functionalities within the Data plugin nor can they provide custom adapters for their specific data sources. This makes OpenSearch Dashboards coupled to OpenSearch queries and OpenSearch data sources. Without interoperability, data can become isolated in different databases, making it difficult to access and analyze collectively. Interoperability allows for seamless data integration across different NoSQL databases. Some NoSQL databases are not optimized for complex queries. Interoperability allows for the use of different databases for different tasks, enabling more complex data operations. Interoperability in NoSQL databases can help solve several problems. However, there's a need to clearly document the capabilities and limitations of these enhancements to help developers understand what they can and cannot do with each query language, setting appropriate expectations.
Tenets
Proposed Solution
This method enhances the search service within the Data plugin, enabling it to dynamically switch the search interceptor at runtime. This mutable search interceptor can be modified by the new UI service, allowing plugin developers to integrate their query language. To support a new query language, developers will need to create a search strategy. This strategy will handle the translation of the query into a format understandable by their data source, manage the request to the data source, and format the response into a standardized data structure which is the data frame.
Create the UI Service
The Data plugin currently implements the top search bar, index pattern select, langauge selector, and time picker. With the UI service, it will abstract the components to a service that can be modified by other plugins.
Plugins will be able to register UI enhancements to directly modify or extend functionality of the top search bar. The initial list of supported enhancements will be:
Here is an example of interacting with the UI service to modify the search bar:
Here we can see what the user will see if they are querying with DQL:
Here we can see what the user will if they are querying with the above example configurations:
Search Interceptor
The search interceptor invokes the appropriate search strategy. While a default search interceptor is provided out-of-the-box, plugins can replace it with a custom implementation. This custom search interceptor can be registered and activated based on the selected query language.
The search interceptor should be capable of accepting a DataFrame. This allows developers to leverage provided utility functions to construct queries for their specific data sources. For instance, if the query does not include the necessary time field for time series data, developers can use the getTimeField function to ensure the query is appropriately structured. This enhances the flexibility and usability of the search interceptor, catering to diverse data connect::data source requirements.
When users select the query language, the data service will replace the default search interceptor with the search interceptor provided by the adapter.
Search Strategy
The search strategy can be thought of as the adapter to your data connection::data source. Here is where you will need to map the response back to the data frame. For example:
As you can see developers can convert their data to fields and values and call createDataFrame which will map the fields that OpenSearch Dashboards understands. If there any types that we need to expand for converting this is where that work will go.
Then developers will return back the data frame in the response. OpenSearch Dashboards parses this response and use it for further processing or visualization. This transformation process ensures compatibility between the custom data source and OpenSearch Dashboards, enabling seamless integration and usage of the data. Developers can decide if they want to include aggregations.
Data Frame
Index patterns play a crucial role within OpenSearch Dashboards, as the application anticipates the creation of an index pattern that aligns with your indices, with the mappings for that data serving as the type for the fields. As stated, above, the index pattern is an expected normalization of the data source which has to manually created by users. This means there can be a difference in the index pattern and the underlying indices. If you created an index pattern in the past but then ingest data that has new fields. In this case, users must refresh the index patterns.
To address this, the DataFrame type will be used with a schema and fields. The IDataFrame interface provides a standardized structure for data manipulation and analysis. This structure simplifies operations such as filtering, sorting (maybe), and aggregating, and facilitates the transfer of data between different parts of an application or even different applications. By explicitly defining the data structure through the IDataFrame interface, we not only enhance the predictability and usability of the system, but also empower developers to enhance their search capabilities. This well-defined structure provides a reliable blueprint for developers to map their data, thereby facilitating more efficient data manipulation and analysis within OpenSearch Dashboards. The schema will be the description of the data source where as the fields will be the expected result set.
The current implementation depends on the search strategy for properly getting the schema and fields. Upon data connection::data source change, the data frame will null when passed to the search strategy, developers can key off to populate the schema there are whatever hydration strategy of their choosing.
// TODO: add schema to this screen shot
There is a fallback of relying the fields if the schema isn't populated. The creation of UI Settings related to hydration search strategies can also be utilized. For example:
After receiving the data frame, the data frame will be normalized into an index pattern that is saved into memory. This temporary index pattern can then be utilized to interact with the other portions of the application.
Unsupported Types (non-Native)
The data plugin aims to convert the query and filters into an OpenSearch DSL, subsequently invoking the
_search
method from the chosen search interceptor.When the query is passed to the data plugin to build out the DSL, the language is passed with the query. In code, we know how to support kuery (DQL), Lucene, or DSL.
However, if the query incorporates a language that is not native to OpenSearc, the data plugin recognizes the query as an unsupported type since it is not one of the three. In such cases, it refrains from constructing an OpenSearch Query and passes the full query to the search strategy. This approach ensures compatibility with a variety of query languages, enhancing the flexibility of the data plugin.
FAQ
[1] At what stage of the execution is this data frame structure generated?
When the Data plugin detects the query received is not an OpenSearch DSL, and there is not a data frame cached. It will create a data frame then it will pass around that data frame until data source is changed or a query is a DSL. If the data source has changed. It will replace the data frame cached. If it is a native query language, then it will unset the data frame.
[2] How often and under what circumstances is the data frame updated?
Per query, the data frame is updated, UI settings can be configured to change this strategy. Support data frames that require splicing (in the case of polling) into existing data frame instead of replacing fields.
[3] How does the data frame handle conflicts in value types?
The data frame will attempt to map fields that could be a timestamp to date based on if it can successfully be transformed. This logic can be expanded in the utility helper function.
The text was updated successfully, but these errors were encountered: