Skip to content

Commit

Permalink
[Multiple datasource] Adjust the padding size for aggregated view (#6715
Browse files Browse the repository at this point in the history
) (#6896)

* adjust the aggregated view padding



* WIP



* Update src/plugins/data_source_management/public/components/data_source_aggregated_view/data_source_aggregated_view.tsx





* Changeset file for PR #6715 created/updated



* Update CHANGELOG.md



* [saved objects] enable deletion of saved objects by type if configured (#6443)

* [saved objects] enable deletion of saved objects by type if configured

Adds the following settings:
```
migrations.delete.enabled
migrations.delete.types
```

`unknown` types already exist but the purpose of this type is for plugins
that are disabled. OpenSearch Dashboards gets confused when a plugin is not
defining a saved object type but the saved object exists. This can occur
when migrating from a non-OSD version and there exists non-compatiable
saved objects.

If OSD is failing to migrate an index because of a document, I can now
configure OSD to delete types of saved objects that I specified because
I know that these types should not be carried over.

resolves: #1040



* address comments



* Changeset file for PR #6443 created/updated

---------





* [tests] fix tests related to #6443 (#6722)

* [tests] fix tests related to #6443

PR: 6443 merged in previous PR that had an immediate follow up PR
to that PR. But the followup pr was not merged into 6443.

The snapshots got updated to ensure the CI passed for 6443. But
once merged into main, failures were observed.



* Changeset file for PR #6722 created/updated

---------





* feat: add config for topRightNavigation (#6712)

* feat: add config for topRightNavigation



* doc: update changelog



* Changeset file for PR #6712 created/updated

* test: update context test



* doc: update changelog



* update changeset



* update joi default value



* add experimental annotation and add futureNavigation configuration



* add experimental annotation and add futureNavigation configuration



---------






* move the css to the data source aggregated view



* [Multiple Datasource Test]add more test for icon and aggregated view (#6729)

* add more test for icon and aggregated view



* Changeset file for PR #6729 created/updated

* Update CHANGELOG.md

---------





* update css file space and use the oui color guideline number to replace the color name in css file



* [OSD Availability] Prevent OSD process crashes when disk is full (#6733)

* prevent crash when disk full



* change verbose to false



* add changeset file



* update changeset contexts



* change feature flag name



---------





* [MDS] Modify toast + popover warning to include incompatible datasources (#6678)

* Fix merge conflict



* Refactor to incompatibleDataSourcesExist



* Changeset file for PR #6678 created/updated

* Move required args to the top



---------





* [Multiple Datasource Test] Add test for edit data source form (#6742)

* add test for edit data source form



* Changeset file for PR #6742 created/updated

---------





* [MQL] support enhancing language selector (#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes #6639
closes #6311

partially resolves:
#5504

* add error data frame



move language to left, some styling and disable per app name



---------







* Make Field Name Search Filter Case Insensitive (#6759)

* Make Field Name Filter Case Insensitive



* Changeset file for PR #6759 created/updated

---------





* [Multiple Datasource Test] Add test for error_menu, item, data_source_multi_selectable (#6752)

* add test for data_source_error_menu, data_source_item, data_source_multi_selectable



* Changeset file for PR #6752 created/updated

* add content verify in test



---------





* [2.14][chore] update release notes (#6705)

Updates releases notes. Partially populated with: yarn release_note:generate

And gathered the rest. Cleaned up changelog.

related to: #6254




* add http://www.site.com to lycheeignore (#6771)

* add http://www.site.com to lycheeignore



* Changeset file for PR #6771 created/updated

* Update .lycheeignore




---------







* [Workspace] Fix: Show a error toast when workspace read only user delete saved objects (#6756)

* fix: show a error toast when workspace read only user delete saved objects



* Changeset file for PR #6756 created/updated

* Changeset file for PR #6756 created/updated

* optimize the code



* Display the delete modal after failing to delete.



* Add some unit tests



* Add some state assertions



---------





* Updating security reachout email (#6778)




* add @zhyuanqi as a maintainer (#6788)

* add @zhyuanqi as a maintainer

---------





* [OE] Adds dev doc script to precommit hook (#6585)

* Adds doc generation to pre commit hook



* Add check hook to pre commit



* Changeset file for PR #6585 created/updated

* Update error message



* Improve error message




* fixes lint issue



---------







* Move @BSFishy to emeritus maintainer (#6790)

* Move @BSFishy to emeritus maintainer



* Changeset file for PR #6790 created/updated

---------





* add @mengweieric as maintainer (#6798)

* add @mengweieric as maintainer



* Changeset file for PR #6798 created/updated

---------





* Add OpenAPI specification for get and create saved object APIs  (#6799)

* add openapi doc



* add readme



* Changeset file for PR #6799 created/updated

---------





* [Multiple Datasource Test]Add test for toast button and validation form (#6755)

* add test for toast button and validation form



* Changeset file for PR #6755 created/updated



* Update src/plugins/data_source_management/public/components/toast_button/manage_data_source_button.tsx





* Update manage_data_source_button.test.tsx



* [Multiple Datasource Test] Add test for edit data source form (#6742)

* add test for edit data source form



* Changeset file for PR #6742 created/updated

---------





* [MQL] support enhancing language selector (#6613)

Enable with `data.enhancements.enabled: true`

Allows for enhancing the data plugin UI service and search service.

#### Remaining work
* Address issue with time range being invalid if previous state successfully queried and set it with a time range format that is invalid for the new query language
  * For example, DQL with quick time range (4 weeks to now), get results. Switch to PPL, even though PPL has a default time range enhancement. The props date range saved in the app state takes priority and sets the time range to quick range causing an error. I can still modify the time range and get a successful query but it will first fail until the user updates it to a non quick time range.
* Add tests
* Disable for plugins that do not support the functionality
  * By default index patterns are created with a unique ID. However, it can be enabled to create an index pattern with a custom ID that matches the name of the index pattern (which in turn maps to indices).
  * For seamless integration, the temp data frame would need to check if the index pattern that maps to the data frame name. And get it's id.
  * This means that dashboards with visualizations that were created with an index pattern unique ID still require the existing index pattern to exist in memory.

### Issues Resolved

closes #6639
closes #6311

partially resolves:
#5504

* add error data frame



move language to left, some styling and disable per app name



---------







* Make Field Name Search Filter Case Insensitive (#6759)

* Make Field Name Filter Case Insensitive



* Changeset file for PR #6759 created/updated

---------





* address naming for manage data source button test id



---------













---------




























(cherry picked from commit 9ef7404)

Signed-off-by: yujin-emma <[email protected]>
Signed-off-by: Yu Jin <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: tygao <[email protected]>
Signed-off-by: Flyingliuhub <[email protected]>
Signed-off-by: Huy Nguyen <[email protected]>
Signed-off-by: Paul Sebastian <[email protected]>
Signed-off-by: Suchit Sahoo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: varun-lodaya <[email protected]>
Signed-off-by: Lu Yu <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Xinrui Bai-amazon <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Co-authored-by: Kawika Avilla <[email protected]>
Co-authored-by: tygao <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Tao Liu <[email protected]>
Co-authored-by: ZilongX <[email protected]>
Co-authored-by: Huy Nguyen <[email protected]>
Co-authored-by: Paul Sebastian <[email protected]>
Co-authored-by: Suchit Sahoo <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: yuboluo <[email protected]>
Co-authored-by: Varun Lodaya <[email protected]>
Co-authored-by: Lu Yu <[email protected]>
  • Loading branch information
16 people authored Jun 3, 2024
1 parent e44613d commit 5082f42
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 2 deletions.
2 changes: 2 additions & 0 deletions changelogs/fragments/6715.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
fix:
- Adjust the padding size for aggregated view ([#6715](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6715))
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,15 @@

.euiSelectableListItem__content {
cursor: default;
padding-left: 0;
margin-right: 0;


.euiSelectableListItem__text {
max-height: 100%;
max-height: 100%;
}
.euiSelectableListItem__icon, .euiSelectableListItem__prepend {
margin-right: 0;
}
}

Expand All @@ -31,6 +36,7 @@
overflow: hidden;
white-space: nowrap;
display: inline-block;
padding-left: 0;
}
}

Expand All @@ -39,4 +45,22 @@
align-items: center;
justify-content: center;
}

.dataSourceAggregatedViewOuiFlexItem {
color: grey;
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
display: inline-block;
padding-left: 0;
}

.dataSourceListAllActiveOuiFlexItem {
color: grey;
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
display: inline-block;
padding-left: 1em;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,11 @@ export class DataSourceAggregatedView extends React.Component<
options={items}
renderOption={(option) => (
<DataSourceItem
className={'dataSourceAggregatedView'}
className={
this.props.displayAllCompatibleDataSources
? 'dataSourceAggregatedView'
: 'dataSourceListAllActive'
}
option={option}
defaultDataSource={this.state.defaultDataSource}
/>
Expand Down

0 comments on commit 5082f42

Please sign in to comment.