Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSCI] [FIX] time conversion unit test bug #5174

Merged
merged 8 commits into from
Oct 4, 2023
Merged

[OSCI] [FIX] time conversion unit test bug #5174

merged 8 commits into from
Oct 4, 2023

Conversation

thanhinhchtom
Copy link
Contributor

@thanhinhchtom thanhinhchtom commented Oct 2, 2023 •
edited
Loading

Description

Fix Unit test bug with time conversion in point_series in chart

Issues Resolved

fixes #5165

Screenshot

image

Testing the changes

  1. Run command yarn test:jest src/plugins/discover/public/application/components/chart/utils/point_series.test.ts

Check List

  • [] All tests pass
    • [] yarn test:jest
    • [] yarn test:jest_integration
    • [] yarn test:ftr
  • [] New functionality includes testing.
  • [] New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@thanhinhchtom thanhinhchtom mentioned this pull request Oct 2, 2023
Closed
ashwin-pc
ashwin-pc requested changes Oct 2, 2023
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! that was a quick fix. You seem to have added 2 files that are unrelated to the change though, can you remove those two?

Also can you add an entry to the Changelog for your fix?

@codecov
Copy link

codecov bot commented Oct 3, 2023 •
edited
Loading

Codecov Report

Merging #5174 (037faa0) into main (c70125f) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5174      +/-   ##
==========================================
- Coverage   66.76%   66.72%   -0.04%     
==========================================
  Files        3278     3278              
  Lines       62999    62999              
  Branches    10031    10031              
==========================================
- Hits        42059    42037      -22     
- Misses      18473    18572      +99     
+ Partials     2467     2390      -77
Flag Coverage Δ
Linux_1 35.31% <ø> (ø)
Linux_2 ?
Linux_3 43.74% <ø> (ø)
Linux_4 35.42% <ø> (ø)
Windows_1 35.33% <ø> (ø)
Windows_2 55.20% <ø> (ø)
Windows_3 43.76% <ø> (+<0.01%) ⬆️
Windows_4 35.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 25 files with indirect coverage changes

ananzh
ananzh previously approved these changes Oct 3, 2023
View reviewed changes
AMoo-Miki
AMoo-Miki previously approved these changes Oct 4, 2023
View reviewed changes
seanneumann
seanneumann previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@seanneumann seanneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ananzh
ananzh previously approved these changes Oct 4, 2023
View reviewed changes
@ananzh ananzh dismissed stale reviews from AMoo-Miki, seanneumann, and themself via 037faa0 October 4, 2023 18:15
@ananzh ananzh merged commit 336dce6 into opensearch-project:main Oct 4, 2023
55 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2023
@github-actions
[OSCI] [FIX] time conversion unit test bug (#5174)
8fbe234 
* fix time conversion test bug
* Fix wrong test case

---------

Signed-off-by: Thanh <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit 336dce6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 4, 2023
Merged
ananzh added a commit that referenced this pull request Oct 4, 2023
@opensearch-trigger-bot @ananzh
@AMoo-Miki @seanneumann
[OSCI] [FIX] time conversion unit test bug (#5174) (#5220)
430a62d 
* fix time conversion test bug
* Fix wrong test case

---------

Signed-off-by: Thanh <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
(cherry picked from commit 336dce6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
willie-hung pushed a commit to willie-hung/OpenSearch-Dashboards that referenced this pull request Oct 5, 2023
@thanhinhchtom @ananzh
@AMoo-Miki @seanneumann @willie-hung
[OSCI] [FIX] time conversion unit test bug (opensearch-project#5174)
ff763d5 
* fix time conversion test bug
* Fix wrong test case

---------

Signed-off-by: Thanh <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Signed-off-by: Willie Hung <[email protected]>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Oct 7, 2023
@thanhinhchtom @ananzh
@AMoo-Miki @seanneumann @SuZhou-Joe
[OSCI] [FIX] time conversion unit test bug (opensearch-project#5174)
c0b87eb 
* fix time conversion test bug
* Fix wrong test case

---------

Signed-off-by: Thanh <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananzh ananzh ananzh approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@seanneumann seanneumann seanneumann approved these changes

@AMoo-Miki AMoo-Miki AMoo-Miki left review comments

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@BSFishy BSFishy Awaiting requested review from BSFishy

@curq curq Awaiting requested review from curq curq is a code owner

Assignees
No one assigned
Labels
backport 2.x bug Something isn't working first-time-contributor test:unit v2.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Point series unit test failure
5 participants
@thanhinhchtom @seanneumann @AMoo-Miki @ashwin-pc @ananzh