Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OSCI] [FIX] time conversion unit test bug #5174

Merged
merged 8 commits into from
Oct 4, 2023
Merged

[OSCI] [FIX] time conversion unit test bug #5174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7332f1c
fix time conversion test bug
thanhinhchtom Oct 2, 2023
d7156e2
Merge branch 'opensearch-project:main' into main
thanhinhchtom Oct 3, 2023
15e4891
Fix wrong test case
thanhinhchtom Oct 3, 2023
a82da72
Merge branch 'main' into main
ananzh Oct 3, 2023
9c1b290
Merge branch 'main' into main
AMoo-Miki Oct 4, 2023
03962a7
Merge branch 'main' into main
seanneumann Oct 4, 2023
6511b95
Merge branch 'opensearch-project:main' into main
thanhinhchtom Oct 4, 2023
037faa0
Merge branch 'main' into main
ananzh Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,9 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Fix `visAugmenter` forming empty key-value pairs in its calls to the `SavedObject` API ([#5190](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5190))
- [Data Explorer][Discover] Automatically load solo added default index pattern ([#5171](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5171))
- [Data Explorer][Discover] Allow data grid to auto adjust size based on fetched data count ([#5191](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5191))
- [BUG] Fix wrong test due to time conversion ([#5174](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5174))
- [BUG][Data Explorer][Discover] Allow filter and query persist when refresh page or paste url to a new tab ([#5206](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5206))


### 🚞 Infrastructure

- Re-enable CI workflows for feature branches ([#2908](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2908))
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/discover/public/application/components/chart/utils/point_series.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,8 @@ describe('buildPointSeriesData', () => {
expect(result.ordered.interval.asHours()).toBe(1);
expect(result.ordered.intervalOpenSearchUnit).toBe('h');
expect(result.ordered.intervalOpenSearchValue).toBe(1);
expect(result.ordered.min.format()).toBe('2023-01-01T00:00:00+00:00');
expect(result.ordered.max.format()).toBe('2023-01-02T00:00:00+00:00');
expect(result.ordered.min.format()).toBe(moment('2023-01-01T00:00:00+00:00').format());
expect(result.ordered.max.format()).toBe(moment('2023-01-02T00:00:00+00:00').format());
expect(result.yAxisLabel).toEqual('Y Axis');
expect(result.values).toEqual([
{ x: 10, y: 100 },
Expand Down
Loading