[Backport 2.x] [OSCI] [FIX] time conversion unit test bug #5220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fix time conversion test bug * Fix wrong test case --------- Signed-off-by: Thanh <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Sean Neumann <[email protected]> (cherry picked from commit 336dce6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000 and
zengyan-amazon
as code owners
opensearch-trigger-bot
bot
requested a review
from kristenTian
as a code owner
opensearch-trigger-bot
bot
added
test:unit
autocut
opensearch-trigger-bot
bot
requested review from
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
AMoo-Miki
approved these changes
Oct 4, 2023
Codecov Report
@@ Coverage Diff @@
## 2.x #5220 +/- ##
==========================================
+ Coverage 66.79% 66.82% +0.03%
==========================================
Files 3278 3278
Lines 63051 63051
Branches 10031 10031
==========================================
+ Hits 42113 42133 +20
+ Misses 18471 18450 -21
- Partials 2467 2468 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ananzh
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 336dce6 from #5174.