Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]cannot remove securityDashboards in opensearch-dashboards:1.0.0-rc1 #465

Closed
DavidSche opened this issue Jun 9, 2021 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@DavidSche
Copy link

Describe the bug

A clear and concise description of what the bug is.

I cannot remove securityDashboards in opensearch-dashboards:1.0.0-rc1 , it's ok in opensearch-dashboards:1.0.0-beta1

I uses this Dockerfile

FROM opensearchproject/opensearch-dashboards:1.0.0-rc1
RUN /usr/share/opensearch-dashboards/bin/opensearch-dashboards-plugin remove securityDashboards
COPY --chown=opensearch-dashboards:opensearch-dashboards opensearch_dashboards.yml /usr/share/opensearch-dashboards/config/

the opensearch_dashboards.yml

server.name: opensearch-dashboards
server.host: "0"

To Reproduce
Steps to reproduce the behavior:

when I run opensearch-dashboards-plugin list command , the securityDashboards plugin is in list ;but cannot remove

[opensearch-dashboards@90784366e4db bin]$ ./opensearch-dashboards-plugin list                      
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

[opensearch-dashboards@90784366e4db bin]$ ./opensearch-dashboards-plugin remove securityDashboards 
Unable to remove plugin because of error: "Plugin [securityDashboards] is not installed"
[opensearch-dashboards@90784366e4db bin]$ 

Expected behavior
A clear and concise description of what you expected to happen.

OpenSearch Version
Please list the version of OpenSearch being used.

Dashboards Version
Please list the version of OpenSearch Dashboards being used.

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@DavidSche DavidSche added Beta bug Something isn't working untriaged labels Jun 9, 2021
@kavilla kavilla removed the untriaged label Jun 11, 2021
@kavilla
Copy link
Member

kavilla commented Jun 11, 2021

Hey David,

Thanks for opening this up. I definitely see the confusion. The value listed in the plugins cli does not match the actual plugin.

As you can see in this PR: #357 we converted to kebab case based on github.com//issues/322.

This is technically a duplicate of #366.

The solution is to have your Dockerfile like the following:

FROM opensearchproject/opensearch-dashboards:1.0.0-rc1
RUN /usr/share/opensearch-dashboards/bin/opensearch-dashboards-plugin list
RUN /usr/share/opensearch-dashboards/bin/opensearch-dashboards-plugin remove security-dashboards
RUN /usr/share/opensearch-dashboards/bin/opensearch-dashboards-plugin list
COPY --chown=opensearch-dashboards:opensearch-dashboards opensearch_dashboards.yml /usr/share/opensearch-dashboards/config/

Will need to bring it up #322 about the confusing output versus the actual value.

@kavilla
Copy link
Member

kavilla commented Jun 11, 2021

@DavidSche

Let me know if it is acceptable if I close this issue using this issue to track it.

@DavidSche
Copy link
Author

thanks @kavilla , your Dockerfile is ok ! thanks !

@kavilla
Copy link
Member

kavilla commented Jun 16, 2021

No problem! Thanks for bringing this up.

Will close this issue and will use #322 to track it, if you could please keep track of the outcomes there or comment your opinion please do!

Otherwise, if you still run into issues and not sure where to comment please feel free to re-open this issue.

@kavilla kavilla closed this as completed Jun 16, 2021
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jul 1, 2021
opensearch-project#357)"

This reverts commit 747ef8e.

Reverting for now because the full impact is not known and requires
subsequent commits to mitigate confusion related to CLI output.

Also, it seems like in the code there exists verification on the code
that plugins should explicitly be camelCase. So this merits more
discussion.

Issues related:
opensearch-project#322
opensearch-project#465
opensearch-project#366

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this issue Jul 1, 2021
#357)" (#578)

This reverts commit 747ef8e.

Reverting for now because the full impact is not known and requires
subsequent commits to mitigate confusion related to CLI output.

Also, it seems like in the code there exists verification on the code
that plugins should explicitly be camelCase. So this merits more
discussion.

Issues related:
#322
#465
#366

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jul 1, 2021
opensearch-project#357)" (opensearch-project#578)

This reverts commit 747ef8e.

Reverting for now because the full impact is not known and requires
subsequent commits to mitigate confusion related to CLI output.

Also, it seems like in the code there exists verification on the code
that plugins should explicitly be camelCase. So this merits more
discussion.

Issues related:
opensearch-project#322
opensearch-project#465
opensearch-project#366

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit to kavilla/OpenSearch-Dashboards-1 that referenced this issue Jul 1, 2021
opensearch-project#357)" (opensearch-project#578)

This reverts commit 747ef8e.

Reverting for now because the full impact is not known and requires
subsequent commits to mitigate confusion related to CLI output.

Also, it seems like in the code there exists verification on the code
that plugins should explicitly be camelCase. So this merits more
discussion.

Issues related:
opensearch-project#322
opensearch-project#465
opensearch-project#366

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this issue Jul 1, 2021
#357)" (#583)

This reverts commit 747ef8e.

Reverting for now because the full impact is not known and requires
subsequent commits to mitigate confusion related to CLI output.

Also, it seems like in the code there exists verification on the code
that plugins should explicitly be camelCase. So this merits more
discussion.

Issues related:
#322
#465
#366

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this issue Jul 1, 2021
#357)" (#584)

This reverts commit 747ef8e.

Reverting for now because the full impact is not known and requires
subsequent commits to mitigate confusion related to CLI output.

Also, it seems like in the code there exists verification on the code
that plugins should explicitly be camelCase. So this merits more
discussion.

Issues related:
#322
#465
#366

Signed-off-by: Kawika Avilla <[email protected]>
wkruse added a commit to wkruse/documentation-website that referenced this issue Jul 2, 2021
@kavilla
Copy link
Member

kavilla commented Jul 2, 2021

I have reverted the change that converts the plugins from camelCase to kebab case #578. So ./opensearch-dashboards-plugin remove securityDashboards will be the command when docker hub gets updated with all the plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants