-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]cannot remove securityDashboards in opensearch-dashboards:1.0.0-rc1 #465
Comments
Hey David, Thanks for opening this up. I definitely see the confusion. The value listed in the plugins cli does not match the actual plugin. As you can see in this PR: #357 we converted to kebab case based on github.com//issues/322. This is technically a duplicate of #366. The solution is to have your Dockerfile like the following:
Will need to bring it up #322 about the confusing output versus the actual value. |
Let me know if it is acceptable if I close this issue using this issue to track it. |
thanks @kavilla , your Dockerfile is ok ! thanks ! |
No problem! Thanks for bringing this up. Will close this issue and will use #322 to track it, if you could please keep track of the outcomes there or comment your opinion please do! Otherwise, if you still run into issues and not sure where to comment please feel free to re-open this issue. |
opensearch-project#357)" This reverts commit 747ef8e. Reverting for now because the full impact is not known and requires subsequent commits to mitigate confusion related to CLI output. Also, it seems like in the code there exists verification on the code that plugins should explicitly be camelCase. So this merits more discussion. Issues related: opensearch-project#322 opensearch-project#465 opensearch-project#366 Signed-off-by: Kawika Avilla <[email protected]>
#357)" (#578) This reverts commit 747ef8e. Reverting for now because the full impact is not known and requires subsequent commits to mitigate confusion related to CLI output. Also, it seems like in the code there exists verification on the code that plugins should explicitly be camelCase. So this merits more discussion. Issues related: #322 #465 #366 Signed-off-by: Kawika Avilla <[email protected]>
opensearch-project#357)" (opensearch-project#578) This reverts commit 747ef8e. Reverting for now because the full impact is not known and requires subsequent commits to mitigate confusion related to CLI output. Also, it seems like in the code there exists verification on the code that plugins should explicitly be camelCase. So this merits more discussion. Issues related: opensearch-project#322 opensearch-project#465 opensearch-project#366 Signed-off-by: Kawika Avilla <[email protected]>
opensearch-project#357)" (opensearch-project#578) This reverts commit 747ef8e. Reverting for now because the full impact is not known and requires subsequent commits to mitigate confusion related to CLI output. Also, it seems like in the code there exists verification on the code that plugins should explicitly be camelCase. So this merits more discussion. Issues related: opensearch-project#322 opensearch-project#465 opensearch-project#366 Signed-off-by: Kawika Avilla <[email protected]>
#357)" (#583) This reverts commit 747ef8e. Reverting for now because the full impact is not known and requires subsequent commits to mitigate confusion related to CLI output. Also, it seems like in the code there exists verification on the code that plugins should explicitly be camelCase. So this merits more discussion. Issues related: #322 #465 #366 Signed-off-by: Kawika Avilla <[email protected]>
#357)" (#584) This reverts commit 747ef8e. Reverting for now because the full impact is not known and requires subsequent commits to mitigate confusion related to CLI output. Also, it seems like in the code there exists verification on the code that plugins should explicitly be camelCase. So this merits more discussion. Issues related: #322 #465 #366 Signed-off-by: Kawika Avilla <[email protected]>
I have reverted the change that converts the plugins from camelCase to kebab case #578. So |
Describe the bug
A clear and concise description of what the bug is.
I cannot remove securityDashboards in opensearch-dashboards:1.0.0-rc1 , it's ok in opensearch-dashboards:1.0.0-beta1
I uses this Dockerfile
the opensearch_dashboards.yml
To Reproduce
Steps to reproduce the behavior:
when I run opensearch-dashboards-plugin list command , the securityDashboards plugin is in list ;but cannot remove
Expected behavior
A clear and concise description of what you expected to happen.
OpenSearch Version
Please list the version of OpenSearch being used.
Dashboards Version
Please list the version of OpenSearch Dashboards being used.
Plugins
Please list all plugins currently enabled.
Screenshots
If applicable, add screenshots to help explain your problem.
Host/Environment (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: