Revert "Default to converting folder name for cli plugin to kebab-case (#357)" #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-project#357)" (opensearch-project#578) This reverts commit 747ef8e. Reverting for now because the full impact is not known and requires subsequent commits to mitigate confusion related to CLI output. Also, it seems like in the code there exists verification on the code that plugins should explicitly be camelCase. So this merits more discussion. Issues related: opensearch-project#322 opensearch-project#465 opensearch-project#366 Signed-off-by: Kawika Avilla <[email protected]>
|
✅ DCO Check Passed ed179f6 |
ananzh
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 747ef8e.
Reverting for now because the full impact is not known and requires
subsequent commits to mitigate some confusion related to CLI output.
Also, it seems like in the code there exists verification on the code
that plugins should explicitly be camelCase. So this merits more
discussion but also could be bundled into a feature branch related to kebab
casing and prioritized for a vNext release.
Will create a new PR to re-enable this casing.
Issues related:
#322
Signed-off-by: Kawika Avilla [email protected]
Issues Resolved
#465
#366
Check List