Revert "Default to converting folder name for cli plugin to kebab-case (

opensearch-project#357)" This reverts commit 747ef8e. Reverting for now because the full impact is not known and requires subsequent commits to mitigate confusion related to CLI output. Also, it seems like in the code there exists verification on the code that plugins should explicitly be camelCase. So this merits more discussion. Issues related: opensearch-project#322 opensearch-project#465 opensearch-project#366 Signed-off-by: Kawika Avilla <[email protected]>
kavilla · Jul 1, 2021 · c0bf3ce · c0bf3ce
1 parent 570858a
commit c0bf3ce
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/src/cli_plugin/install/install.js b/src/cli_plugin/install/install.js
@@ -41,7 +41,6 @@ import { cleanPrevious, cleanArtifacts } from './cleanup';
 import { extract, getPackData } from './pack';
 import { renamePlugin } from './rename';
 import { existingInstall, assertVersion } from './opensearch_dashboards';
-import { kebabCase } from 'lodash';
 
 const mkdir = promisify(Fs.mkdir);
 
@@ -63,7 +62,7 @@ export async function install(settings, logger) {
 
     assertVersion(settings);
 
-    const targetDir = path.join(settings.pluginDir, kebabCase(settings.plugins[0].id));
+    const targetDir = path.join(settings.pluginDir, settings.plugins[0].id);
     await renamePlugin(settings.workingPath, targetDir);
 
     logger.log('Plugin installation complete');

diff --git a/src/cli_plugin/install/opensearch_dashboards.js b/src/cli_plugin/install/opensearch_dashboards.js
@@ -32,13 +32,12 @@
 
 import path from 'path';
 import { statSync } from 'fs';
-import { kebabCase } from 'lodash';
 
 import { versionSatisfies, cleanVersion } from '../../legacy/utils/version';
 
 export function existingInstall(settings, logger) {
   try {
-    statSync(path.join(settings.pluginDir, kebabCase(settings.plugins[0].id)));
+    statSync(path.join(settings.pluginDir, settings.plugins[0].id));
 
     logger.error(
       `Plugin ${settings.plugins[0].id} already exists, please remove before installing a new version`