Support multiple protocols and ports for a single GitRemote server and build URIs
#4429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pstreef
changed the title
GitRemote serverGitRemote server and build URIs
3 tasks
| public Parser registerRemote(Service service, String origin) { | ||
| if (origin.startsWith("https://") || origin.startsWith("http://") || origin.startsWith("ssh://")) { | ||
| origin = new Parser.HostAndPath(origin).concat(); | ||
| public URI toUri(GitRemote remote, boolean ssh) { |
There was a problem hiding this comment.
Would it make sense to change the ssh parameter to protocol to allow for http or https?
There was a problem hiding this comment.
I did not think it was very useful, but it's easy to add now, harder to change later. So lets!
bryceatmoderne
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
In stead of manipulating URIs and matching on a simple origin, we now register multiple URIs for a remote git server. This way we can indicate the multiple protocols/ports indeed point to the same server.
What's your motivation?
We can currently get multiple origins for the same server which means we could fail to match.
Anything in particular you'd like reviewers to focus on?
the
normalizeUrimethodAnyone you would like to review specifically?
@bryceatmoderne
Checklist